qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sven Schnelle <svens@stackframe.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] lsi: implement basic SBCL functionality
Date: Fri, 15 Feb 2019 20:36:52 +0100	[thread overview]
Message-ID: <20190215193651.GA19870@t470p.stackframe.org> (raw)
In-Reply-To: <65d59485-9973-4ed1-b08f-084ed4db7ef1@redhat.com>

On Fri, Feb 15, 2019 at 10:36:53AM +0100, Paolo Bonzini wrote:
> > HP-UX checks this register after sending data to the target. If there's no valid
> > information present, it assumes the client disconnected because the kernel sent
> > to much data. Implement at least some of the SBCL functionality that is possible
> > without having a real SCSI bus.
> > 
> > Signed-off-by: Sven Schnelle <svens@stackframe.org>
>  [..]
>
> This breaks live migration.  You need to bump the version number higher
> in vmstate_lsi_scsi and use "VMSTATE_UINT8_V(sbcl, LSIState, 1)" so that
> the field is only marshalled/unmarshalled for version 1 of the migration
> state.

Thanks, i wasn't aware of that. I'll send a revised v2.

Regards
Sven

  reply	other threads:[~2019-02-15 19:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 22:04 [Qemu-devel] [PATCH] lsi: implement basic SBCL functionality Sven Schnelle
2019-02-15  9:36 ` Paolo Bonzini
2019-02-15 19:36   ` Sven Schnelle [this message]
2019-02-15 19:40   ` [Qemu-devel] [PATCH v2] " Sven Schnelle
2019-03-04  8:22     ` Sven Schnelle
2019-03-04 10:07       ` Paolo Bonzini
2019-03-04 10:19   ` [Qemu-devel] [PATCH] " Peter Maydell
2019-03-04 10:50     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190215193651.GA19870@t470p.stackframe.org \
    --to=svens@stackframe.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).