From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <rth@twiddle.net>,
David Gibson <david@gibson.dropbear.id.au>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Collin Walling <walling@linux.ibm.com>,
Pierre Morel <pmorel@linux.ibm.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Greg Kurz <groug@kaod.org>, Igor Mammedov <imammedo@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/6] tests/device-plug: Add CCW unplug test for s390x
Date: Mon, 18 Feb 2019 10:31:14 +0100 [thread overview]
Message-ID: <20190218103114.1f77fe5d.cohuck@redhat.com> (raw)
In-Reply-To: <20190218092202.26683-5-david@redhat.com>
On Mon, 18 Feb 2019 10:22:00 +0100
David Hildenbrand <david@redhat.com> wrote:
> As CCW unplugs are surprise removals without asking the guest first,
> we can test this without any guest interaction.
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> tests/device-plug-test.c | 41 +++++++++++++++++++++++++++++++++++-----
> 1 file changed, 36 insertions(+), 5 deletions(-)
No in-depth review, but looks reasonable.
Acked-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-02-18 9:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 9:21 [Qemu-devel] [PATCH v3 0/6] tests: Add device unplug tests David Hildenbrand
2019-02-18 9:21 ` [Qemu-devel] [PATCH v3 1/6] cpus: Properly release the iothread lock when killing a dummy VCPU David Hildenbrand
2019-02-18 9:21 ` [Qemu-devel] [PATCH v3 2/6] spapr: support memory unplug for qtest David Hildenbrand
2019-02-18 9:21 ` [Qemu-devel] [PATCH v3 3/6] tests/device-plug: Add a simple PCI unplug request test David Hildenbrand
2019-02-18 9:30 ` Cornelia Huck
2019-02-18 9:22 ` [Qemu-devel] [PATCH v3 4/6] tests/device-plug: Add CCW unplug test for s390x David Hildenbrand
2019-02-18 9:31 ` Cornelia Huck [this message]
2019-02-18 9:22 ` [Qemu-devel] [PATCH v3 5/6] tests/device-plug: Add CPU core unplug request test for spapr David Hildenbrand
2019-02-18 9:22 ` [Qemu-devel] [PATCH v3 6/6] tests/device-plug: Add memory " David Hildenbrand
2019-02-19 2:58 ` [Qemu-devel] [PATCH v3 0/6] tests: Add device unplug tests David Gibson
2019-02-19 7:41 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218103114.1f77fe5d.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).