[Qemu-devel] [PULL 00/10] s390x update

qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed

* [Qemu-devel] [PULL 00/10] s390x update
@ 2019-02-05 16:40 Cornelia Huck
  2019-02-05 18:21 ` Peter Maydell
  0 siblings, 1 reply; 23+ messages in thread
From: Cornelia Huck @ 2019-02-05 16:40 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Cornelia Huck

The following changes since commit a61faa3d02159d24d4fa984733dbc0c905508752:

  Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.0-20190204' into staging (2019-02-04 10:33:40 +0000)

are available in the Git repository at:

  https://github.com/cohuck/qemu tags/s390x-20190205

for you to fetch changes up to 2313a88fe68cb970532ba1641ffc35c848daae86:

  s390x/pci: Unplug remaining requested devices on pcihost reset (2019-02-05 10:34:06 +0100)

----------------------------------------------------------------
Fixes and improvements in tcg and the zPCI code.

----------------------------------------------------------------

Alex Bennée (1):
  target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG

Cornelia Huck (1):
  s390x/pci: mark zpci devices as unmigratable

David Hildenbrand (7):
  s390x/pci: Introduce unplug requests and split unplug handler
  s390x/pci: Drop release timer and replace it with a flag
  s390x/tcg: Don't model FP registers as globals
  s390x/pci: Fix primary bus number for PCI bridges
  s390x/pci: Fix hotplugging of PCI bridges
  s390x/pci: Warn when adding PCI devices without the 'zpci' feature
  s390x/pci: Unplug remaining requested devices on pcihost reset

Igor Mammedov (1):
  s390x: remove direct reference to mem_path global from s390x code

 hw/s390x/s390-pci-bus.c    | 244 ++++++++++++++++++++++++-------------
 hw/s390x/s390-pci-bus.h    |   4 +-
 target/s390x/cpu.h         |   4 +
 target/s390x/insn-data.def | 150 +++++++++++------------
 target/s390x/kvm.c         |   5 +-
 target/s390x/translate.c   | 135 ++++++++++++--------
 6 files changed, 330 insertions(+), 212 deletions(-)

-- 
2.17.2

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-05 16:40 Cornelia Huck
@ 2019-02-05 18:21 ` Peter Maydell
  0 siblings, 0 replies; 23+ messages in thread
From: Peter Maydell @ 2019-02-05 18:21 UTC (permalink / raw)
  To: Cornelia Huck; +Cc: qemu-s390x, QEMU Developers

On Tue, 5 Feb 2019 at 16:41, Cornelia Huck <cohuck@redhat.com> wrote:
>
> The following changes since commit a61faa3d02159d24d4fa984733dbc0c905508752:
>
>   Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.0-20190204' into staging (2019-02-04 10:33:40 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/cohuck/qemu tags/s390x-20190205
>
> for you to fetch changes up to 2313a88fe68cb970532ba1641ffc35c848daae86:
>
>   s390x/pci: Unplug remaining requested devices on pcihost reset (2019-02-05 10:34:06 +0100)
>
> ----------------------------------------------------------------
> Fixes and improvements in tcg and the zPCI code.
>
> ----------------------------------------------------------------

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 00/10] s390x update
@ 2019-02-18 11:11 Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 01/10] s390x: Fix the confusing contributions-after-2012 license statements Cornelia Huck
                   ` (19 more replies)
  0 siblings, 20 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Cornelia Huck

The following changes since commit 1e36232994c8ad01774501d2e299deba3a2469af:

  Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20190215' into staging (2019-02-15 11:12:14 +0000)

are available in the Git repository at:

  https://github.com/cohuck/qemu tags/s390x-20190218

for you to fetch changes up to 0922e8c093a564219fcb7f43b18ceb12714dd931:

  s390x: upgrade status of KVM cores to "supported" (2019-02-18 12:00:44 +0100)

----------------------------------------------------------------
s390x updates:
- tcg: implement STCK and friends for CONFIG_USER_ONLY
- add zpci to qemu cpu model, as pci is now always built
- add mepoch to default z14 cpu model
- add cpu model for z14 GA2
- various improvements

----------------------------------------------------------------

Collin Walling (3):
  s390x/cpumodel: mepochptff: warn when no mepoch and re-align group
    init
  s390x/cpumodel: default enable mepoch for z14 and later
  s390x/cpumodel: add z14 GA2 model

Cornelia Huck (3):
  s390x: always provide pci support
  s390x/kvm: add tracepoint to ioeventfd interface
  s390x: upgrade status of KVM cores to "supported"

David Hildenbrand (1):
  s390x: add zPCI feature to "qemu" CPU model

Richard Henderson (2):
  target/s390x: Split out s390-tod.h
  target/s390x: Implement STCK et al for CONFIG_USER_ONLY

Thomas Huth (1):
  s390x: Fix the confusing contributions-after-2012 license statements

 MAINTAINERS                   |  2 +-
 hw/s390x/Makefile.objs        |  3 +-
 hw/s390x/s390-pci-stub.c      | 77 -----------------------------------
 hw/s390x/s390-virtio-ccw.c    |  8 ++--
 include/hw/s390x/tod.h        | 16 +-------
 linux-user/s390x/target_cpu.h | 19 ++++-----
 target/s390x/cpu.c            | 19 ++++-----
 target/s390x/cpu.h            | 19 ++++-----
 target/s390x/cpu_features.c   |  2 +-
 target/s390x/cpu_models.c     | 34 +++++++++++++---
 target/s390x/cpu_models.h     |  2 +
 target/s390x/gen-features.c   | 18 ++++++--
 target/s390x/helper.h         |  2 +-
 target/s390x/insn-data.def    | 11 ++---
 target/s390x/kvm.c            | 25 +++++-------
 target/s390x/misc_helper.c    | 34 ++++++++++------
 target/s390x/s390-tod.h       | 29 +++++++++++++
 target/s390x/trace-events     |  1 +
 target/s390x/translate.c      |  2 +
 19 files changed, 150 insertions(+), 173 deletions(-)
 delete mode 100644 hw/s390x/s390-pci-stub.c
 create mode 100644 target/s390x/s390-tod.h

-- 
2.17.2

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 01/10] s390x: Fix the confusing contributions-after-2012 license statements
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
@ 2019-02-18 11:11 ` Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 02/10] s390x: always provide pci support Cornelia Huck
                   ` (18 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Thomas Huth, Cornelia Huck

From: Thomas Huth <thuth@redhat.com>

The license information in these files is rather confusing. The text
declares LGPL first, but then says that contributions after 2012 are
licensed under the GPL instead. How should the average user who just
downloaded the release tarball know which part is now GPL and which
is LGPL?

Looking at the text of the LGPL (see COPYING.LIB in the top directory),
the license clearly states how this should be done instead:

"3. You may opt to apply the terms of the ordinary GNU General Public
 License instead of this License to a given copy of the Library. To do
 this, you must alter all the notices that refer to this License, so
 that they refer to the ordinary GNU General Public License, version 2,
 instead of to this License."

Thus let's clean up the confusing statements and use the proper GPL
text only.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1549456893-16589-1-git-send-email-thuth@redhat.com>
Acked-by: Laurent Vivier <laurent@vivier.eu>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 linux-user/s390x/target_cpu.h | 19 ++++++++-----------
 target/s390x/cpu.c            | 19 ++++++++-----------
 target/s390x/cpu.h            | 19 ++++++++-----------
 target/s390x/kvm.c            | 19 ++++++++-----------
 4 files changed, 32 insertions(+), 44 deletions(-)

diff --git a/linux-user/s390x/target_cpu.h b/linux-user/s390x/target_cpu.h
index 66ef8aa8c27f..aa181ceaee83 100644
--- a/linux-user/s390x/target_cpu.h
+++ b/linux-user/s390x/target_cpu.h
@@ -3,21 +3,18 @@
  *
  * Copyright (c) 2009 Ulrich Hecht
  *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
  *
- * This library is distributed in the hope that it will be useful,
+ * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
+ * General Public License for more details.
  *
- * Contributions after 2012-10-29 are licensed under the terms of the
- * GNU GPL, version 2 or (at your option) any later version.
- *
- * You should have received a copy of the GNU (Lesser) General Public
- * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 #ifndef S390X_TARGET_CPU_H
 #define S390X_TARGET_CPU_H
diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index 18ba7f85a5f1..698dd9cb82ab 100644
--- a/target/s390x/cpu.c
+++ b/target/s390x/cpu.c
@@ -6,21 +6,18 @@
  * Copyright (c) 2012 SUSE LINUX Products GmbH
  * Copyright (c) 2012 IBM Corp.
  *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
  *
- * This library is distributed in the hope that it will be useful,
+ * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
+ * General Public License for more details.
  *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, see
- * <http://www.gnu.org/licenses/lgpl-2.1.html>
- * Contributions after 2012-12-11 are licensed under the terms of the
- * GNU GPL, version 2 or (at your option) any later version.
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "qemu/osdep.h"
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 47d2c2e9cf2b..b71ac5183dee 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -4,21 +4,18 @@
  *  Copyright (c) 2009 Ulrich Hecht
  *  Copyright IBM Corp. 2012, 2018
  *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
  *
- * This library is distributed in the hope that it will be useful,
+ * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
+ * General Public License for more details.
  *
- * Contributions after 2012-10-29 are licensed under the terms of the
- * GNU GPL, version 2 or (at your option) any later version.
- *
- * You should have received a copy of the GNU (Lesser) General Public
- * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifndef S390X_CPU_H
diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 8613e19d1143..9ff80c8461d0 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -4,21 +4,18 @@
  * Copyright (c) 2009 Alexander Graf <agraf@suse.de>
  * Copyright IBM Corp. 2012
  *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
  *
- * This library is distributed in the hope that it will be useful,
+ * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
+ * General Public License for more details.
  *
- * Contributions after 2012-10-29 are licensed under the terms of the
- * GNU GPL, version 2 or (at your option) any later version.
- *
- * You should have received a copy of the GNU (Lesser) General Public
- * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "qemu/osdep.h"
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 02/10] s390x: always provide pci support
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 01/10] s390x: Fix the confusing contributions-after-2012 license statements Cornelia Huck
@ 2019-02-18 11:11 ` Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 03/10] target/s390x: Split out s390-tod.h Cornelia Huck
                   ` (17 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Cornelia Huck

We tried to make pci support optional on s390x in the past;
unfortunately, we still require the s390 phb to be created
unconditionally due to backwards compatibility issues.

Instead of sinking more effort into this (including compat
handling for older machines etc.) for non-obvious gains, let's
just make CONFIG_PCI something that is always set on s390x.

Note that you can still fence off pci for the _guest_ if you
provide a cpu model without the zpci feature.

Message-Id: <20190211113255.3837-1-cohuck@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/s390x/Makefile.objs      |  3 +-
 hw/s390x/s390-pci-stub.c    | 77 -------------------------------------
 hw/s390x/s390-virtio-ccw.c  |  4 --
 target/s390x/cpu_models.c   |  5 ---
 target/s390x/gen-features.c |  1 -
 target/s390x/kvm.c          |  4 +-
 6 files changed, 2 insertions(+), 92 deletions(-)
 delete mode 100644 hw/s390x/s390-pci-stub.c

diff --git a/hw/s390x/Makefile.objs b/hw/s390x/Makefile.objs
index a18c4719137e..bfd5326d7c3d 100644
--- a/hw/s390x/Makefile.objs
+++ b/hw/s390x/Makefile.objs
@@ -21,8 +21,7 @@ obj-$(call land,$(CONFIG_VIRTIO_9P),$(CONFIG_VIRTFS)) += virtio-ccw-9p.o
 obj-$(CONFIG_VHOST_VSOCK) += vhost-vsock-ccw.o
 obj-y += css-bridge.o
 obj-y += ccw-device.o
-obj-$(CONFIG_PCI) += s390-pci-bus.o s390-pci-inst.o
-obj-$(call lnot,$(CONFIG_PCI)) += s390-pci-stub.o
+obj-y += s390-pci-bus.o s390-pci-inst.o
 obj-y += s390-skeys.o
 obj-y += s390-stattrib.o
 obj-y += tod.o
diff --git a/hw/s390x/s390-pci-stub.c b/hw/s390x/s390-pci-stub.c
deleted file mode 100644
index ad4c5a77198f..000000000000
--- a/hw/s390x/s390-pci-stub.c
+++ /dev/null
@@ -1,77 +0,0 @@
-/* stubs for non-pci builds */
-
-#include "qemu/osdep.h"
-#include "qemu-common.h"
-#include "cpu.h"
-#include "s390-pci-inst.h"
-#include "s390-pci-bus.h"
-
-/* target/s390x/ioinst.c */
-int pci_chsc_sei_nt2_get_event(void *res)
-{
-    return 1;
-}
-
-int pci_chsc_sei_nt2_have_event(void)
-{
-    return 0;
-}
-
-/* hw/s390x/sclp.c */
-void s390_pci_sclp_configure(SCCB *sccb)
-{
-    sccb->h.response_code = cpu_to_be16(SCLP_RC_ADAPTER_TYPE_NOT_RECOGNIZED);
-}
-
-void s390_pci_sclp_deconfigure(SCCB *sccb)
-{
-    sccb->h.response_code = cpu_to_be16(SCLP_RC_ADAPTER_TYPE_NOT_RECOGNIZED);
-}
-
-/* target/s390x/kvm.c */
-int clp_service_call(S390CPU *cpu, uint8_t r2)
-{
-    return -1;
-}
-
-int pcilg_service_call(S390CPU *cpu, uint8_t r1, uint8_t r2)
-{
-    return -1;
-}
-
-int pcistg_service_call(S390CPU *cpu, uint8_t r1, uint8_t r2)
-{
-    return -1;
-}
-
-int stpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar)
-{
-    return -1;
-}
-
-int rpcit_service_call(S390CPU *cpu, uint8_t r1, uint8_t r2)
-{
-    return -1;
-}
-
-int pcistb_service_call(S390CPU *cpu, uint8_t r1, uint8_t r3, uint64_t gaddr,
-                        uint8_t ar)
-{
-    return -1;
-}
-
-int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar)
-{
-    return -1;
-}
-
-S390pciState *s390_get_phb(void)
-{
-    return NULL;
-}
-
-S390PCIBusDevice *s390_pci_find_dev_by_target(S390pciState *s,
-                                              const char *target)
-{
-    return NULL;
-}
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 811fdf913dd6..3fb5c88af9cc 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -272,10 +272,6 @@ static void ccw_init(MachineState *machine)
                       machine->initrd_filename, "s390-ccw.img",
                       "s390-netboot.img", true);
 
-    /*
-     * We cannot easily make the pci host bridge conditional as older QEMUs
-     * always created it. Doing so would break migration across QEMU versions.
-     */
     dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);
     object_property_add_child(qdev_get_machine(), TYPE_S390_PCI_HOST_BRIDGE,
                               OBJECT(dev), NULL);
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 7c253ff308c5..249011fd62f5 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -1314,11 +1314,6 @@ static void register_types(void)
 
     /* init all bitmaps from gnerated data initially */
     s390_init_feat_bitmap(qemu_max_cpu_feat_init, qemu_max_cpu_feat);
-#ifndef CONFIG_USER_ONLY
-    if (!pci_available) {
-        clear_bit(S390_FEAT_ZPCI, qemu_max_cpu_feat);
-    }
-#endif
     for (i = 0; i < ARRAY_SIZE(s390_cpu_defs); i++) {
         s390_init_feat_bitmap(s390_cpu_defs[i].base_init,
                               s390_cpu_defs[i].base_feat);
diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index 70015eaaf5df..b0e9b271e228 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -598,7 +598,6 @@ static uint16_t qemu_MAX[] = {
     S390_FEAT_STFLE_53,
     /* generates a dependency warning, leave it out for now */
     S390_FEAT_MSA_EXT_5,
-    /* only with CONFIG_PCI */
     S390_FEAT_ZPCI,
 };
 
diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 9ff80c8461d0..15fdc168e1c5 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -2278,9 +2278,7 @@ void kvm_s390_get_host_cpu_model(S390CPUModel *model, Error **errp)
     }
 
     /* We emulate a zPCI bus and AEN, therefore we don't need HW support */
-    if (pci_available) {
-        set_bit(S390_FEAT_ZPCI, model->features);
-    }
+    set_bit(S390_FEAT_ZPCI, model->features);
     set_bit(S390_FEAT_ADAPTER_EVENT_NOTIFICATION, model->features);
 
     if (s390_known_cpu_type(cpu_type)) {
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 03/10] target/s390x: Split out s390-tod.h
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 01/10] s390x: Fix the confusing contributions-after-2012 license statements Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 02/10] s390x: always provide pci support Cornelia Huck
@ 2019-02-18 11:11 ` Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 04/10] target/s390x: Implement STCK et al for CONFIG_USER_ONLY Cornelia Huck
                   ` (16 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Richard Henderson, Cornelia Huck

From: Richard Henderson <richard.henderson@linaro.org>

We will need these from CONFIG_USER_ONLY as well,
which cannot access include/hw/.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20190212053044.29015-2-richard.henderson@linaro.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 include/hw/s390x/tod.h  | 16 +---------------
 target/s390x/s390-tod.h | 29 +++++++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 15 deletions(-)
 create mode 100644 target/s390x/s390-tod.h

diff --git a/include/hw/s390x/tod.h b/include/hw/s390x/tod.h
index 47ef9de869cc..9c4a6000c331 100644
--- a/include/hw/s390x/tod.h
+++ b/include/hw/s390x/tod.h
@@ -12,6 +12,7 @@
 #define HW_S390_TOD_H
 
 #include "hw/qdev.h"
+#include "s390-tod.h"
 
 typedef struct S390TOD {
     uint8_t high;
@@ -50,21 +51,6 @@ typedef struct S390TODClass {
     void (*set)(S390TODState *td, const S390TOD *tod, Error **errp);
 } S390TODClass;
 
-/* The value of the TOD clock for 1.1.1970. */
-#define TOD_UNIX_EPOCH 0x7d91048bca000000ULL
-
-/* Converts ns to s390's clock format */
-static inline uint64_t time2tod(uint64_t ns)
-{
-    return (ns << 9) / 125 + (((ns & 0xff80000000000000ull) / 125) << 9);
-}
-
-/* Converts s390's clock format to ns */
-static inline uint64_t tod2time(uint64_t t)
-{
-    return ((t >> 9) * 125) + (((t & 0x1ff) * 125) >> 9);
-}
-
 void s390_init_tod(void);
 S390TODState *s390_get_todstate(void);
 
diff --git a/target/s390x/s390-tod.h b/target/s390x/s390-tod.h
new file mode 100644
index 000000000000..8b74d6a6d886
--- /dev/null
+++ b/target/s390x/s390-tod.h
@@ -0,0 +1,29 @@
+/*
+ * TOD (Time Of Day) clock
+ *
+ * Copyright 2018 Red Hat, Inc.
+ * Author(s): David Hildenbrand <david@redhat.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+#ifndef TARGET_S390_TOD_H
+#define TARGET_S390_TOD_H
+
+/* The value of the TOD clock for 1.1.1970. */
+#define TOD_UNIX_EPOCH 0x7d91048bca000000ULL
+
+/* Converts ns to s390's clock format */
+static inline uint64_t time2tod(uint64_t ns)
+{
+    return (ns << 9) / 125 + (((ns & 0xff80000000000000ull) / 125) << 9);
+}
+
+/* Converts s390's clock format to ns */
+static inline uint64_t tod2time(uint64_t t)
+{
+    return ((t >> 9) * 125) + (((t & 0x1ff) * 125) >> 9);
+}
+
+#endif
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 04/10] target/s390x: Implement STCK et al for CONFIG_USER_ONLY
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (2 preceding siblings ...)
  2019-02-18 11:11 ` [Qemu-devel] [PULL 03/10] target/s390x: Split out s390-tod.h Cornelia Huck
@ 2019-02-18 11:11 ` Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 05/10] s390x: add zPCI feature to "qemu" CPU model Cornelia Huck
                   ` (15 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Richard Henderson, Cornelia Huck

From: Richard Henderson <richard.henderson@linaro.org>

This is a non-privileged instruction that was only implemented
for system mode.  However, the stck instruction is used by glibc,
so this was causing SIGILL for programs run under debian stretch.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20190212053044.29015-3-richard.henderson@linaro.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/helper.h      |  2 +-
 target/s390x/insn-data.def | 11 ++++++-----
 target/s390x/misc_helper.c | 34 ++++++++++++++++++++++------------
 target/s390x/translate.c   |  2 ++
 4 files changed, 31 insertions(+), 18 deletions(-)

diff --git a/target/s390x/helper.h b/target/s390x/helper.h
index 018e9dd41487..6260b5049621 100644
--- a/target/s390x/helper.h
+++ b/target/s390x/helper.h
@@ -121,13 +121,13 @@ DEF_HELPER_4(cu41, i32, env, i32, i32, i32)
 DEF_HELPER_4(cu42, i32, env, i32, i32, i32)
 DEF_HELPER_5(msa, i32, env, i32, i32, i32, i32)
 DEF_HELPER_FLAGS_1(stpt, TCG_CALL_NO_RWG, i64, env)
+DEF_HELPER_FLAGS_1(stck, TCG_CALL_NO_RWG_SE, i64, env)
 
 #ifndef CONFIG_USER_ONLY
 DEF_HELPER_3(servc, i32, env, i64, i64)
 DEF_HELPER_4(diag, void, env, i32, i32, i32)
 DEF_HELPER_3(load_psw, noreturn, env, i64, i64)
 DEF_HELPER_FLAGS_2(spx, TCG_CALL_NO_RWG, void, env, i64)
-DEF_HELPER_FLAGS_1(stck, TCG_CALL_NO_RWG_SE, i64, env)
 DEF_HELPER_FLAGS_2(sck, TCG_CALL_NO_RWG, i32, env, i64)
 DEF_HELPER_FLAGS_2(sckc, TCG_CALL_NO_RWG, void, env, i64)
 DEF_HELPER_FLAGS_2(sckpf, TCG_CALL_NO_RWG, void, env, i64)
diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def
index dab805fd90b4..61582372abb7 100644
--- a/target/s390x/insn-data.def
+++ b/target/s390x/insn-data.def
@@ -837,6 +837,12 @@
     C(0xe33e, STRV,    RXY_a, Z,   la2, r1_32u, new, m1_32, rev32, 0)
     C(0xe32f, STRVG,   RXY_a, Z,   la2, r1_o, new, m1_64, rev64, 0)
 
+/* STORE CLOCK */
+    C(0xb205, STCK,    S,     Z,   la2, 0, new, m1_64, stck, 0)
+    C(0xb27c, STCKF,   S,     SCF, la2, 0, new, m1_64, stck, 0)
+/* STORE CLOCK EXTENDED */
+    C(0xb278, STCKE,   S,     Z,   0, a2, 0, 0, stcke, 0)
+
 /* STORE FACILITY LIST EXTENDED */
     C(0xb2b0, STFLE,   S,  SFLE,   0, a2, 0, 0, stfle, 0)
 /* STORE FPC */
@@ -1020,11 +1026,6 @@
     F(0x8000, SSM,     S,     Z,   0, m2_8u, 0, 0, ssm, 0, IF_PRIV)
 /* SIGNAL PROCESSOR */
     F(0xae00, SIGP,    RS_a,  Z,   0, a2, 0, 0, sigp, 0, IF_PRIV)
-/* STORE CLOCK */
-    C(0xb205, STCK,    S,     Z,   la2, 0, new, m1_64, stck, 0)
-    C(0xb27c, STCKF,   S,     SCF, la2, 0, new, m1_64, stck, 0)
-/* STORE CLOCK EXTENDED */
-    C(0xb278, STCKE,   S,     Z,   0, a2, 0, 0, stcke, 0)
 /* STORE CLOCK COMPARATOR */
     F(0xb207, STCKC,   S,     Z,   la2, 0, new, m1_64a, stckc, 0, IF_PRIV)
 /* STORE CONTROL */
diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
index 52262f62df26..ee67c1fa0c51 100644
--- a/target/s390x/misc_helper.c
+++ b/target/s390x/misc_helper.c
@@ -30,6 +30,7 @@
 #include "exec/cpu_ldst.h"
 #include "qapi/error.h"
 #include "tcg_s390x.h"
+#include "s390-tod.h"
 
 #if !defined(CONFIG_USER_ONLY)
 #include "sysemu/cpus.h"
@@ -76,8 +77,28 @@ uint64_t HELPER(stpt)(CPUS390XState *env)
 #endif
 }
 
-#ifndef CONFIG_USER_ONLY
+/* Store Clock */
+uint64_t HELPER(stck)(CPUS390XState *env)
+{
+#ifdef CONFIG_USER_ONLY
+    struct timespec ts;
+    uint64_t ns;
+
+    clock_gettime(CLOCK_REALTIME, &ts);
+    ns = ts.tv_sec * NANOSECONDS_PER_SECOND + ts.tv_nsec;
+
+    return TOD_UNIX_EPOCH + time2tod(ns);
+#else
+    S390TODState *td = s390_get_todstate();
+    S390TODClass *tdc = S390_TOD_GET_CLASS(td);
+    S390TOD tod;
 
+    tdc->get(td, &tod, &error_abort);
+    return tod.low;
+#endif
+}
+
+#ifndef CONFIG_USER_ONLY
 /* SCLP service call */
 uint32_t HELPER(servc)(CPUS390XState *env, uint64_t r1, uint64_t r2)
 {
@@ -138,17 +159,6 @@ void HELPER(spx)(CPUS390XState *env, uint64_t a1)
     tlb_flush_page(cs, TARGET_PAGE_SIZE);
 }
 
-/* Store Clock */
-uint64_t HELPER(stck)(CPUS390XState *env)
-{
-    S390TODState *td = s390_get_todstate();
-    S390TODClass *tdc = S390_TOD_GET_CLASS(td);
-    S390TOD tod;
-
-    tdc->get(td, &tod, &error_abort);
-    return tod.low;
-}
-
 static void update_ckc_timer(CPUS390XState *env)
 {
     S390TODState *td = s390_get_todstate();
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 639084af07d0..19072efec655 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -4060,6 +4060,7 @@ static DisasJumpType op_stap(DisasContext *s, DisasOps *o)
     tcg_gen_ld32u_i64(o->out, cpu_env, offsetof(CPUS390XState, core_id));
     return DISAS_NEXT;
 }
+#endif
 
 static DisasJumpType op_stck(DisasContext *s, DisasOps *o)
 {
@@ -4096,6 +4097,7 @@ static DisasJumpType op_stcke(DisasContext *s, DisasOps *o)
     return DISAS_NEXT;
 }
 
+#ifndef CONFIG_USER_ONLY
 static DisasJumpType op_sck(DisasContext *s, DisasOps *o)
 {
     tcg_gen_qemu_ld_i64(o->in1, o->addr1, get_mem_index(s), MO_TEQ | MO_ALIGN);
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 05/10] s390x: add zPCI feature to "qemu" CPU model
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (3 preceding siblings ...)
  2019-02-18 11:11 ` [Qemu-devel] [PULL 04/10] target/s390x: Implement STCK et al for CONFIG_USER_ONLY Cornelia Huck
@ 2019-02-18 11:11 ` Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 06/10] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init Cornelia Huck
                   ` (14 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, David Hildenbrand, Cornelia Huck

From: David Hildenbrand <david@redhat.com>

As we now always have PCI support, let's add it to the "qemu" CPU model,
taking care of backwards compatibility.

Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190212112323.15904-1-david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/s390x/s390-virtio-ccw.c  | 3 +++
 target/s390x/gen-features.c | 8 ++++++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 3fb5c88af9cc..1a3414b64280 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -657,7 +657,10 @@ DEFINE_CCW_MACHINE(4_0, "4.0", true);
 
 static void ccw_machine_3_1_instance_options(MachineState *machine)
 {
+    static const S390FeatInit qemu_cpu_feat = { S390_FEAT_LIST_QEMU_V3_1 };
     ccw_machine_4_0_instance_options(machine);
+
+    s390_set_qemu_cpu_model(0x2827, 12, 2, qemu_cpu_feat);
 }
 
 static void ccw_machine_3_1_class_options(MachineClass *mc)
diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index b0e9b271e228..19bb8ac7f890 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -560,7 +560,7 @@ static uint16_t qemu_V2_11[] = {
     S390_FEAT_ZARCH,
 };
 
-static uint16_t qemu_LATEST[] = {
+static uint16_t qemu_V3_1[] = {
     S390_FEAT_DAT_ENH,
     S390_FEAT_IDTE_SEGMENT,
     S390_FEAT_STFLE,
@@ -592,13 +592,16 @@ static uint16_t qemu_LATEST[] = {
     S390_FEAT_MSA_EXT_4,
 };
 
+static uint16_t qemu_LATEST[] = {
+    S390_FEAT_ZPCI,
+};
+
 /* add all new definitions before this point */
 static uint16_t qemu_MAX[] = {
     /* z13+ features */
     S390_FEAT_STFLE_53,
     /* generates a dependency warning, leave it out for now */
     S390_FEAT_MSA_EXT_5,
-    S390_FEAT_ZPCI,
 };
 
 /****** END FEATURE DEFS ******/
@@ -708,6 +711,7 @@ static FeatGroupDefSpec FeatGroupDef[] = {
  *******************************/
 static FeatGroupDefSpec QemuFeatDef[] = {
     QEMU_FEAT_INITIALIZER(V2_11),
+    QEMU_FEAT_INITIALIZER(V3_1),
     QEMU_FEAT_INITIALIZER(LATEST),
     QEMU_FEAT_INITIALIZER(MAX),
 };
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 06/10] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (4 preceding siblings ...)
  2019-02-18 11:11 ` [Qemu-devel] [PULL 05/10] s390x: add zPCI feature to "qemu" CPU model Cornelia Huck
@ 2019-02-18 11:11 ` Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 07/10] s390x/cpumodel: default enable mepoch for z14 and later Cornelia Huck
                   ` (13 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Collin Walling, Cornelia Huck

From: Collin Walling <walling@linux.ibm.com>

The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent
on the multiple-epoch facility (mepoch). Let's print a warning if these
features are enabled without mepoch.

While we're at it, let's move the FEAT_GROUP_INIT for mepochptff down
the s390_feature_groups list so it can be properly indexed with its
generated S390FeatGroup enum.

Signed-off-by: Collin Walling <walling@linux.ibm.com>
Message-Id: <20190212011657.18324-1-walling@linux.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/cpu_features.c | 2 +-
 target/s390x/cpu_models.c   | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c
index 60cfeba48f4e..1843c84aaadc 100644
--- a/target/s390x/cpu_features.c
+++ b/target/s390x/cpu_features.c
@@ -456,7 +456,6 @@ static S390FeatGroupDef s390_feature_groups[] = {
     FEAT_GROUP_INIT("plo", PLO, "Perform-locked-operation facility"),
     FEAT_GROUP_INIT("tods", TOD_CLOCK_STEERING, "Tod-clock-steering facility"),
     FEAT_GROUP_INIT("gen13ptff", GEN13_PTFF, "PTFF enhancements introduced with z13"),
-    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),
     FEAT_GROUP_INIT("msa", MSA, "Message-security-assist facility"),
     FEAT_GROUP_INIT("msa1", MSA_EXT_1, "Message-security-assist-extension 1 facility"),
     FEAT_GROUP_INIT("msa2", MSA_EXT_2, "Message-security-assist-extension 2 facility"),
@@ -466,6 +465,7 @@ static S390FeatGroupDef s390_feature_groups[] = {
     FEAT_GROUP_INIT("msa6", MSA_EXT_6, "Message-security-assist-extension 6 facility"),
     FEAT_GROUP_INIT("msa7", MSA_EXT_7, "Message-security-assist-extension 7 facility"),
     FEAT_GROUP_INIT("msa8", MSA_EXT_8, "Message-security-assist-extension 8 facility"),
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),
 };
 
 const S390FeatGroupDef *s390_feat_group_def(S390FeatGroup group)
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 249011fd62f5..8002412f9af1 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -788,6 +788,10 @@ static void check_consistency(const S390CPUModel *model)
         { S390_FEAT_SIE_KSS, S390_FEAT_SIE_F2 },
         { S390_FEAT_AP_QUERY_CONFIG_INFO, S390_FEAT_AP },
         { S390_FEAT_AP_FACILITIES_TEST, S390_FEAT_AP },
+        { S390_FEAT_PTFF_QSIE, S390_FEAT_MULTIPLE_EPOCH },
+        { S390_FEAT_PTFF_QTOUE, S390_FEAT_MULTIPLE_EPOCH },
+        { S390_FEAT_PTFF_STOE, S390_FEAT_MULTIPLE_EPOCH },
+        { S390_FEAT_PTFF_STOUE, S390_FEAT_MULTIPLE_EPOCH },
     };
     int i;
 
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 07/10] s390x/cpumodel: default enable mepoch for z14 and later
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (5 preceding siblings ...)
  2019-02-18 11:11 ` [Qemu-devel] [PULL 06/10] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init Cornelia Huck
@ 2019-02-18 11:11 ` Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 08/10] s390x/cpumodel: add z14 GA2 model Cornelia Huck
                   ` (12 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Collin Walling, Cornelia Huck

From: Collin Walling <walling@linux.ibm.com>

Latest systems and host kernels support mepoch, which is a
feature that was meant to be supported for z14 GA1 from the
get-go. Let's copy it to the z14 GA1 default CPU model.

Machines s390-ccw-virtio-3.1 and older will retain the old CPU
models and will not provide this bit nor the extended PTFF
functions in the default model.

Signed-off-by: Collin Walling <walling@linux.ibm.com>
Message-Id: <20190212011657.18324-2-walling@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/s390x/s390-virtio-ccw.c  |  3 ++-
 target/s390x/cpu_models.c   | 24 ++++++++++++++++++++++++
 target/s390x/cpu_models.h   |  2 ++
 target/s390x/gen-features.c |  2 ++
 4 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 1a3414b64280..d11069b860b4 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -659,7 +659,8 @@ static void ccw_machine_3_1_instance_options(MachineState *machine)
 {
     static const S390FeatInit qemu_cpu_feat = { S390_FEAT_LIST_QEMU_V3_1 };
     ccw_machine_4_0_instance_options(machine);
-
+    s390_cpudef_featoff_greater(14, 1, S390_FEAT_MULTIPLE_EPOCH);
+    s390_cpudef_group_featoff_greater(14, 1, S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF);
     s390_set_qemu_cpu_model(0x2827, 12, 2, qemu_cpu_feat);
 }
 
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 8002412f9af1..4e7e8cab0198 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -117,6 +117,30 @@ void s390_cpudef_featoff_greater(uint8_t gen, uint8_t ec_ga, S390Feat feat)
     }
 }
 
+void s390_cpudef_group_featoff_greater(uint8_t gen, uint8_t ec_ga,
+                                       S390FeatGroup group)
+{
+    const S390FeatGroupDef *group_def = s390_feat_group_def(group);
+    S390FeatBitmap group_def_off;
+    int i;
+
+    bitmap_complement(group_def_off, group_def->feat, S390_FEAT_MAX);
+
+    for (i = 0; i < ARRAY_SIZE(s390_cpu_defs); i++) {
+        const S390CPUDef *cpu_def = &s390_cpu_defs[i];
+
+        if (cpu_def->gen < gen) {
+            continue;
+        }
+        if (cpu_def->gen == gen && cpu_def->ec_ga < ec_ga) {
+            continue;
+        }
+
+        bitmap_and((unsigned long *)&cpu_def->default_feat,
+                   cpu_def->default_feat, group_def_off, S390_FEAT_MAX);
+    }
+}
+
 uint32_t s390_get_hmfai(void)
 {
     static S390CPU *cpu;
diff --git a/target/s390x/cpu_models.h b/target/s390x/cpu_models.h
index 11cf5386fbcf..174a99e56149 100644
--- a/target/s390x/cpu_models.h
+++ b/target/s390x/cpu_models.h
@@ -75,6 +75,8 @@ struct S390CPUModel {
 
 void s390_cpudef_featoff(uint8_t gen, uint8_t ec_ga, S390Feat feat);
 void s390_cpudef_featoff_greater(uint8_t gen, uint8_t ec_ga, S390Feat feat);
+void s390_cpudef_group_featoff_greater(uint8_t gen, uint8_t ec_ga,
+                                       S390FeatGroup group);
 uint32_t s390_get_hmfai(void);
 uint8_t s390_get_mha_pow(void);
 uint32_t s390_get_ibc_val(void);
diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index 19bb8ac7f890..dd6e8458ef00 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -550,6 +550,8 @@ static uint16_t default_GEN14_GA1[] = {
     S390_FEAT_GROUP_MSA_EXT_6,
     S390_FEAT_GROUP_MSA_EXT_7,
     S390_FEAT_GROUP_MSA_EXT_8,
+    S390_FEAT_MULTIPLE_EPOCH,
+    S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF,
 };
 
 /* QEMU (CPU model) features */
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 08/10] s390x/cpumodel: add z14 GA2 model
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (6 preceding siblings ...)
  2019-02-18 11:11 ` [Qemu-devel] [PULL 07/10] s390x/cpumodel: default enable mepoch for z14 and later Cornelia Huck
@ 2019-02-18 11:11 ` Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 09/10] s390x/kvm: add tracepoint to ioeventfd interface Cornelia Huck
                   ` (11 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Collin Walling, Cornelia Huck

From: Collin Walling <walling@linux.ibm.com>

Introduce the z14 GA2 cpu model for QEMU. There are no new features
introduced with this model, and will inherit the same feature set as
z14 GA1.

Signed-off-by: Collin Walling <walling@linux.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190212011657.18324-3-walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/cpu_models.c   | 1 +
 target/s390x/gen-features.c | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 4e7e8cab0198..54026c3c0013 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -79,6 +79,7 @@ static S390CPUDef s390_cpu_defs[] = {
     CPUDEF_INIT(0x2964, 13, 2, 47, 0x08000000U, "z13.2", "IBM z13 GA2"),
     CPUDEF_INIT(0x2965, 13, 2, 47, 0x08000000U, "z13s", "IBM z13s GA1"),
     CPUDEF_INIT(0x3906, 14, 1, 47, 0x08000000U, "z14", "IBM z14 GA1"),
+    CPUDEF_INIT(0x3906, 14, 2, 47, 0x08000000U, "z14.2", "IBM z14 GA2"),
     CPUDEF_INIT(0x3907, 14, 1, 47, 0x08000000U, "z14ZR1", "IBM z14 Model ZR1 GA1"),
 };
 
diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index dd6e8458ef00..44eca4547475 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -353,6 +353,8 @@ static uint16_t base_GEN14_GA1[] = {
     S390_FEAT_ORDER_PRESERVING_COMPRESSION,
 };
 
+#define base_GEN14_GA2 EmptyFeat
+
 /* Full features (in order of release)
  * Automatically includes corresponding base features.
  * Full features are all features this hardware supports even if kvm/QEMU do not
@@ -480,6 +482,8 @@ static uint16_t full_GEN14_GA1[] = {
     S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF,
 };
 
+#define full_GEN14_GA2 EmptyFeat
+
 /* Default features (in order of release)
  * Automatically includes corresponding base features.
  * Default features are all features this version of QEMU supports for this
@@ -554,6 +558,8 @@ static uint16_t default_GEN14_GA1[] = {
     S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF,
 };
 
+#define default_GEN14_GA2 EmptyFeat
+
 /* QEMU (CPU model) features */
 
 static uint16_t qemu_V2_11[] = {
@@ -664,6 +670,7 @@ static CpuFeatDefSpec CpuFeatDef[] = {
     CPU_FEAT_INITIALIZER(GEN13_GA1),
     CPU_FEAT_INITIALIZER(GEN13_GA2),
     CPU_FEAT_INITIALIZER(GEN14_GA1),
+    CPU_FEAT_INITIALIZER(GEN14_GA2),
 };
 
 #define FEAT_GROUP_INITIALIZER(_name)                  \
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 09/10] s390x/kvm: add tracepoint to ioeventfd interface
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (7 preceding siblings ...)
  2019-02-18 11:11 ` [Qemu-devel] [PULL 08/10] s390x/cpumodel: add z14 GA2 model Cornelia Huck
@ 2019-02-18 11:11 ` Cornelia Huck
  2019-02-18 11:11 ` [Qemu-devel] [PULL 10/10] s390x: upgrade status of KVM cores to "supported" Cornelia Huck
                   ` (10 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Cornelia Huck

Trace when assigning/unassigning.

Message-Id: <20190212153025.25425-1-cohuck@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/kvm.c        | 2 ++
 target/s390x/trace-events | 1 +
 2 files changed, 3 insertions(+)

diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 15fdc168e1c5..19530fb94e5a 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -1886,6 +1886,8 @@ int kvm_s390_assign_subch_ioeventfd(EventNotifier *notifier, uint32_t sch,
         .addr = sch,
         .len = 8,
     };
+    trace_kvm_assign_subch_ioeventfd(kick.fd, kick.addr, assign,
+                                     kick.datamatch);
     if (!kvm_check_extension(kvm_state, KVM_CAP_IOEVENTFD)) {
         return -ENOSYS;
     }
diff --git a/target/s390x/trace-events b/target/s390x/trace-events
index a84e316e4937..e509b08799c6 100644
--- a/target/s390x/trace-events
+++ b/target/s390x/trace-events
@@ -14,6 +14,7 @@ ioinst_chsc_cmd(uint16_t cmd, uint16_t len) "IOINST: chsc command 0x%04x, len 0x
 kvm_enable_cmma(int rc) "CMMA: enabling with result code %d"
 kvm_clear_cmma(int rc) "CMMA: clearing with result code %d"
 kvm_failed_cpu_state_set(int cpu_index, uint8_t state, const char *msg) "Warning: Unable to set cpu %d state %" PRIu8 " to KVM: %s"
+kvm_assign_subch_ioeventfd(int fd, uint32_t addr, bool assign, int datamatch) "fd: %d sch: @0x%x assign: %d vq: %d"
 
 # target/s390x/cpu.c
 cpu_set_state(int cpu_index, uint8_t state) "setting cpu %d state to %" PRIu8
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PULL 10/10] s390x: upgrade status of KVM cores to "supported"
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (8 preceding siblings ...)
  2019-02-18 11:11 ` [Qemu-devel] [PULL 09/10] s390x/kvm: add tracepoint to ioeventfd interface Cornelia Huck
@ 2019-02-18 11:11 ` Cornelia Huck
  2019-02-18 11:44 ` [Qemu-devel] [PULL 00/10] s390x update no-reply
                   ` (9 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: Cornelia Huck @ 2019-02-18 11:11 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, qemu-devel, Cornelia Huck

We are actually paid to look after this.

Message-Id: <20190213103519.32585-1-cohuck@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ffb029f63ac0..b1d786cfd87a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -375,7 +375,7 @@ S390
 M: Halil Pasic <pasic@linux.ibm.com>
 M: Cornelia Huck <cohuck@redhat.com>
 M: Christian Borntraeger <borntraeger@de.ibm.com>
-S: Maintained
+S: Supported
 F: target/s390x/kvm.c
 F: target/s390x/kvm_s390x.h
 F: target/s390x/kvm-stub.c
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (9 preceding siblings ...)
  2019-02-18 11:11 ` [Qemu-devel] [PULL 10/10] s390x: upgrade status of KVM cores to "supported" Cornelia Huck
@ 2019-02-18 11:44 ` no-reply
  2019-02-18 11:48 ` no-reply
                   ` (8 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: no-reply @ 2019-02-18 11:44 UTC (permalink / raw)
  To: cohuck; +Cc: fam, peter.maydell, qemu-s390x, qemu-devel

Patchew URL: https://patchew.org/QEMU/20190218111153.22681-1-cohuck@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190218111153.22681-1-cohuck@redhat.com
Subject: [Qemu-devel] [PULL 00/10] s390x update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190218111153.22681-1-cohuck@redhat.com -> patchew/20190218111153.22681-1-cohuck@redhat.com
Switched to a new branch 'test'
470cfcc0f2 s390x: upgrade status of KVM cores to "supported"
e948bc58e2 s390x/kvm: add tracepoint to ioeventfd interface
5938727dc8 s390x/cpumodel: add z14 GA2 model
93952af6c4 s390x/cpumodel: default enable mepoch for z14 and later
4a088c7b33 s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
b3c4e2b49f s390x: add zPCI feature to "qemu" CPU model
685a7329be target/s390x: Implement STCK et al for CONFIG_USER_ONLY
66aa7432df target/s390x: Split out s390-tod.h
e1a84113c9 s390x: always provide pci support
49da899c24 s390x: Fix the confusing contributions-after-2012 license statements

=== OUTPUT BEGIN ===
1/10 Checking commit 49da899c2447 (s390x: Fix the confusing contributions-after-2012 license statements)
2/10 Checking commit e1a84113c9eb (s390x: always provide pci support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
deleted file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit 66aa7432dfeb (target/s390x: Split out s390-tod.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit 685a7329beab (target/s390x: Implement STCK et al for CONFIG_USER_ONLY)
5/10 Checking commit b3c4e2b49f9d (s390x: add zPCI feature to "qemu" CPU model)
6/10 Checking commit 4a088c7b337a (s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init)
ERROR: line over 90 characters
#38: FILE: target/s390x/cpu_features.c:468:
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

total: 1 errors, 0 warnings, 24 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit 93952af6c457 (s390x/cpumodel: default enable mepoch for z14 and later)
WARNING: line over 80 characters
#31: FILE: hw/s390x/s390-virtio-ccw.c:663:
+    s390_cpudef_group_featoff_greater(14, 1, S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF);

total: 0 errors, 1 warnings, 55 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit 5938727dc867 (s390x/cpumodel: add z14 GA2 model)
9/10 Checking commit e948bc58e22f (s390x/kvm: add tracepoint to ioeventfd interface)
10/10 Checking commit 470cfcc0f248 (s390x: upgrade status of KVM cores to "supported")
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20190218111153.22681-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (10 preceding siblings ...)
  2019-02-18 11:44 ` [Qemu-devel] [PULL 00/10] s390x update no-reply
@ 2019-02-18 11:48 ` no-reply
  2019-02-18 12:19 ` no-reply
                   ` (7 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: no-reply @ 2019-02-18 11:48 UTC (permalink / raw)
  To: cohuck; +Cc: fam, peter.maydell, qemu-s390x, qemu-devel

Patchew URL: https://patchew.org/QEMU/20190218111153.22681-1-cohuck@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190218111153.22681-1-cohuck@redhat.com
Subject: [Qemu-devel] [PULL 00/10] s390x update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20190218111153.22681-1-cohuck@redhat.com -> patchew/20190218111153.22681-1-cohuck@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
470cfcc s390x: upgrade status of KVM cores to "supported"
e948bc5 s390x/kvm: add tracepoint to ioeventfd interface
5938727 s390x/cpumodel: add z14 GA2 model
93952af s390x/cpumodel: default enable mepoch for z14 and later
4a088c7 s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
b3c4e2b s390x: add zPCI feature to "qemu" CPU model
685a732 target/s390x: Implement STCK et al for CONFIG_USER_ONLY
66aa743 target/s390x: Split out s390-tod.h
e1a8411 s390x: always provide pci support
49da899 s390x: Fix the confusing contributions-after-2012 license statements

=== OUTPUT BEGIN ===
1/10 Checking commit 49da899c2447 (s390x: Fix the confusing contributions-after-2012 license statements)
2/10 Checking commit e1a84113c9eb (s390x: always provide pci support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
deleted file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit 66aa7432dfeb (target/s390x: Split out s390-tod.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit 685a7329beab (target/s390x: Implement STCK et al for CONFIG_USER_ONLY)
5/10 Checking commit b3c4e2b49f9d (s390x: add zPCI feature to "qemu" CPU model)
6/10 Checking commit 4a088c7b337a (s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init)
ERROR: line over 90 characters
#38: FILE: target/s390x/cpu_features.c:468:
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

total: 1 errors, 0 warnings, 24 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit 93952af6c457 (s390x/cpumodel: default enable mepoch for z14 and later)
WARNING: line over 80 characters
#31: FILE: hw/s390x/s390-virtio-ccw.c:663:
+    s390_cpudef_group_featoff_greater(14, 1, S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF);

total: 0 errors, 1 warnings, 55 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit 5938727dc867 (s390x/cpumodel: add z14 GA2 model)
9/10 Checking commit e948bc58e22f (s390x/kvm: add tracepoint to ioeventfd interface)
10/10 Checking commit 470cfcc0f248 (s390x: upgrade status of KVM cores to "supported")
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20190218111153.22681-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (11 preceding siblings ...)
  2019-02-18 11:48 ` no-reply
@ 2019-02-18 12:19 ` no-reply
  2019-02-18 12:22 ` no-reply
                   ` (6 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: no-reply @ 2019-02-18 12:19 UTC (permalink / raw)
  To: cohuck; +Cc: fam, peter.maydell, qemu-s390x, qemu-devel

Patchew URL: https://patchew.org/QEMU/20190218111153.22681-1-cohuck@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190218111153.22681-1-cohuck@redhat.com
Subject: [Qemu-devel] [PULL 00/10] s390x update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190218111153.22681-1-cohuck@redhat.com -> patchew/20190218111153.22681-1-cohuck@redhat.com
Switched to a new branch 'test'
328f0fc409 s390x: upgrade status of KVM cores to "supported"
0293a19739 s390x/kvm: add tracepoint to ioeventfd interface
d136881dc5 s390x/cpumodel: add z14 GA2 model
831f68c1a4 s390x/cpumodel: default enable mepoch for z14 and later
26ec674c51 s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
79961d3fa5 s390x: add zPCI feature to "qemu" CPU model
927924fc86 target/s390x: Implement STCK et al for CONFIG_USER_ONLY
83b7f84260 target/s390x: Split out s390-tod.h
519a21ca8b s390x: always provide pci support
8d27e0d635 s390x: Fix the confusing contributions-after-2012 license statements

=== OUTPUT BEGIN ===
1/10 Checking commit 8d27e0d6358b (s390x: Fix the confusing contributions-after-2012 license statements)
2/10 Checking commit 519a21ca8b39 (s390x: always provide pci support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
deleted file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit 83b7f84260c6 (target/s390x: Split out s390-tod.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit 927924fc86a0 (target/s390x: Implement STCK et al for CONFIG_USER_ONLY)
5/10 Checking commit 79961d3fa5eb (s390x: add zPCI feature to "qemu" CPU model)
6/10 Checking commit 26ec674c51a1 (s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init)
ERROR: line over 90 characters
#38: FILE: target/s390x/cpu_features.c:468:
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

total: 1 errors, 0 warnings, 24 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit 831f68c1a4ad (s390x/cpumodel: default enable mepoch for z14 and later)
WARNING: line over 80 characters
#31: FILE: hw/s390x/s390-virtio-ccw.c:663:
+    s390_cpudef_group_featoff_greater(14, 1, S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF);

total: 0 errors, 1 warnings, 55 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit d136881dc583 (s390x/cpumodel: add z14 GA2 model)
9/10 Checking commit 0293a197399f (s390x/kvm: add tracepoint to ioeventfd interface)
10/10 Checking commit 328f0fc409b5 (s390x: upgrade status of KVM cores to "supported")
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20190218111153.22681-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (12 preceding siblings ...)
  2019-02-18 12:19 ` no-reply
@ 2019-02-18 12:22 ` no-reply
  2019-02-18 12:55 ` no-reply
                   ` (5 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: no-reply @ 2019-02-18 12:22 UTC (permalink / raw)
  To: cohuck; +Cc: fam, peter.maydell, qemu-s390x, qemu-devel

Patchew URL: https://patchew.org/QEMU/20190218111153.22681-1-cohuck@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190218111153.22681-1-cohuck@redhat.com
Subject: [Qemu-devel] [PULL 00/10] s390x update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20190218111153.22681-1-cohuck@redhat.com -> patchew/20190218111153.22681-1-cohuck@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
328f0fc s390x: upgrade status of KVM cores to "supported"
0293a19 s390x/kvm: add tracepoint to ioeventfd interface
d136881 s390x/cpumodel: add z14 GA2 model
831f68c s390x/cpumodel: default enable mepoch for z14 and later
26ec674 s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
79961d3 s390x: add zPCI feature to "qemu" CPU model
927924f target/s390x: Implement STCK et al for CONFIG_USER_ONLY
83b7f84 target/s390x: Split out s390-tod.h
519a21c s390x: always provide pci support
8d27e0d s390x: Fix the confusing contributions-after-2012 license statements

=== OUTPUT BEGIN ===
1/10 Checking commit 8d27e0d6358b (s390x: Fix the confusing contributions-after-2012 license statements)
2/10 Checking commit 519a21ca8b39 (s390x: always provide pci support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
deleted file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit 83b7f84260c6 (target/s390x: Split out s390-tod.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit 927924fc86a0 (target/s390x: Implement STCK et al for CONFIG_USER_ONLY)
5/10 Checking commit 79961d3fa5eb (s390x: add zPCI feature to "qemu" CPU model)
6/10 Checking commit 26ec674c51a1 (s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init)
ERROR: line over 90 characters
#38: FILE: target/s390x/cpu_features.c:468:
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

total: 1 errors, 0 warnings, 24 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit 831f68c1a4ad (s390x/cpumodel: default enable mepoch for z14 and later)
WARNING: line over 80 characters
#31: FILE: hw/s390x/s390-virtio-ccw.c:663:
+    s390_cpudef_group_featoff_greater(14, 1, S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF);

total: 0 errors, 1 warnings, 55 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit d136881dc583 (s390x/cpumodel: add z14 GA2 model)
9/10 Checking commit 0293a197399f (s390x/kvm: add tracepoint to ioeventfd interface)
10/10 Checking commit 328f0fc409b5 (s390x: upgrade status of KVM cores to "supported")
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190218111153.22681-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (13 preceding siblings ...)
  2019-02-18 12:22 ` no-reply
@ 2019-02-18 12:55 ` no-reply
  2019-02-18 12:59 ` no-reply
                   ` (4 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: no-reply @ 2019-02-18 12:55 UTC (permalink / raw)
  To: cohuck; +Cc: fam, peter.maydell, qemu-s390x, qemu-devel

Patchew URL: https://patchew.org/QEMU/20190218111153.22681-1-cohuck@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190218111153.22681-1-cohuck@redhat.com
Subject: [Qemu-devel] [PULL 00/10] s390x update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190218111153.22681-1-cohuck@redhat.com -> patchew/20190218111153.22681-1-cohuck@redhat.com
Switched to a new branch 'test'
ad18a1e8f9 s390x: upgrade status of KVM cores to "supported"
f51dcb1de7 s390x/kvm: add tracepoint to ioeventfd interface
44a5efda3d s390x/cpumodel: add z14 GA2 model
73f9841ebe s390x/cpumodel: default enable mepoch for z14 and later
e3de398038 s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
b5675c4afd s390x: add zPCI feature to "qemu" CPU model
998aa975c5 target/s390x: Implement STCK et al for CONFIG_USER_ONLY
f408f4d152 target/s390x: Split out s390-tod.h
02e8bbca30 s390x: always provide pci support
321d3bfebc s390x: Fix the confusing contributions-after-2012 license statements

=== OUTPUT BEGIN ===
1/10 Checking commit 321d3bfebc46 (s390x: Fix the confusing contributions-after-2012 license statements)
2/10 Checking commit 02e8bbca30b5 (s390x: always provide pci support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
deleted file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit f408f4d152b3 (target/s390x: Split out s390-tod.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit 998aa975c5f9 (target/s390x: Implement STCK et al for CONFIG_USER_ONLY)
5/10 Checking commit b5675c4afda7 (s390x: add zPCI feature to "qemu" CPU model)
6/10 Checking commit e3de398038bd (s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init)
ERROR: line over 90 characters
#38: FILE: target/s390x/cpu_features.c:468:
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

total: 1 errors, 0 warnings, 24 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit 73f9841ebe92 (s390x/cpumodel: default enable mepoch for z14 and later)
WARNING: line over 80 characters
#31: FILE: hw/s390x/s390-virtio-ccw.c:663:
+    s390_cpudef_group_featoff_greater(14, 1, S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF);

total: 0 errors, 1 warnings, 55 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit 44a5efda3dcf (s390x/cpumodel: add z14 GA2 model)
9/10 Checking commit f51dcb1de7ce (s390x/kvm: add tracepoint to ioeventfd interface)
10/10 Checking commit ad18a1e8f908 (s390x: upgrade status of KVM cores to "supported")
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20190218111153.22681-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (14 preceding siblings ...)
  2019-02-18 12:55 ` no-reply
@ 2019-02-18 12:59 ` no-reply
  2019-02-18 13:31 ` no-reply
                   ` (3 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: no-reply @ 2019-02-18 12:59 UTC (permalink / raw)
  To: cohuck; +Cc: fam, peter.maydell, qemu-s390x, qemu-devel

Patchew URL: https://patchew.org/QEMU/20190218111153.22681-1-cohuck@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190218111153.22681-1-cohuck@redhat.com
Subject: [Qemu-devel] [PULL 00/10] s390x update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20190218111153.22681-1-cohuck@redhat.com -> patchew/20190218111153.22681-1-cohuck@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
ad18a1e s390x: upgrade status of KVM cores to "supported"
f51dcb1 s390x/kvm: add tracepoint to ioeventfd interface
44a5efd s390x/cpumodel: add z14 GA2 model
73f9841 s390x/cpumodel: default enable mepoch for z14 and later
e3de398 s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
b5675c4 s390x: add zPCI feature to "qemu" CPU model
998aa97 target/s390x: Implement STCK et al for CONFIG_USER_ONLY
f408f4d target/s390x: Split out s390-tod.h
02e8bbc s390x: always provide pci support
321d3bf s390x: Fix the confusing contributions-after-2012 license statements

=== OUTPUT BEGIN ===
1/10 Checking commit 321d3bfebc46 (s390x: Fix the confusing contributions-after-2012 license statements)
2/10 Checking commit 02e8bbca30b5 (s390x: always provide pci support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
deleted file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit f408f4d152b3 (target/s390x: Split out s390-tod.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit 998aa975c5f9 (target/s390x: Implement STCK et al for CONFIG_USER_ONLY)
5/10 Checking commit b5675c4afda7 (s390x: add zPCI feature to "qemu" CPU model)
6/10 Checking commit e3de398038bd (s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init)
ERROR: line over 90 characters
#38: FILE: target/s390x/cpu_features.c:468:
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

total: 1 errors, 0 warnings, 24 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit 73f9841ebe92 (s390x/cpumodel: default enable mepoch for z14 and later)
WARNING: line over 80 characters
#31: FILE: hw/s390x/s390-virtio-ccw.c:663:
+    s390_cpudef_group_featoff_greater(14, 1, S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF);

total: 0 errors, 1 warnings, 55 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit 44a5efda3dcf (s390x/cpumodel: add z14 GA2 model)
9/10 Checking commit f51dcb1de7ce (s390x/kvm: add tracepoint to ioeventfd interface)
10/10 Checking commit ad18a1e8f908 (s390x: upgrade status of KVM cores to "supported")
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190218111153.22681-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (15 preceding siblings ...)
  2019-02-18 12:59 ` no-reply
@ 2019-02-18 13:31 ` no-reply
  2019-02-18 14:07 ` no-reply
                   ` (2 subsequent siblings)
  19 siblings, 0 replies; 23+ messages in thread
From: no-reply @ 2019-02-18 13:31 UTC (permalink / raw)
  To: cohuck; +Cc: fam, peter.maydell, qemu-s390x, qemu-devel

Patchew URL: https://patchew.org/QEMU/20190218111153.22681-1-cohuck@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190218111153.22681-1-cohuck@redhat.com
Subject: [Qemu-devel] [PULL 00/10] s390x update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190218101218.4177-1-ppandit@redhat.com -> patchew/20190218101218.4177-1-ppandit@redhat.com
 t [tag update]            patchew/20190218111153.22681-1-cohuck@redhat.com -> patchew/20190218111153.22681-1-cohuck@redhat.com
 * [new tag]               patchew/20190218125615.18970-1-armbru@redhat.com -> patchew/20190218125615.18970-1-armbru@redhat.com
Switched to a new branch 'test'
de6ad1a8c2 s390x: upgrade status of KVM cores to "supported"
5f9a5da1e2 s390x/kvm: add tracepoint to ioeventfd interface
5209f76bb2 s390x/cpumodel: add z14 GA2 model
c96171aaa2 s390x/cpumodel: default enable mepoch for z14 and later
699fb0f989 s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
d373f8891a s390x: add zPCI feature to "qemu" CPU model
3f3663d5be target/s390x: Implement STCK et al for CONFIG_USER_ONLY
8f9cead3d6 target/s390x: Split out s390-tod.h
f66f5eca0e s390x: always provide pci support
4788053181 s390x: Fix the confusing contributions-after-2012 license statements

=== OUTPUT BEGIN ===
1/10 Checking commit 4788053181e3 (s390x: Fix the confusing contributions-after-2012 license statements)
2/10 Checking commit f66f5eca0ee2 (s390x: always provide pci support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
deleted file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit 8f9cead3d64b (target/s390x: Split out s390-tod.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit 3f3663d5be00 (target/s390x: Implement STCK et al for CONFIG_USER_ONLY)
5/10 Checking commit d373f8891a69 (s390x: add zPCI feature to "qemu" CPU model)
6/10 Checking commit 699fb0f98995 (s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init)
ERROR: line over 90 characters
#38: FILE: target/s390x/cpu_features.c:468:
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

total: 1 errors, 0 warnings, 24 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit c96171aaa24b (s390x/cpumodel: default enable mepoch for z14 and later)
WARNING: line over 80 characters
#31: FILE: hw/s390x/s390-virtio-ccw.c:663:
+    s390_cpudef_group_featoff_greater(14, 1, S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF);

total: 0 errors, 1 warnings, 55 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit 5209f76bb237 (s390x/cpumodel: add z14 GA2 model)
9/10 Checking commit 5f9a5da1e227 (s390x/kvm: add tracepoint to ioeventfd interface)
10/10 Checking commit de6ad1a8c2ef (s390x: upgrade status of KVM cores to "supported")
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20190218111153.22681-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (16 preceding siblings ...)
  2019-02-18 13:31 ` no-reply
@ 2019-02-18 14:07 ` no-reply
  2019-02-18 14:09 ` Peter Maydell
  2019-02-18 14:11 ` no-reply
  19 siblings, 0 replies; 23+ messages in thread
From: no-reply @ 2019-02-18 14:07 UTC (permalink / raw)
  To: cohuck; +Cc: fam, peter.maydell, qemu-s390x, qemu-devel

Patchew URL: https://patchew.org/QEMU/20190218111153.22681-1-cohuck@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190218111153.22681-1-cohuck@redhat.com
Subject: [Qemu-devel] [PULL 00/10] s390x update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190218111153.22681-1-cohuck@redhat.com -> patchew/20190218111153.22681-1-cohuck@redhat.com
Switched to a new branch 'test'
30bd10a753 s390x: upgrade status of KVM cores to "supported"
d0c8053e37 s390x/kvm: add tracepoint to ioeventfd interface
58912e7c70 s390x/cpumodel: add z14 GA2 model
f0a763165c s390x/cpumodel: default enable mepoch for z14 and later
b57cf83254 s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
4036f9a67e s390x: add zPCI feature to "qemu" CPU model
625c89c556 target/s390x: Implement STCK et al for CONFIG_USER_ONLY
2a49e616b7 target/s390x: Split out s390-tod.h
1eaa7f0eda s390x: always provide pci support
602fe9bdb0 s390x: Fix the confusing contributions-after-2012 license statements

=== OUTPUT BEGIN ===
1/10 Checking commit 602fe9bdb008 (s390x: Fix the confusing contributions-after-2012 license statements)
2/10 Checking commit 1eaa7f0eda15 (s390x: always provide pci support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
deleted file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit 2a49e616b722 (target/s390x: Split out s390-tod.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit 625c89c556d5 (target/s390x: Implement STCK et al for CONFIG_USER_ONLY)
5/10 Checking commit 4036f9a67eee (s390x: add zPCI feature to "qemu" CPU model)
6/10 Checking commit b57cf832547f (s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init)
ERROR: line over 90 characters
#38: FILE: target/s390x/cpu_features.c:468:
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

total: 1 errors, 0 warnings, 24 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit f0a763165c94 (s390x/cpumodel: default enable mepoch for z14 and later)
WARNING: line over 80 characters
#31: FILE: hw/s390x/s390-virtio-ccw.c:663:
+    s390_cpudef_group_featoff_greater(14, 1, S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF);

total: 0 errors, 1 warnings, 55 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit 58912e7c7085 (s390x/cpumodel: add z14 GA2 model)
9/10 Checking commit d0c8053e3756 (s390x/kvm: add tracepoint to ioeventfd interface)
10/10 Checking commit 30bd10a75380 (s390x: upgrade status of KVM cores to "supported")
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20190218111153.22681-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (17 preceding siblings ...)
  2019-02-18 14:07 ` no-reply
@ 2019-02-18 14:09 ` Peter Maydell
  2019-02-18 14:11 ` no-reply
  19 siblings, 0 replies; 23+ messages in thread
From: Peter Maydell @ 2019-02-18 14:09 UTC (permalink / raw)
  To: Cornelia Huck; +Cc: qemu-s390x, QEMU Developers

On Mon, 18 Feb 2019 at 11:11, Cornelia Huck <cohuck@redhat.com> wrote:
>
> The following changes since commit 1e36232994c8ad01774501d2e299deba3a2469af:
>
>   Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20190215' into staging (2019-02-15 11:12:14 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/cohuck/qemu tags/s390x-20190218
>
> for you to fetch changes up to 0922e8c093a564219fcb7f43b18ceb12714dd931:
>
>   s390x: upgrade status of KVM cores to "supported" (2019-02-18 12:00:44 +0100)
>
> ----------------------------------------------------------------
> s390x updates:
> - tcg: implement STCK and friends for CONFIG_USER_ONLY
> - add zpci to qemu cpu model, as pci is now always built
> - add mepoch to default z14 cpu model
> - add cpu model for z14 GA2
> - various improvements
>

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PULL 00/10] s390x update
  2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
                   ` (18 preceding siblings ...)
  2019-02-18 14:09 ` Peter Maydell
@ 2019-02-18 14:11 ` no-reply
  19 siblings, 0 replies; 23+ messages in thread
From: no-reply @ 2019-02-18 14:11 UTC (permalink / raw)
  To: cohuck; +Cc: fam, peter.maydell, qemu-s390x, qemu-devel

Patchew URL: https://patchew.org/QEMU/20190218111153.22681-1-cohuck@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190218111153.22681-1-cohuck@redhat.com
Subject: [Qemu-devel] [PULL 00/10] s390x update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20190218111153.22681-1-cohuck@redhat.com -> patchew/20190218111153.22681-1-cohuck@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
30bd10a s390x: upgrade status of KVM cores to "supported"
d0c8053 s390x/kvm: add tracepoint to ioeventfd interface
58912e7 s390x/cpumodel: add z14 GA2 model
f0a7631 s390x/cpumodel: default enable mepoch for z14 and later
b57cf83 s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
4036f9a s390x: add zPCI feature to "qemu" CPU model
625c89c target/s390x: Implement STCK et al for CONFIG_USER_ONLY
2a49e61 target/s390x: Split out s390-tod.h
1eaa7f0 s390x: always provide pci support
602fe9b s390x: Fix the confusing contributions-after-2012 license statements

=== OUTPUT BEGIN ===
1/10 Checking commit 602fe9bdb008 (s390x: Fix the confusing contributions-after-2012 license statements)
2/10 Checking commit 1eaa7f0eda15 (s390x: always provide pci support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
deleted file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit 2a49e616b722 (target/s390x: Split out s390-tod.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit 625c89c556d5 (target/s390x: Implement STCK et al for CONFIG_USER_ONLY)
5/10 Checking commit 4036f9a67eee (s390x: add zPCI feature to "qemu" CPU model)
6/10 Checking commit b57cf832547f (s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init)
ERROR: line over 90 characters
#38: FILE: target/s390x/cpu_features.c:468:
+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

total: 1 errors, 0 warnings, 24 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit f0a763165c94 (s390x/cpumodel: default enable mepoch for z14 and later)
WARNING: line over 80 characters
#31: FILE: hw/s390x/s390-virtio-ccw.c:663:
+    s390_cpudef_group_featoff_greater(14, 1, S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF);

total: 0 errors, 1 warnings, 55 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit 58912e7c7085 (s390x/cpumodel: add z14 GA2 model)
9/10 Checking commit d0c8053e3756 (s390x/kvm: add tracepoint to ioeventfd interface)
10/10 Checking commit 30bd10a75380 (s390x: upgrade status of KVM cores to "supported")
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190218111153.22681-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2019-02-18 14:12 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-18 11:11 [Qemu-devel] [PULL 00/10] s390x update Cornelia Huck
2019-02-18 11:11 ` [Qemu-devel] [PULL 01/10] s390x: Fix the confusing contributions-after-2012 license statements Cornelia Huck
2019-02-18 11:11 ` [Qemu-devel] [PULL 02/10] s390x: always provide pci support Cornelia Huck
2019-02-18 11:11 ` [Qemu-devel] [PULL 03/10] target/s390x: Split out s390-tod.h Cornelia Huck
2019-02-18 11:11 ` [Qemu-devel] [PULL 04/10] target/s390x: Implement STCK et al for CONFIG_USER_ONLY Cornelia Huck
2019-02-18 11:11 ` [Qemu-devel] [PULL 05/10] s390x: add zPCI feature to "qemu" CPU model Cornelia Huck
2019-02-18 11:11 ` [Qemu-devel] [PULL 06/10] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init Cornelia Huck
2019-02-18 11:11 ` [Qemu-devel] [PULL 07/10] s390x/cpumodel: default enable mepoch for z14 and later Cornelia Huck
2019-02-18 11:11 ` [Qemu-devel] [PULL 08/10] s390x/cpumodel: add z14 GA2 model Cornelia Huck
2019-02-18 11:11 ` [Qemu-devel] [PULL 09/10] s390x/kvm: add tracepoint to ioeventfd interface Cornelia Huck
2019-02-18 11:11 ` [Qemu-devel] [PULL 10/10] s390x: upgrade status of KVM cores to "supported" Cornelia Huck
2019-02-18 11:44 ` [Qemu-devel] [PULL 00/10] s390x update no-reply
2019-02-18 11:48 ` no-reply
2019-02-18 12:19 ` no-reply
2019-02-18 12:22 ` no-reply
2019-02-18 12:55 ` no-reply
2019-02-18 12:59 ` no-reply
2019-02-18 13:31 ` no-reply
2019-02-18 14:07 ` no-reply
2019-02-18 14:09 ` Peter Maydell
2019-02-18 14:11 ` no-reply
  -- strict thread matches above, loose matches on Subject: below --
2019-02-05 16:40 Cornelia Huck
2019-02-05 18:21 ` Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).