From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: dgilbert@redhat.com, quintela@redhat.com, jsnow@redhat.com,
den@openvz.org, fam@euphon.net, stefanha@redhat.com,
mreitz@redhat.com, kwolf@redhat.com, vsementsov@virtuozzo.com
Subject: [Qemu-devel] [PATCH v4 04/17] block/backup: use qemu_iovec_init_buf
Date: Mon, 18 Feb 2019 17:09:13 +0300 [thread overview]
Message-ID: <20190218140926.333779-5-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20190218140926.333779-1-vsementsov@virtuozzo.com>
Use new qemu_iovec_init_buf() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/backup.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index 435414e964..9988753249 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -107,7 +107,6 @@ static int coroutine_fn backup_cow_with_bounce_buffer(BackupBlockJob *job,
void **bounce_buffer)
{
int ret;
- struct iovec iov;
QEMUIOVector qiov;
BlockBackend *blk = job->common.blk;
int nbytes;
@@ -119,9 +118,7 @@ static int coroutine_fn backup_cow_with_bounce_buffer(BackupBlockJob *job,
if (!*bounce_buffer) {
*bounce_buffer = blk_blockalign(blk, job->cluster_size);
}
- iov.iov_base = *bounce_buffer;
- iov.iov_len = nbytes;
- qemu_iovec_init_external(&qiov, &iov, 1);
+ qemu_iovec_init_buf(&qiov, *bounce_buffer, nbytes);
ret = blk_co_preadv(blk, start, qiov.size, &qiov, read_flags);
if (ret < 0) {
--
2.18.0
next prev parent reply other threads:[~2019-02-18 14:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 14:09 [Qemu-devel] [PATCH v4 00/17] block: local qiov helper Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 01/17] block: enhance QEMUIOVector structure Vladimir Sementsov-Ogievskiy
2019-02-18 20:19 ` Eric Blake
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 02/17] block/io: use qemu_iovec_init_buf Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 03/17] block/block-backend: use QEMU_IOVEC_INIT_BUF Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` Vladimir Sementsov-Ogievskiy [this message]
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 05/17] block/commit: " Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 06/17] block/stream: " Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 07/17] block/parallels: " Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 08/17] block/qcow: use qemu_iovec_init_buf Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 09/17] block/qcow2: " Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 10/17] block/qed: " Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 11/17] block/vmdk: " Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 12/17] qemu-img: " Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 13/17] migration/block: " Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 14/17] tests/test-bdrv-drain: use QEMU_IOVEC_INIT_BUF Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 15/17] hw/ide: drop iov field from IDEState Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 16/17] hw/ide: drop iov field from IDEBufferedRequest Vladimir Sementsov-Ogievskiy
2019-02-18 14:09 ` [Qemu-devel] [PATCH v4 17/17] hw/ide: drop iov field from IDEDMA Vladimir Sementsov-Ogievskiy
2019-02-20 16:42 ` [Qemu-devel] [PATCH v4 00/17] block: local qiov helper Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218140926.333779-5-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).