From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:37770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvjtl-0002og-PA for qemu-devel@nongnu.org; Mon, 18 Feb 2019 09:27:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvjtc-0000qi-6j for qemu-devel@nongnu.org; Mon, 18 Feb 2019 09:27:52 -0500 Date: Mon, 18 Feb 2019 14:27:31 +0000 From: Anthony PERARD Message-ID: <20190218142731.GA1349@perard.uk.xensource.com> References: <20190215162533.19475-1-paul.durrant@citrix.com> <20190215162533.19475-2-paul.durrant@citrix.com> <9c6c6f2e-cac0-9e75-d5e2-baf613aad6b7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9c6c6f2e-cac0-9e75-d5e2-baf613aad6b7@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/3] dataplane/xen-block: remove dead code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: Paul Durrant , qemu-devel@nongnu.org, qemu-block@nongnu.org, xen-devel@lists.xenproject.org, Kevin Wolf , Peter Maydell , Stefano Stabellini , Max Reitz , Stefan Hajnoczi On Fri, Feb 15, 2019 at 09:38:59PM +0100, Philippe Mathieu-Daudé wrote: > On 2/15/19 5:25 PM, Paul Durrant wrote: > > The if() statement is clearly bogus (dead code which should have been > > cleaned up when grant mapping was removed). > > "... was removed in 06454c24ad)." Actually, it looks like c6025bd197 should have remove the if statement. > > > > Spotted by Coverity: CID 1398635 > > > > While in the neighbourhood, add a missing 'fall through' annotation. > > > > Reported-by: Peter Maydell > > Signed-off-by: Paul Durrant Acked-by: Anthony PERARD Thanks, -- Anthony PERARD