From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:37314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvuHI-0007JF-4o for qemu-devel@nongnu.org; Mon, 18 Feb 2019 20:32:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvuHG-0002XV-QE for qemu-devel@nongnu.org; Mon, 18 Feb 2019 20:32:56 -0500 From: Wei Yang Date: Tue, 19 Feb 2019 09:31:06 +0800 Message-Id: <20190219013106.17538-3-richardw.yang@linux.intel.com> In-Reply-To: <20190219013106.17538-1-richardw.yang@linux.intel.com> References: <20190219013106.17538-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 2/2] CODING_STYLE: indent example code as all others List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Cc: mjt@tls.msk.ru, imammedo@redhat.com, Wei Yang All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang --- CODING_STYLE | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 73f66ca185..27581d80c1 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -134,10 +134,10 @@ block to a separate function altogether. When comparing a variable for (in)equality with a constant, list the constant on the right, as in: -if (a == 1) { - /* Reads like: "If a equals 1" */ - do_something(); -} + if (a == 1) { + /* Reads like: "If a equals 1" */ + do_something(); + } Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. Besides, good compilers already warn users when '==' is mis-typed as '=', -- 2.19.1