From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvyZd-0002iU-9K for qemu-devel@nongnu.org; Tue, 19 Feb 2019 01:08:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvyZc-0006DG-KE for qemu-devel@nongnu.org; Tue, 19 Feb 2019 01:08:09 -0500 Received: from mga09.intel.com ([134.134.136.24]:62698) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gvyZc-0006Co-CX for qemu-devel@nongnu.org; Tue, 19 Feb 2019 01:08:08 -0500 From: Wei Yang Date: Tue, 19 Feb 2019 14:07:18 +0800 Message-Id: <20190219060719.8211-2-richardw.yang@linux.intel.com> In-Reply-To: <20190219060719.8211-1-richardw.yang@linux.intel.com> References: <20190219060719.8211-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 1/2] pc-dimm: remove check on pc-dimm hotpluggable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com, imammedo@redhat.com, xiaoguangrong.eric@gmail.com, Wei Yang Function acpi_memory_plug_cb() is only invoked when dev is a PCDIMM, which is hotpluggable. This means it is not necessary to check this property again. This patch removes this check. Signed-off-by: Wei Yang --- hw/acpi/memory_hotplug.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c index 8c7c1013f3..b19673d337 100644 --- a/hw/acpi/memory_hotplug.c +++ b/hw/acpi/memory_hotplug.c @@ -266,10 +266,6 @@ void acpi_memory_plug_cb(HotplugHandler *hotplug_dev, MemHotplugState *mem_st, MemStatus *mdev; DeviceClass *dc = DEVICE_GET_CLASS(dev); - if (!dc->hotpluggable) { - return; - } - mdev = acpi_memory_slot_status(mem_st, dev, errp); if (!mdev) { return; -- 2.19.1