From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gw3iZ-0000YF-I0 for qemu-devel@nongnu.org; Tue, 19 Feb 2019 06:37:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gw3iS-0007Ea-D0 for qemu-devel@nongnu.org; Tue, 19 Feb 2019 06:37:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44476) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gw3hx-00077o-6b for qemu-devel@nongnu.org; Tue, 19 Feb 2019 06:37:36 -0500 Date: Tue, 19 Feb 2019 19:34:00 +0800 From: Wei Xu Message-ID: <20190219113400.GA11257@wei-ubt> References: <1550118402-4057-1-git-send-email-wexu@redhat.com> <1550118402-4057-8-git-send-email-wexu@redhat.com> <7d71fb88-2651-41eb-023e-63a11a83cd38@redhat.com> <20190218144640.GA28793@wei-ubt> <71fd17b4-9509-3f13-556d-fc4c3e617e84@redhat.com> <20190219082101.GA15343@wei-ubt> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 07/11] virtio: fill/flush/pop for packed ring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: jfreiman@redhat.com, maxime.coquelin@redhat.com, qemu-devel@nongnu.org, tiwei.bie@intel.com, mst@redhat.com On Tue, Feb 19, 2019 at 05:33:57PM +0800, Jason Wang wrote: >=20 > On 2019/2/19 =E4=B8=8B=E5=8D=884:21, Wei Xu wrote: > >On Tue, Feb 19, 2019 at 02:49:42PM +0800, Jason Wang wrote: > >>On 2019/2/18 =E4=B8=8B=E5=8D=8810:46, Wei Xu wrote: > >>>>Do we allow chain more descriptors than vq size in the case of indi= rect? > >>>>According to the spec: > >>>> > >>>>" > >>>> > >>>>The device limits the number of descriptors in a list through a > >>>>transport-specific and/or device-specific value. If not limited, > >>>>the maximum number of descriptors in a list is the virt queue > >>>>size. > >>>>" > >>>> > >>>>This looks possible, so the above is probably wrong if the max numb= er of > >>>>chained descriptors is negotiated through a device specific way. > >>>> > >>>OK, I will remove this check, while it is necessary to have a limita= tion > >>>for indirect descriptor anyway, otherwise it is possible to hit an o= verflow > >>>since presumably u16 is used for most number/size in the spec. > >>> > >>Please try to test block and scsi device for you changes as well. > >Any idea about what kind of test should be covered? AFAICT, currently > >packed ring is targeted for virtio-net as discussed during voting spec= . > > > >Wei >=20 >=20 > Well it's not only for net for sure, it should support all kinds of dev= ice. > For testing, you should test basic function plus migration. For sure we will support all the other devices, can we make it for virtio-net device first and then move on to other devices? Also, can anybody give me a CLI example for block and scsi devices? I will give it a quick shot. Wei >=20 > Thanks >=20 >=20 > > > >>Thanks > >> > >> >=20