From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: [Qemu-devel] [PATCH] iotests: drop unnecessary accel=kvm
Date: Tue, 19 Feb 2019 11:59:37 +0000 [thread overview]
Message-ID: <20190219115937.21587-1-stefanha@redhat.com> (raw)
Tests 235 and 238 do not require the kvm accelerator. TCG works fine.
Use the default accelerator instead of requiring kvm.
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tests/qemu-iotests/235 | 1 -
tests/qemu-iotests/238 | 1 -
2 files changed, 2 deletions(-)
diff --git a/tests/qemu-iotests/235 b/tests/qemu-iotests/235
index d6edd97ab4..329da8f0c2 100755
--- a/tests/qemu-iotests/235
+++ b/tests/qemu-iotests/235
@@ -49,7 +49,6 @@ qemu_img_create('-f', iotests.imgfmt, '-o', 'preallocation=metadata', disk,
str(size))
vm = QEMUMachine(iotests.qemu_prog)
-vm.add_args('-machine', 'accel=kvm')
if iotests.qemu_default_machine == 's390-ccw-virtio':
vm.add_args('-no-shutdown')
vm.add_args('-drive', 'id=src,file=' + disk)
diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
index f81ee1112f..e490bb4298 100755
--- a/tests/qemu-iotests/238
+++ b/tests/qemu-iotests/238
@@ -33,7 +33,6 @@ else:
virtio_scsi_device = 'virtio-scsi-pci'
vm = QEMUMachine(iotests.qemu_prog)
-vm.add_args('-machine', 'accel=kvm')
vm.launch()
log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
--
2.20.1
next reply other threads:[~2019-02-19 11:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 11:59 Stefan Hajnoczi [this message]
2019-02-19 12:02 ` [Qemu-devel] [PATCH] iotests: drop unnecessary accel=kvm Thomas Huth
2019-02-19 12:11 ` Vladimir Sementsov-Ogievskiy
2019-02-19 13:07 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-02-19 13:20 ` Thomas Huth
2019-02-19 13:36 ` Vladimir Sementsov-Ogievskiy
2019-02-19 13:58 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219115937.21587-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).