From: Stefano Garzarella <sgarzare@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-stable@nongnu.org,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-img: fix error reporting for -object
Date: Tue, 19 Feb 2019 17:14:09 +0100 [thread overview]
Message-ID: <20190219161409.7qzohiyfhv3qpafl@steredhat> (raw)
In-Reply-To: <20190219114609.1582-1-berrange@redhat.com>
On Tue, Feb 19, 2019 at 11:46:09AM +0000, Daniel P. Berrangé wrote:
> Error reporting for user_creatable_add_opts_foreach was changed so that
> it no longer called 'error_report_err' in:
>
> commit 7e1e0c11127bde81cff260fc6859690435c509d6
> Author: Markus Armbruster <armbru@redhat.com>
> Date: Wed Oct 17 10:26:43 2018 +0200
>
> qom: Clean up error reporting in user_creatable_add_opts_foreach()
>
> Some callers were updated to pass in "&error_fatal" but all the ones in
> qemu-img were left passing NULL. As a result all errors went to
> /dev/null instead of being reported to the user.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> qemu-img.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
next prev parent reply other threads:[~2019-02-19 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 11:46 [Qemu-devel] [PATCH] qemu-img: fix error reporting for -object Daniel P. Berrangé
2019-02-19 12:15 ` Philippe Mathieu-Daudé
2019-02-19 13:10 ` Markus Armbruster
2019-02-19 16:14 ` Stefano Garzarella [this message]
2019-02-20 11:59 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219161409.7qzohiyfhv3qpafl@steredhat \
--to=sgarzare@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).