From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
qemu-s390x@nongnu.org, "Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Cédric Le Goater" <clg@kaod.org>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Thomas Huth" <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 05/17] spapr/drc: Drop spapr_drc_attach() fdt argument
Date: Wed, 20 Feb 2019 14:22:19 +1100 [thread overview]
Message-ID: <20190220032219.GE9345@umbus.fritz.box> (raw)
In-Reply-To: <155059667853.1466090.16527852453054217565.stgit@bahia.lab.toulouse-stg.fr.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
On Tue, Feb 19, 2019 at 06:17:58PM +0100, Greg Kurz wrote:
> All DRC subtypes have been converted to generate the FDT fragment at
> configure connector time instead of attach time. The fdt and fdt_offset
> arguments of spapr_drc_attach() aren't needed anymore. Drop them and
> make the implementation of the dt_populate() method mandatory.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
I've applied the first 5 patches to ppc-for-4.0, but as a followup...
[...]
> @@ -1113,8 +1104,6 @@ static void rtas_ibm_configure_connector(PowerPCCPU *cpu,
>
> drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);
>
> - g_assert(drc->fdt || drck->dt_populate);
> -
> if (!drc->fdt) {
..you can now remove this conditional, since it will always be true.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-20 3:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 17:17 [Qemu-devel] [PATCH v5 00/17] spapr: Add support for PHB hotplug Greg Kurz
2019-02-19 17:17 ` [Qemu-devel] [PATCH v5 01/17] spapr_drc: Allow FDT fragment to be added later Greg Kurz
2019-02-19 17:17 ` [Qemu-devel] [PATCH v5 02/17] spapr: Generate FDT fragment for LMBs at configure connector time Greg Kurz
2019-02-19 17:17 ` [Qemu-devel] [PATCH v5 03/17] spapr: Generate FDT fragment for CPUs " Greg Kurz
2019-02-19 17:17 ` [Qemu-devel] [PATCH v5 04/17] spapr/pci: Generate FDT fragment " Greg Kurz
2019-02-19 17:17 ` [Qemu-devel] [PATCH v5 05/17] spapr/drc: Drop spapr_drc_attach() fdt argument Greg Kurz
2019-02-20 3:22 ` David Gibson [this message]
2019-02-20 9:01 ` Greg Kurz
2019-02-20 9:57 ` David Gibson
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 06/17] xics: Write source state to KVM at claim time Greg Kurz
2019-02-19 17:53 ` Cédric Le Goater
2019-02-20 3:24 ` David Gibson
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 07/17] spapr: Expose the name of the interrupt controller node Greg Kurz
2019-02-20 3:24 ` David Gibson
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 08/17] spapr_irq: Expose the phandle of the interrupt controller Greg Kurz
2019-02-20 3:25 ` David Gibson
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 09/17] spapr_pci: add PHB unrealize Greg Kurz
2019-02-20 3:26 ` David Gibson
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 10/17] spapr: create DR connectors for PHBs Greg Kurz
2019-02-20 3:27 ` David Gibson
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 11/17] spapr: populate PHB DRC entries for root DT node Greg Kurz
2019-02-20 3:27 ` David Gibson
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 12/17] spapr_events: add support for phb hotplug events Greg Kurz
2019-02-20 3:28 ` David Gibson
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 13/17] spapr_pci: provide node start offset via spapr_populate_pci_dt() Greg Kurz
2019-02-20 3:28 ` David Gibson
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 14/17] spapr_pci: add ibm, my-drc-index property for PHB hotplug Greg Kurz
2019-02-20 3:29 ` David Gibson
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 15/17] spapr: add hotplug hooks " Greg Kurz
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 16/17] spapr: enable PHB hotplug for default pseries machine type Greg Kurz
2019-02-19 17:18 ` [Qemu-devel] [PATCH v5 17/17] tests/device-plug: Add PHB unplug request test for spapr Greg Kurz
2019-02-20 3:30 ` [Qemu-devel] [PATCH v5 00/17] spapr: Add support for PHB hotplug David Gibson
2019-02-20 11:04 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220032219.GE9345@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=kraxel@redhat.com \
--cc=marcel@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).