From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:37981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwQYD-00025D-BQ for qemu-devel@nongnu.org; Wed, 20 Feb 2019 07:00:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwQY5-00032c-NB for qemu-devel@nongnu.org; Wed, 20 Feb 2019 07:00:31 -0500 Date: Wed, 20 Feb 2019 12:59:47 +0100 From: Kevin Wolf Message-ID: <20190220115947.GC6281@localhost.localdomain> References: <20190219114609.1582-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190219114609.1582-1-berrange@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qemu-img: fix error reporting for -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: qemu-devel@nongnu.org, Max Reitz , qemu-block@nongnu.org, Markus Armbruster , qemu-stable@nongnu.org Am 19.02.2019 um 12:46 hat Daniel P. Berrang=E9 geschrieben: > Error reporting for user_creatable_add_opts_foreach was changed so that > it no longer called 'error_report_err' in: >=20 > commit 7e1e0c11127bde81cff260fc6859690435c509d6 > Author: Markus Armbruster > Date: Wed Oct 17 10:26:43 2018 +0200 >=20 > qom: Clean up error reporting in user_creatable_add_opts_foreach() >=20 > Some callers were updated to pass in "&error_fatal" but all the ones in > qemu-img were left passing NULL. As a result all errors went to > /dev/null instead of being reported to the user. >=20 > Signed-off-by: Daniel P. Berrang=E9 Thanks, applied to the block branch. Kevin