qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fixup! vhost-user-test: create a main loop per TestServer
Date: Wed, 20 Feb 2019 14:53:22 -0500	[thread overview]
Message-ID: <20190220145309-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1550677621-10139-1-git-send-email-pbonzini@redhat.com>

On Wed, Feb 20, 2019 at 04:47:01PM +0100, Paolo Bonzini wrote:
> Fix a hang that is only latent until qgraph is merged.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

I squashed this in, thanks!

> ---
>  tests/vhost-user-test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 33030e0..527d3b3 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -557,8 +557,6 @@ static void test_server_free(TestServer *server)
>      while (g_main_context_pending(NULL)) {
>          g_main_context_iteration(NULL, TRUE);
>      }
> -    g_main_loop_unref(server->loop);
> -    g_main_context_unref(server->context);
>  
>      qemu_chr_fe_deinit(&server->chr, true);
>  
> @@ -580,6 +578,8 @@ static void test_server_free(TestServer *server)
>      g_assert(server->bus);
>      qpci_free_pc(server->bus);
>  
> +    g_main_loop_unref(server->loop);
> +    g_main_context_unref(server->context);
>      g_free(server);
>  }
>  
> -- 
> 1.8.3.1

      reply	other threads:[~2019-02-20 19:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20 15:47 [Qemu-devel] [PATCH] fixup! vhost-user-test: create a main loop per TestServer Paolo Bonzini
2019-02-20 19:53 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190220145309-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).