* [Qemu-devel] [PATCH] fixup! vhost-user-test: create a main loop per TestServer
@ 2019-02-20 15:47 Paolo Bonzini
2019-02-20 19:53 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2019-02-20 15:47 UTC (permalink / raw)
To: qemu-devel; +Cc: mst
Fix a hang that is only latent until qgraph is merged.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/vhost-user-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index 33030e0..527d3b3 100644
--- a/tests/vhost-user-test.c
+++ b/tests/vhost-user-test.c
@@ -557,8 +557,6 @@ static void test_server_free(TestServer *server)
while (g_main_context_pending(NULL)) {
g_main_context_iteration(NULL, TRUE);
}
- g_main_loop_unref(server->loop);
- g_main_context_unref(server->context);
qemu_chr_fe_deinit(&server->chr, true);
@@ -580,6 +578,8 @@ static void test_server_free(TestServer *server)
g_assert(server->bus);
qpci_free_pc(server->bus);
+ g_main_loop_unref(server->loop);
+ g_main_context_unref(server->context);
g_free(server);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] fixup! vhost-user-test: create a main loop per TestServer
2019-02-20 15:47 [Qemu-devel] [PATCH] fixup! vhost-user-test: create a main loop per TestServer Paolo Bonzini
@ 2019-02-20 19:53 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2019-02-20 19:53 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Wed, Feb 20, 2019 at 04:47:01PM +0100, Paolo Bonzini wrote:
> Fix a hang that is only latent until qgraph is merged.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
I squashed this in, thanks!
> ---
> tests/vhost-user-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 33030e0..527d3b3 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -557,8 +557,6 @@ static void test_server_free(TestServer *server)
> while (g_main_context_pending(NULL)) {
> g_main_context_iteration(NULL, TRUE);
> }
> - g_main_loop_unref(server->loop);
> - g_main_context_unref(server->context);
>
> qemu_chr_fe_deinit(&server->chr, true);
>
> @@ -580,6 +578,8 @@ static void test_server_free(TestServer *server)
> g_assert(server->bus);
> qpci_free_pc(server->bus);
>
> + g_main_loop_unref(server->loop);
> + g_main_context_unref(server->context);
> g_free(server);
> }
>
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-20 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-20 15:47 [Qemu-devel] [PATCH] fixup! vhost-user-test: create a main loop per TestServer Paolo Bonzini
2019-02-20 19:53 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).