From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Brad Smith" <brad@comstyle.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
qemu-block@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Kamil Rytarowski" <kamil@netbsd.org>
Subject: Re: [Qemu-devel] [PATCH v2 08/18] tests/bios-tables: Improve portability by searching bash in the $PATH
Date: Wed, 20 Feb 2019 15:01:17 -0500 [thread overview]
Message-ID: <20190220150111-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190129175403.18017-9-philmd@redhat.com>
On Tue, Jan 29, 2019 at 06:53:53PM +0100, Philippe Mathieu-Daudé wrote:
> Bash is not always installed as /bin/bash. In particular on OpenBSD,
> the package installs it in /usr/local/bin.
> Use the 'env' shebang to search bash in the $PATH.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> tests/data/acpi/rebuild-expected-aml.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi/rebuild-expected-aml.sh
> index bf9ba242ad..ff77a751c8 100755
> --- a/tests/data/acpi/rebuild-expected-aml.sh
> +++ b/tests/data/acpi/rebuild-expected-aml.sh
> @@ -1,4 +1,4 @@
> -#! /bin/bash
> +#! /usr/bin/env bash
>
> #
> # Rebuild expected AML files for acpi unit-test
> --
> 2.20.1
next prev parent reply other threads:[~2019-02-20 20:01 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 17:53 [Qemu-devel] [PATCH v2 00/18] OpenBSD: Enable qtesting Philippe Mathieu-Daudé
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 01/18] tests/vm: Be verbose while extracting compressed images Philippe Mathieu-Daudé
2019-02-05 13:17 ` Peter Maydell
2019-02-07 22:08 ` Philippe Mathieu-Daudé
2019-02-08 17:36 ` Alex Bennée
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 02/18] configure: Disable W^X on OpenBSD Philippe Mathieu-Daudé
2019-01-29 18:02 ` Philippe Mathieu-Daudé
2019-01-29 21:54 ` Eric Blake
2019-01-30 7:17 ` Thomas Huth
2019-02-05 3:04 ` Eric Blake
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 03/18] tests/vm/openbsd: Disable the W^X protection on the build partition Philippe Mathieu-Daudé
2019-01-29 21:58 ` Eric Blake
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 04/18] ahci-test: Add dependency to qemu-img tool Philippe Mathieu-Daudé
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 05/18] qemu-iotests: Add dependency to qemu-nbd tool Philippe Mathieu-Daudé
2019-01-29 22:03 ` Eric Blake
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 06/18] qemu-iotests: Improve portability by searching bash in the $PATH Philippe Mathieu-Daudé
2019-01-29 22:15 ` Eric Blake
2019-01-30 10:11 ` Thomas Huth
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 07/18] tests/multiboot: " Philippe Mathieu-Daudé
2019-01-29 18:10 ` Kamil Rytarowski
2019-01-29 22:16 ` Eric Blake
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 08/18] tests/bios-tables: " Philippe Mathieu-Daudé
2019-01-29 18:12 ` Kamil Rytarowski
2019-01-30 8:30 ` Igor Mammedov
2019-02-20 20:01 ` Michael S. Tsirkin [this message]
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports Philippe Mathieu-Daudé
2019-02-05 13:20 ` Peter Maydell
2019-02-05 13:42 ` Philippe Mathieu-Daudé
2019-02-05 13:57 ` Brad Smith
2019-02-05 14:23 ` Philippe Mathieu-Daudé
2019-02-05 22:24 ` Brad Smith
2019-02-06 9:17 ` Daniel P. Berrangé
2019-02-06 7:29 ` Gerd Hoffmann
2019-02-06 12:11 ` Peter Maydell
2019-02-06 18:15 ` Brad Smith
2019-02-06 20:25 ` Alex Bennée
2019-02-07 1:03 ` Brad Smith
2019-02-07 7:59 ` Alex Bennée
2019-02-05 16:09 ` Alex Bennée
2019-02-05 16:17 ` Daniel P. Berrangé
2019-01-29 17:53 ` [Qemu-devel] [RFC PATCH v2 10/18] qemu-iotests: Ensure GNU sed is used Philippe Mathieu-Daudé
2019-01-29 22:21 ` Eric Blake
2019-02-04 23:55 ` Philippe Mathieu-Daudé
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 11/18] tests/vm/openbsd: Install GNU sed from the ports Philippe Mathieu-Daudé
2019-01-29 17:53 ` [Qemu-devel] [RFC PATCH v2 12/18] test-iov: Disable iov/io test on OpenBSD Philippe Mathieu-Daudé
2019-01-29 17:53 ` [Qemu-devel] [RFC PATCH v2 13/18] oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure Philippe Mathieu-Daudé
2019-02-05 13:22 ` Peter Maydell
2019-02-05 13:43 ` Philippe Mathieu-Daudé
2019-02-05 17:40 ` Michael S. Tsirkin
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 14/18] tests/vm: Run tests on OpenBSD Philippe Mathieu-Daudé
2019-02-05 13:23 ` Peter Maydell
2019-01-29 17:54 ` [Qemu-devel] [RFC PATCH v2 15/18] iotests: Let verify_platform() check for unsupported platforms Philippe Mathieu-Daudé
2019-01-29 17:54 ` [Qemu-devel] [RFC PATCH v2 16/18] iotests: Disable 208 on OpenBSD Philippe Mathieu-Daudé
2019-01-29 17:54 ` [Qemu-devel] [RFC PATCH v2 17/18] iotests: Disable 209 " Philippe Mathieu-Daudé
2019-01-29 17:54 ` [Qemu-devel] [RFC PATCH v2 18/18] iotests: Disable 236 and 238 " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220150111-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=brad@comstyle.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=imammedo@redhat.com \
--cc=kamil@netbsd.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).