From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, eblake@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 05/13] io: Remove redundant read/write_coroutine assignments
Date: Thu, 21 Feb 2019 10:03:55 +0100 [thread overview]
Message-ID: <20190221090355.GA901@linux.fritz.box> (raw)
In-Reply-To: <46a57a6b-d4d6-62d1-20aa-64c9b5b9f91e@redhat.com>
Am 20.02.2019 um 19:22 hat Paolo Bonzini geschrieben:
> On 20/02/19 19:07, Kevin Wolf wrote:
> > Am 20.02.2019 um 19:01 hat Paolo Bonzini geschrieben:
> >> aio_co_wake was also acquiring/releasing the AioContext, so
> >> that needs to stay for now.
> >
> > True. Maybe I should leave the aio_co_wake call alone() and just add the
> > assertion to avoid complicating the code rather than simplifying it...
>
> Yes, I agree.
Okay, I made this change locally. I'm not sending a v3 for this, but
will just directly merge it if no other comments come up.
> ps: where is alone() defined? :)
#define aio_co_wake aio_co_wake()
#define alone() alone
Here. :-)
Kevin
next prev parent reply other threads:[~2019-02-21 9:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 17:48 [Qemu-devel] [PATCH v2 00/13] block: bdrv_set_aio_context() related fixes Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 01/13] block-backend: Make blk_inc/dec_in_flight public Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 02/13] virtio-blk: Increase in_flight for request restart BH Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 03/13] nbd: Restrict connection_co reentrance Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 04/13] io: Make qio_channel_yield() interruptible Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 05/13] io: Remove redundant read/write_coroutine assignments Kevin Wolf
2019-02-20 18:01 ` Paolo Bonzini
2019-02-20 18:07 ` Kevin Wolf
2019-02-20 18:22 ` Paolo Bonzini
2019-02-21 9:03 ` Kevin Wolf [this message]
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 06/13] nbd: Move nbd_read_eof() to nbd/client.c Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 07/13] nbd: Use low-level QIOChannel API in nbd_read_eof() Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 08/13] nbd: Increase bs->in_flight during AioContext switch Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 09/13] block: Don't poll in bdrv_set_aio_context() Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 10/13] block: Fix AioContext switch for drained node Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 11/13] test-bdrv-drain: AioContext switch in drained section Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 12/13] block: Use normal drain for bdrv_set_aio_context() Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 13/13] aio-posix: Assert that aio_poll() is always called in home thread Kevin Wolf
2019-02-25 10:31 ` [Qemu-devel] [PATCH v2 00/13] block: bdrv_set_aio_context() related fixes Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221090355.GA901@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).