From: Alex Williamson <alex.williamson@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Qemu-devel] [PATCH v2 2/3] vfio/display: add xres + yres properties
Date: Thu, 21 Feb 2019 10:35:36 -0700 [thread overview]
Message-ID: <20190221103536.2166450b@w520.home> (raw)
In-Reply-To: <20190221074643.cb6chu3tu7nkytpo@sirius.home.kraxel.org>
On Thu, 21 Feb 2019 08:46:43 +0100
Gerd Hoffmann <kraxel@redhat.com> wrote:
> Hi,
>
> > > + DEFINE_PROP_UINT32("xres", VFIOPCIDevice, display_xres, 0),
> > > + DEFINE_PROP_UINT32("yres", VFIOPCIDevice, display_yres, 0),
> >
> > This is actually quite fun, I started my VM with arbitrary numbers and
> > the Windows GUI honored it every time. Probably very useful for
> > playing with odd screen sizes. I also tried to break it using
> > 1000000x1000000, but the display came up as 1920x1200, the maximum
> > resolution GVT-g supports for this type. I don't see that QEMU is
> > bounding this though, do we depend on the mdev device to ignore it if
> > we pass values it cannot support?
>
> There is a check in vfio_display_edid_update().
Ok, so we're bounded within QEMU, that seems good. Thanks,
Alex
next prev parent reply other threads:[~2019-02-21 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 8:47 [Qemu-devel] [PATCH v2 0/3] vfio/display: add edid support Gerd Hoffmann
2019-02-20 8:47 ` [Qemu-devel] [PATCH v2 1/3] " Gerd Hoffmann
2019-02-20 21:54 ` Alex Williamson
2019-02-21 7:38 ` Gerd Hoffmann
2019-02-21 17:34 ` Alex Williamson
2019-02-22 5:45 ` Gerd Hoffmann
2019-02-20 8:47 ` [Qemu-devel] [PATCH v2 2/3] vfio/display: add xres + yres properties Gerd Hoffmann
2019-02-20 22:36 ` Alex Williamson
2019-02-21 7:46 ` Gerd Hoffmann
2019-02-21 17:35 ` Alex Williamson [this message]
2019-02-20 8:47 ` [Qemu-devel] [PATCH v2 3/3] vfio/display: delay link up event Gerd Hoffmann
2019-02-20 22:39 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221103536.2166450b@w520.home \
--to=alex.williamson@redhat.com \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).