* [Qemu-devel] [PATCH] tests/cdrom-test: only include isapc cdrom test when g_test_slow()
@ 2019-02-21 13:41 Alex Bennée
2019-02-21 16:25 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Alex Bennée @ 2019-02-21 13:41 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth, qemu-block, jsnow, Alex Bennée
We are seeing instability on our CI runs which has been there since
the test was introduced. I suspect it triggers more on Travis due to
their heavy load.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/cdrom-test.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/cdrom-test.c b/tests/cdrom-test.c
index 14bd981336..05611da648 100644
--- a/tests/cdrom-test.c
+++ b/tests/cdrom-test.c
@@ -132,8 +132,14 @@ static void add_x86_tests(void)
qtest_add_data_func("cdrom/boot/virtio-scsi",
"-device virtio-scsi -device scsi-cd,drive=cdr "
"-blockdev file,node-name=cdr,filename=", test_cdboot);
- qtest_add_data_func("cdrom/boot/isapc", "-M isapc "
- "-drive if=ide,media=cdrom,file=", test_cdboot);
+ /*
+ * Unstable CI test under load
+ * See https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg05509.html
+ */
+ if (g_test_slow()) {
+ qtest_add_data_func("cdrom/boot/isapc", "-M isapc "
+ "-drive if=ide,media=cdrom,file=", test_cdboot);
+ }
qtest_add_data_func("cdrom/boot/am53c974",
"-device am53c974 -device scsi-cd,drive=cd1 "
"-drive if=none,id=cd1,format=raw,file=", test_cdboot);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/cdrom-test: only include isapc cdrom test when g_test_slow()
2019-02-21 13:41 [Qemu-devel] [PATCH] tests/cdrom-test: only include isapc cdrom test when g_test_slow() Alex Bennée
@ 2019-02-21 16:25 ` Thomas Huth
2019-02-21 16:48 ` Alex Bennée
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2019-02-21 16:25 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: qemu-block, jsnow
On 21/02/2019 14.41, Alex Bennée wrote:
> We are seeing instability on our CI runs which has been there since
> the test was introduced. I suspect it triggers more on Travis due to
> their heavy load.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/cdrom-test.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tests/cdrom-test.c b/tests/cdrom-test.c
> index 14bd981336..05611da648 100644
> --- a/tests/cdrom-test.c
> +++ b/tests/cdrom-test.c
> @@ -132,8 +132,14 @@ static void add_x86_tests(void)
> qtest_add_data_func("cdrom/boot/virtio-scsi",
> "-device virtio-scsi -device scsi-cd,drive=cdr "
> "-blockdev file,node-name=cdr,filename=", test_cdboot);
> - qtest_add_data_func("cdrom/boot/isapc", "-M isapc "
> - "-drive if=ide,media=cdrom,file=", test_cdboot);
> + /*
> + * Unstable CI test under load
> + * See https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg05509.html
> + */
> + if (g_test_slow()) {
> + qtest_add_data_func("cdrom/boot/isapc", "-M isapc "
> + "-drive if=ide,media=cdrom,file=", test_cdboot);
> + }
> qtest_add_data_func("cdrom/boot/am53c974",
> "-device am53c974 -device scsi-cd,drive=cd1 "
> "-drive if=none,id=cd1,format=raw,file=", test_cdboot);
>
Acked-by: Thomas Huth <thuth@redhat.com>
Which tree should this go through? qtest? Block? Your test tree?
At least I don't have much in the qtest queue right now and did not plan
a pull request soon. Let me know if you want me to queue it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/cdrom-test: only include isapc cdrom test when g_test_slow()
2019-02-21 16:25 ` Thomas Huth
@ 2019-02-21 16:48 ` Alex Bennée
0 siblings, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2019-02-21 16:48 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, qemu-block, jsnow
Thomas Huth <thuth@redhat.com> writes:
> On 21/02/2019 14.41, Alex Bennée wrote:
>> We are seeing instability on our CI runs which has been there since
>> the test was introduced. I suspect it triggers more on Travis due to
>> their heavy load.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> tests/cdrom-test.c | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/cdrom-test.c b/tests/cdrom-test.c
>> index 14bd981336..05611da648 100644
>> --- a/tests/cdrom-test.c
>> +++ b/tests/cdrom-test.c
>> @@ -132,8 +132,14 @@ static void add_x86_tests(void)
>> qtest_add_data_func("cdrom/boot/virtio-scsi",
>> "-device virtio-scsi -device scsi-cd,drive=cdr "
>> "-blockdev file,node-name=cdr,filename=", test_cdboot);
>> - qtest_add_data_func("cdrom/boot/isapc", "-M isapc "
>> - "-drive if=ide,media=cdrom,file=", test_cdboot);
>> + /*
>> + * Unstable CI test under load
>> + * See https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg05509.html
>> + */
>> + if (g_test_slow()) {
>> + qtest_add_data_func("cdrom/boot/isapc", "-M isapc "
>> + "-drive if=ide,media=cdrom,file=", test_cdboot);
>> + }
>> qtest_add_data_func("cdrom/boot/am53c974",
>> "-device am53c974 -device scsi-cd,drive=cd1 "
>> "-drive if=none,id=cd1,format=raw,file=", test_cdboot);
>>
>
> Acked-by: Thomas Huth <thuth@redhat.com>
>
> Which tree should this go through? qtest? Block? Your test tree?
I'll put in my testing/next pull-req.
>
> At least I don't have much in the qtest queue right now and did not plan
> a pull request soon. Let me know if you want me to queue it.
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-21 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-21 13:41 [Qemu-devel] [PATCH] tests/cdrom-test: only include isapc cdrom test when g_test_slow() Alex Bennée
2019-02-21 16:25 ` Thomas Huth
2019-02-21 16:48 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).