From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gx68m-0002cZ-QO for qemu-devel@nongnu.org; Fri, 22 Feb 2019 03:25:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gx68l-0007KZ-C5 for qemu-devel@nongnu.org; Fri, 22 Feb 2019 03:25:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58572) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gx68l-0007DB-03 for qemu-devel@nongnu.org; Fri, 22 Feb 2019 03:25:03 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0C2A882F0 for ; Fri, 22 Feb 2019 08:24:49 +0000 (UTC) From: Gerd Hoffmann Date: Fri, 22 Feb 2019 09:24:35 +0100 Message-Id: <20190222082436.23029-5-kraxel@redhat.com> In-Reply-To: <20190222082436.23029-1-kraxel@redhat.com> References: <20190222082436.23029-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 4/5] virtio-gpu: remove useless 'waiting' field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= From: Marc-Andr=C3=A9 Lureau Let's check renderer_blocked instead directly. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Christophe Fergeau Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20190221114330.17968-5-marcandre.lureau@redhat.com Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 - hw/display/virtio-gpu.c | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gp= u.h index f8cd8ee96fb2..26a669826688 100644 --- a/include/hw/virtio/virtio-gpu.h +++ b/include/hw/virtio/virtio-gpu.h @@ -81,7 +81,6 @@ struct virtio_gpu_ctrl_command { VirtQueue *vq; struct virtio_gpu_ctrl_hdr cmd_hdr; uint32_t error; - bool waiting; bool finished; QTAILQ_ENTRY(virtio_gpu_ctrl_command) next; }; diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 7ada4b83ac29..0baa9ac0ad0e 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -889,8 +889,7 @@ void virtio_gpu_process_cmdq(VirtIOGPU *g) while (!QTAILQ_EMPTY(&g->cmdq)) { cmd =3D QTAILQ_FIRST(&g->cmdq); =20 - cmd->waiting =3D g->renderer_blocked; - if (cmd->waiting) { + if (g->renderer_blocked) { break; } =20 @@ -939,7 +938,6 @@ static void virtio_gpu_handle_ctrl(VirtIODevice *vdev= , VirtQueue *vq) cmd->vq =3D vq; cmd->error =3D 0; cmd->finished =3D false; - cmd->waiting =3D false; QTAILQ_INSERT_TAIL(&g->cmdq, cmd, next); cmd =3D virtqueue_pop(vq, sizeof(struct virtio_gpu_ctrl_command)= ); } --=20 2.9.3