From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Eric Blake" <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] iothread: create gcontext unconditionally
Date: Fri, 22 Feb 2019 17:45:20 +0800 [thread overview]
Message-ID: <20190222094520.GN8904@xz-x1> (raw)
In-Reply-To: <4c74698e-3d3b-be12-1f60-cacf0c3421ef@redhat.com>
On Fri, Feb 22, 2019 at 10:28:57AM +0100, Paolo Bonzini wrote:
> On 22/02/19 04:14, Peter Xu wrote:
> > And if this patchset can survive... how about running gcontext
> > directly in iothread_run()? I believe there could be a bit more
> > things to clean but I'll see.
>
> Do you mean instead of aio_poll?
Yes.
> The problem is that GMainContext is
> quite a bit slower than aio_poll.
That's really what I wanted to know; so it's about performance.
We should mention it somewhere in iothread_run. I can do that after I
know how this series will go.
>
> Frediano and I tried to bring some of the optimizations of aio_poll to
> GMainContext
> (https://github.com/GNOME/glib/commit/e91c11841808ccca408da96136f433a82b2e2145),
> but they broke webkit. :(
What a pity!
--
Peter Xu
next prev parent reply other threads:[~2019-02-22 9:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 3:14 [Qemu-devel] [PATCH 0/4] iothread: create gcontext unconditionally Peter Xu
2019-02-22 3:14 ` [Qemu-devel] [PATCH 1/4] iothread: replace init_done_cond with a semaphore Peter Xu
2019-02-22 6:25 ` Marc-André Lureau
2019-02-22 6:36 ` Peter Xu
2019-02-22 9:27 ` Paolo Bonzini
2019-02-22 9:44 ` Marc-André Lureau
2019-02-27 13:26 ` Stefan Hajnoczi
2019-02-22 3:14 ` [Qemu-devel] [PATCH 2/4] iothread: create the gcontext onconditionally Peter Xu
2019-02-22 6:29 ` Marc-André Lureau
2019-02-22 6:47 ` Peter Xu
2019-02-22 3:14 ` [Qemu-devel] [PATCH 3/4] iothread: create main loop unconditionally Peter Xu
2019-02-22 6:30 ` Marc-André Lureau
2019-02-22 3:14 ` [Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_fn Peter Xu
2019-02-22 6:37 ` Marc-André Lureau
2019-02-22 6:57 ` Peter Xu
2019-02-22 9:24 ` Paolo Bonzini
2019-02-27 13:38 ` Stefan Hajnoczi
2019-02-28 5:58 ` Peter Xu
2019-03-01 16:25 ` Stefan Hajnoczi
2019-03-04 2:26 ` Peter Xu
2019-03-04 9:12 ` Marc-André Lureau
2019-03-04 9:37 ` Peter Xu
2019-02-22 9:28 ` [Qemu-devel] [PATCH 0/4] iothread: create gcontext unconditionally Paolo Bonzini
2019-02-22 9:45 ` Peter Xu [this message]
2019-03-06 10:19 ` Stefan Hajnoczi
2019-03-06 11:44 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222094520.GN8904@xz-x1 \
--to=peterx@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).