qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>
Subject: [Qemu-devel] [PULL 9/9] tests/cdrom-test: only include isapc cdrom test when g_test_slow()
Date: Fri, 22 Feb 2019 09:54:21 +0000	[thread overview]
Message-ID: <20190222095421.28938-10-alex.bennee@linaro.org> (raw)
In-Reply-To: <20190222095421.28938-1-alex.bennee@linaro.org>

We are seeing instability on our CI runs which has been there since
the test was introduced. I suspect it triggers more on Travis due to
their heavy load.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: Thomas Huth <thuth@redhat.com>

diff --git a/tests/cdrom-test.c b/tests/cdrom-test.c
index 14bd981336..05611da648 100644
--- a/tests/cdrom-test.c
+++ b/tests/cdrom-test.c
@@ -132,8 +132,14 @@ static void add_x86_tests(void)
     qtest_add_data_func("cdrom/boot/virtio-scsi",
                         "-device virtio-scsi -device scsi-cd,drive=cdr "
                         "-blockdev file,node-name=cdr,filename=", test_cdboot);
-    qtest_add_data_func("cdrom/boot/isapc", "-M isapc "
-                        "-drive if=ide,media=cdrom,file=", test_cdboot);
+    /*
+     * Unstable CI test under load
+     * See https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg05509.html
+     */
+    if (g_test_slow()) {
+        qtest_add_data_func("cdrom/boot/isapc", "-M isapc "
+                            "-drive if=ide,media=cdrom,file=", test_cdboot);
+    }
     qtest_add_data_func("cdrom/boot/am53c974",
                         "-device am53c974 -device scsi-cd,drive=cd1 "
                         "-drive if=none,id=cd1,format=raw,file=", test_cdboot);
-- 
2.20.1

  parent reply	other threads:[~2019-02-22  9:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22  9:54 [Qemu-devel] [PULL 0/9] various Travis and Docker fixes, add gitlab CI Alex Bennée
2019-02-22  9:54 ` [Qemu-devel] [PULL 1/9] .travis.yml: the xcode10 image seems to be hosed Alex Bennée
2019-02-22  9:54 ` [Qemu-devel] [PULL 2/9] .travis.yml: split debug builds Alex Bennée
2019-02-22  9:54 ` [Qemu-devel] [PULL 3/9] .travis.yml: Test with disable-replication Alex Bennée
2019-02-22  9:54 ` [Qemu-devel] [PULL 4/9] .travis.yml: Remove disable-uuid Alex Bennée
2019-02-22  9:54 ` [Qemu-devel] [PULL 5/9] tests/docker: squash initial update and install step for debian9 Alex Bennée
2019-02-22  9:54 ` [Qemu-devel] [PULL 6/9] tests/docker: peg netmap code to a specific version Alex Bennée
2019-02-22  9:54 ` [Qemu-devel] [PULL 7/9] Add a gitlab-ci file for Continuous Integration testing on Gitlab Alex Bennée
2019-02-22  9:54 ` [Qemu-devel] [PULL 8/9] tests/softfloat: always do quick softfloat tests Alex Bennée
2019-02-22  9:54 ` Alex Bennée [this message]
2019-02-25 17:27 ` [Qemu-devel] [PULL 0/9] various Travis and Docker fixes, add gitlab CI Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190222095421.28938-10-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).