From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 3/3] s390x/tcg: Save vregs to extended mchk save area
Date: Fri, 22 Feb 2019 11:20:53 +0100 [thread overview]
Message-ID: <20190222112053.11ebfab5.cohuck@redhat.com> (raw)
In-Reply-To: <20190222081153.14206-4-david@redhat.com>
On Fri, 22 Feb 2019 09:11:53 +0100
David Hildenbrand <david@redhat.com> wrote:
> If we have vector registers and the designation is not zero, we have
> to try to write the vector registers. If the designation is zero or
> if storing fails, we must not indicate validity. s390_build_validity_mcic()
> automatically already sets validity if the vector instruction facility
> is installed.
>
> As long as we don't support the guarded-storage facility, the alignemnt &
> size of the area is always 1024 bytes.
s/alignemnt & size/alignment and size/
Can change while applying.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/excp_helper.c | 46 ++++++++++++++++++++++++++++++++++++--
> target/s390x/internal.h | 4 +++-
> 2 files changed, 47 insertions(+), 3 deletions(-)
next prev parent reply other threads:[~2019-02-22 10:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 8:11 [Qemu-devel] [PATCH v1 0/3] s390x: SIGP + IRQ preparations for TCG vector register support David Hildenbrand
2019-02-22 8:11 ` [Qemu-devel] [PATCH v1 1/3] s390x: Use cpu_to_be64 in SIGP STORE ADDITIONAL STATUS David Hildenbrand
2019-02-22 8:55 ` Thomas Huth
2019-02-22 11:23 ` Christian Borntraeger
2019-02-22 8:11 ` [Qemu-devel] [PATCH v1 2/3] s390x: use a QEMU-style typedef + name for SIGP save area struct David Hildenbrand
2019-02-22 8:36 ` Thomas Huth
2019-02-22 11:24 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2019-02-22 8:11 ` [Qemu-devel] [PATCH v1 3/3] s390x/tcg: Save vregs to extended mchk save area David Hildenbrand
2019-02-22 9:09 ` Thomas Huth
2019-02-22 10:20 ` Cornelia Huck [this message]
2019-02-22 10:16 ` [Qemu-devel] [PATCH v1 0/3] s390x: SIGP + IRQ preparations for TCG vector register support Cornelia Huck
2019-02-22 10:26 ` David Hildenbrand
2019-02-25 11:21 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222112053.11ebfab5.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).