From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: mreitz@redhat.com, eblake@redhat.com, pbonzini@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 00/13] block: bdrv_set_aio_context() related fixes
Date: Mon, 25 Feb 2019 11:31:05 +0100 [thread overview]
Message-ID: <20190225103105.GA6320@linux.fritz.box> (raw)
In-Reply-To: <20190220174843.8847-1-kwolf@redhat.com>
Am 20.02.2019 um 18:48 hat Kevin Wolf geschrieben:
> Background for this series is the following bug report, which is about a
> crash with virtio-blk + iothread and request resubmission for werror/rerror:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1671173
>
> The reason is that bdrv_set_aio_context() didn't correctly quiesce
> everything. Instead, it had a local hack to call aio_poll() for the
> source AioContext, which covered some, but not all cases, and is wrong
> because you can only call aio_poll() from the home thread.
>
> So this series tries to make bdrv_drain() actually drain the known cases
> (fixes virtio-blk and the NBD client) and use the regular drain
> functions in bdrv_set_aio_context() instead of open-coding something
> similar.
Applied to the block branch.
Kevin
prev parent reply other threads:[~2019-02-25 10:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 17:48 [Qemu-devel] [PATCH v2 00/13] block: bdrv_set_aio_context() related fixes Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 01/13] block-backend: Make blk_inc/dec_in_flight public Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 02/13] virtio-blk: Increase in_flight for request restart BH Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 03/13] nbd: Restrict connection_co reentrance Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 04/13] io: Make qio_channel_yield() interruptible Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 05/13] io: Remove redundant read/write_coroutine assignments Kevin Wolf
2019-02-20 18:01 ` Paolo Bonzini
2019-02-20 18:07 ` Kevin Wolf
2019-02-20 18:22 ` Paolo Bonzini
2019-02-21 9:03 ` Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 06/13] nbd: Move nbd_read_eof() to nbd/client.c Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 07/13] nbd: Use low-level QIOChannel API in nbd_read_eof() Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 08/13] nbd: Increase bs->in_flight during AioContext switch Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 09/13] block: Don't poll in bdrv_set_aio_context() Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 10/13] block: Fix AioContext switch for drained node Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 11/13] test-bdrv-drain: AioContext switch in drained section Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 12/13] block: Use normal drain for bdrv_set_aio_context() Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 13/13] aio-posix: Assert that aio_poll() is always called in home thread Kevin Wolf
2019-02-25 10:31 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225103105.GA6320@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).