qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: Murilo Opsfelder Araujo <mopsfelder@gmail.com>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>,
	Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/3] ppc/pnv: increase kernel size limit to 256MiB
Date: Mon, 25 Feb 2019 17:52:57 -0300	[thread overview]
Message-ID: <20190225205257.GA30778@kermit.br.ibm.com> (raw)
In-Reply-To: <5b70e0f2-0464-cda6-9f3f-3add525fa6bc@kaod.org>

On Mon, Feb 25, 2019 at 07:58:06PM +0100, Cédric Le Goater wrote:
> On 2/25/19 6:01 PM, Murilo Opsfelder Araujo wrote:
> > First patch increases kernel size limit to 256MiB to fit images generated with
> > CONFIG_DEBUG_INFO.
> >
> > Second patch just fixes a misleading comment regarding initrd size limit.
> >
> > Third patch uses IEC prefixes to represent size constants.
>
> They look fine.
>
> Have you tried these patches on a P9 machine ? You will need to use
> the powernv-4.0 branch on my github for that.

I had actually smoke-tested it on my laptop:

[    0.000000] Linux version 5.0.0-rc8-panda (muriloo@localhost) (gcc version 6.4.0 (Buildroot 2018.02-rc2-00006-g39101b7)) #1 SMP Mon Feb 25 11:00:15 -03 2019
[    0.000000] Found initrd at 0xc000000060000000:0xc0000000601e6cfc
[    0.000000] OPAL: Found non-mapped LPC bus on chip 0
[    0.000000] Using PowerNV machine description
[    0.000000] printk: bootconsole [udbg0] enabled
[    0.000000] CPU maps initialized for 1 thread per core
[    0.000000]  (thread shift is 0)
[    0.000000] Allocated 3336 bytes for 1 pacas

My patches apply smoothly on top of your powernv-4.0 branch, in case you're
willing to give it a try.

Let's chat offline to get it tested on a p9 machine.

Thanks for the review!

--
Murilo

      reply	other threads:[~2019-02-25 20:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 17:01 [Qemu-devel] [PATCH v2 0/3] ppc/pnv: increase kernel size limit to 256MiB Murilo Opsfelder Araujo
2019-02-25 17:01 ` [Qemu-devel] [PATCH v2 1/3] " Murilo Opsfelder Araujo
2019-02-25 18:55   ` Cédric Le Goater
2019-02-25 17:01 ` [Qemu-devel] [PATCH v2 2/3] ppc/pnv: add INITRD_MAX_SIZE constant Murilo Opsfelder Araujo
2019-02-25 18:55   ` Cédric Le Goater
2019-02-25 17:01 ` [Qemu-devel] [PATCH v2 3/3] ppc/pnv: use IEC binary prefixes to represent sizes Murilo Opsfelder Araujo
2019-02-25 18:56   ` Cédric Le Goater
2019-02-25 18:58 ` [Qemu-devel] [PATCH v2 0/3] ppc/pnv: increase kernel size limit to 256MiB Cédric Le Goater
2019-02-25 20:52   ` Murilo Opsfelder Araujo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190225205257.GA30778@kermit.br.ibm.com \
    --to=muriloo@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=eblake@redhat.com \
    --cc=mopsfelder@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).