* [Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238
@ 2019-02-25 16:18 Stefan Hajnoczi
2019-02-25 16:23 ` Thomas Huth
2019-02-26 8:49 ` Kevin Wolf
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2019-02-25 16:18 UTC (permalink / raw)
To: qemu-devel
Cc: Max Reitz, Kevin Wolf, qemu-block, Stefan Hajnoczi, Thomas Huth
Test 238 does not require the kvm accelerator. tcg and qtest work too.
Use qtest since it's always built in while kvm and tcg are not.
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tests/qemu-iotests/238 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
index f81ee1112f..c7f8d9422b 100755
--- a/tests/qemu-iotests/238
+++ b/tests/qemu-iotests/238
@@ -33,7 +33,7 @@ else:
virtio_scsi_device = 'virtio-scsi-pci'
vm = QEMUMachine(iotests.qemu_prog)
-vm.add_args('-machine', 'accel=kvm')
+vm.add_args('-machine', 'accel=qtest')
vm.launch()
log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238
2019-02-25 16:18 [Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238 Stefan Hajnoczi
@ 2019-02-25 16:23 ` Thomas Huth
2019-02-26 8:49 ` Kevin Wolf
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2019-02-25 16:23 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Max Reitz, Kevin Wolf, qemu-block
On 25/02/2019 17.18, Stefan Hajnoczi wrote:
> Test 238 does not require the kvm accelerator. tcg and qtest work too.
>
> Use qtest since it's always built in while kvm and tcg are not.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tests/qemu-iotests/238 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> index f81ee1112f..c7f8d9422b 100755
> --- a/tests/qemu-iotests/238
> +++ b/tests/qemu-iotests/238
> @@ -33,7 +33,7 @@ else:
> virtio_scsi_device = 'virtio-scsi-pci'
>
> vm = QEMUMachine(iotests.qemu_prog)
> -vm.add_args('-machine', 'accel=kvm')
> +vm.add_args('-machine', 'accel=qtest')
> vm.launch()
>
> log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238
2019-02-25 16:18 [Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238 Stefan Hajnoczi
2019-02-25 16:23 ` Thomas Huth
@ 2019-02-26 8:49 ` Kevin Wolf
2019-02-27 14:44 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
1 sibling, 1 reply; 4+ messages in thread
From: Kevin Wolf @ 2019-02-26 8:49 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-devel, Max Reitz, qemu-block, Thomas Huth
Am 25.02.2019 um 17:18 hat Stefan Hajnoczi geschrieben:
> Test 238 does not require the kvm accelerator. tcg and qtest work too.
>
> Use qtest since it's always built in while kvm and tcg are not.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tests/qemu-iotests/238 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> index f81ee1112f..c7f8d9422b 100755
> --- a/tests/qemu-iotests/238
> +++ b/tests/qemu-iotests/238
> @@ -33,7 +33,7 @@ else:
> virtio_scsi_device = 'virtio-scsi-pci'
>
> vm = QEMUMachine(iotests.qemu_prog)
> -vm.add_args('-machine', 'accel=kvm')
> +vm.add_args('-machine', 'accel=qtest')
> vm.launch()
Why not use iotests.VM? This would be a qtest machine automatically.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-block] [PATCH v3] iotests: use -M accel=qtest in 238
2019-02-26 8:49 ` Kevin Wolf
@ 2019-02-27 14:44 ` Stefan Hajnoczi
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2019-02-27 14:44 UTC (permalink / raw)
To: Kevin Wolf
Cc: Stefan Hajnoczi, Thomas Huth, qemu-devel, qemu-block, Max Reitz
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
On Tue, Feb 26, 2019 at 09:49:59AM +0100, Kevin Wolf wrote:
> Am 25.02.2019 um 17:18 hat Stefan Hajnoczi geschrieben:
> > Test 238 does not require the kvm accelerator. tcg and qtest work too.
> >
> > Use qtest since it's always built in while kvm and tcg are not.
> >
> > Suggested-by: Thomas Huth <thuth@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > tests/qemu-iotests/238 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> > index f81ee1112f..c7f8d9422b 100755
> > --- a/tests/qemu-iotests/238
> > +++ b/tests/qemu-iotests/238
> > @@ -33,7 +33,7 @@ else:
> > virtio_scsi_device = 'virtio-scsi-pci'
> >
> > vm = QEMUMachine(iotests.qemu_prog)
> > -vm.add_args('-machine', 'accel=kvm')
> > +vm.add_args('-machine', 'accel=qtest')
> > vm.launch()
>
> Why not use iotests.VM? This would be a qtest machine automatically.
Good idea, will fix in v4.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-27 14:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-25 16:18 [Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238 Stefan Hajnoczi
2019-02-25 16:23 ` Thomas Huth
2019-02-26 8:49 ` Kevin Wolf
2019-02-27 14:44 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).