From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Zhang Chen <chen.zhang@intel.com>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>,
Zhang Chen <zhangckid@gmail.com>,
Juan Quintela <quintela@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
qemu-dev <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] Migration/colo.c: Fix double close bug when occur COLO failover
Date: Tue, 26 Feb 2019 10:36:46 +0000 [thread overview]
Message-ID: <20190226103646.GB2721@work-vm> (raw)
In-Reply-To: <20190226053434.6252-2-chen.zhang@intel.com>
* Zhang Chen (chen.zhang@intel.com) wrote:
> From: Zhang Chen <chen.zhang@intel.com>
>
> In migration_incoming_state_destroy(void) will check the mis->to_src_file
> to double close the mis->to_src_file when occur COLO failover.
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/colo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration/colo.c b/migration/colo.c
> index 398b239d1c..a916dc178c 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -872,6 +872,7 @@ out:
> /* Must be called after failover BH is completed */
> if (mis->to_src_file) {
> qemu_fclose(mis->to_src_file);
> + mis->to_src_file = NULL;
> }
> migration_incoming_disable_colo();
>
> --
> 2.17.GIT
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-02-26 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 5:34 [Qemu-devel] [PATCH 0/3] Migration/colo.c: Fix upstream bugs when occur failover Zhang Chen
2019-02-26 5:34 ` [Qemu-devel] [PATCH 1/3] Migration/colo.c: Fix double close bug when occur COLO failover Zhang Chen
2019-02-26 10:36 ` Dr. David Alan Gilbert [this message]
2019-02-26 5:34 ` [Qemu-devel] [PATCH 2/3] Migration/colo.c: Fix COLO failover status error Zhang Chen
2019-02-26 10:55 ` Dr. David Alan Gilbert
2019-02-26 11:25 ` Zhang, Chen
2019-02-28 13:02 ` Dr. David Alan Gilbert
2019-02-28 13:29 ` Zhang, Chen
2019-02-26 5:34 ` [Qemu-devel] [PATCH 3/3] Migration/colo.c: Make COLO node running after failover Zhang Chen
2019-02-26 11:01 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226103646.GB2721@work-vm \
--to=dgilbert@redhat.com \
--cc=chen.zhang@intel.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).