From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, david@redhat.com,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: [Qemu-devel] [PULL 7/7] tests/Makefile.include: test all rounding modes of softfloat
Date: Tue, 26 Feb 2019 14:12:01 +0000 [thread overview]
Message-ID: <20190226141201.16999-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20190226141201.16999-1-alex.bennee@linaro.org>
We missed a bug in a recent patch as we were not testing all the
rounding modes for all operations. However enabling all rounding modes
for mulAdd does slow down the already slowest test and doesn't really
buy us much additional coverage so lets allow the default test flags
to be overridden.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 060f765b0e..f260014f02 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -898,12 +898,12 @@ $(FP_TEST_BIN):
# The full test suite can take a bit of time, default to a quick run
# "-l 2 -r all" can take more than a day for some operations and is best
# run manually
-FP_TL=-l 1
+FP_TL=-l 1 -r all
-# $1 = tests, $2 = description
+# $1 = tests, $2 = description, $3 = test flags
test-softfloat = $(call quiet-command, \
cd $(BUILD_DIR)/tests/fp && \
- ./fp-test -s $(FP_TL) $1 > $2.out 2>&1 || \
+ ./fp-test -s $(if $3,$3,$(FP_TL)) $1 > $2.out 2>&1 || \
(cat $2.out && exit 1;), \
"FLOAT TEST", $2)
@@ -984,7 +984,7 @@ check-softfloat-compare: $(SF_COMPARE_RULES)
check-softfloat-mulAdd: $(FP_TEST_BIN)
$(call test-softfloat, \
f16_mulAdd f32_mulAdd f64_mulAdd f128_mulAdd, \
- mulAdd)
+ mulAdd,-l 1)
# FIXME: extF80_rem (broken)
check-softfloat-rem: $(FP_TEST_BIN)
--
2.20.1
next prev parent reply other threads:[~2019-02-26 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 14:11 [Qemu-devel] [PULL 0/7] softfloat updates, mostly for s390x Alex Bennée
2019-02-26 14:11 ` [Qemu-devel] [PULL 1/7] tests: Ignore fp test outputs Alex Bennée
2019-02-26 14:11 ` [Qemu-devel] [PULL 2/7] softfloat: add float128_is_{normal, denormal} Alex Bennée
2019-02-26 14:11 ` [Qemu-devel] [PULL 3/7] softfloat: Implement float128_to_uint32 Alex Bennée
2019-02-26 14:11 ` [Qemu-devel] [PULL 4/7] tests/fp: add wrapping for f128_to_ui32 Alex Bennée
2019-02-26 14:11 ` [Qemu-devel] [PULL 5/7] tests/fp: enable f128_to_ui[32/64] tests in float-to-uint Alex Bennée
2019-02-26 14:12 ` [Qemu-devel] [PULL 6/7] softfloat: Support float_round_to_odd more places Alex Bennée
2019-02-26 14:12 ` Alex Bennée [this message]
2019-02-28 12:02 ` [Qemu-devel] [PULL 0/7] softfloat updates, mostly for s390x Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226141201.16999-8-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=david@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).