qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jason Wang <jasowang@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/13] Netpatches
Date: Tue, 26 Feb 2019 19:50:16 +0000	[thread overview]
Message-ID: <20190226195016.GM2721@work-vm> (raw)
In-Reply-To: <CAFEAcA_Q5oHYOabG5rOcZY16BadrypW6MUg1im4CxeDXdeqTpA@mail.gmail.com>

* Peter Maydell (peter.maydell@linaro.org) wrote:
> On Fri, 22 Feb 2019 at 14:55, Jason Wang <jasowang@redhat.com> wrote:
> >
> > The following changes since commit 7817ea16c1bb91ba3849e704d5f3e3c5775087bf:
> >
> >   Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190221' into staging (2019-02-22 13:04:42 +0000)
> >
> > are available in the git repository at:
> >
> >   https://github.com/jasowang/qemu.git tags/net-pull-request
> >
> > for you to fetch changes up to eb4702b3ffcf11ec62f0c401f77f49219594e95c:
> >
> >   net: netmap: improve netmap_receive_iov() (2019-02-22 22:39:24 +0800)
> >
> > ----------------------------------------------------------------
> >
> > ----------------------------------------------------------------
> 
> Fails to build on at least some hosts:
> 
> cc -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g   -Wl,--warn-common -g
>   /home/pm215/qemu/tests/test-announce-self.c tests/libqtest.o
> libqemuutil.a   -o tests/test-announce-self
> /home/pm215/qemu/tests/test-announce-self.c:11:24: fatal error:
> qemu/osdep.h: No such file or directory
>  #include "qemu/osdep.h"
>                         ^
> 
> 
> Something looks to be wrong with the command line here -- it is
> not adding the usual/expected set of QEMU cflags (and in particular
> is missing the option that adds the QEMU source tree to the
> include path).

OK, I see it, I was missing a :
+tests/test-announce-self$(EXESUF): tests/test-announce-self.o

line

Curious that it worked on some platforms; I guess maybe there's an
implicit rule somewhere.

Dave

> thanks
> -- PMM
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

      reply	other threads:[~2019-02-26 19:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 14:55 [Qemu-devel] [PULL 00/13] Netpatches Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 01/13] net/colo-compare.c: Remove duplicated code Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 02/13] net: Introduce announce timer Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 03/13] migration: Add announce parameters Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 04/13] virtio-net: Switch to using announce timer Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 05/13] migration: " Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 06/13] net: Add a network device specific self-announcement ability Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 07/13] virtio-net: Allow qemu_announce_self to trigger virtio announcements Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 08/13] qmp: Add announce-self command Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 09/13] hmp: Add hmp_announce_self Jason Wang
2019-02-27  8:28   ` Thomas Huth
2019-02-27 13:11     ` Dr. David Alan Gilbert
2019-02-22 14:55 ` [Qemu-devel] [PULL 10/13] tests: Add a test for qemu self announcements Jason Wang
2019-02-27  8:21   ` Thomas Huth
2019-02-27 12:58     ` Dr. David Alan Gilbert
2019-02-22 14:55 ` [Qemu-devel] [PULL 11/13] net: netmap: small improvements netmap_send() Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 12/13] net: netmap: simplify netmap_receive() Jason Wang
2019-02-22 14:55 ` [Qemu-devel] [PULL 13/13] net: netmap: improve netmap_receive_iov() Jason Wang
2019-02-26 16:06 ` [Qemu-devel] [PULL 00/13] Netpatches Peter Maydell
2019-02-26 19:50   ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226195016.GM2721@work-vm \
    --to=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).