qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	peter.maydell@linaro.org, shameerali.kolothum.thodi@huawei.com,
	imammedo@redhat.com, david@redhat.com
Cc: dgilbert@redhat.com, david@gibson.dropbear.id.au,
	drjones@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v9 18/18] hw/arm/virt: Allow nvdimm instantiation
Date: Tue, 26 Feb 2019 21:44:39 +0100	[thread overview]
Message-ID: <20190226204439.2296-19-eric.auger@redhat.com> (raw)
In-Reply-To: <20190226204439.2296-1-eric.auger@redhat.com>

If NVDIMM option is enabled at machine level, let's allow
NVDIMM plug.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 hw/arm/virt.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index af2ccaf152..c0f982de02 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1833,13 +1833,14 @@ static void virt_memory_pre_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
                                  Error **errp)
 {
     const bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM);
+    MachineState *ms = MACHINE(hotplug_dev);
 
     if (dev->hotplugged) {
         error_setg(errp, "memory hotplug is not supported");
     }
 
-    if (is_nvdimm) {
-        error_setg(errp, "nvdimm is not yet supported");
+    if (is_nvdimm && !ms->acpi_nvdimm_state.is_enabled) {
+        error_setg(errp, "nvdimm is not enabled: missing 'nvdimm' in '-M'");
         return;
     }
 
-- 
2.20.1

      parent reply	other threads:[~2019-02-26 20:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 20:44 [Qemu-devel] [PATCH v9 00/18] ARM virt: Initial RAM expansion and PCDIMM/NVDIMM support Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 01/18] hw/arm/boot: introduce fdt_add_memory_node helper Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 02/18] hw/arm/virt: Rename highmem IO regions Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 03/18] hw/arm/virt: Split the memory map description Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 04/18] hw/boards: Add a MachineState parameter to kvm_type callback Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 05/18] kvm: add kvm_arm_get_max_vm_ipa_size Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 06/18] vl: Set machine ram_size, maxram_size and ram_slots earlier Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 07/18] hw/arm/virt: Dynamic memory map depending on RAM requirements Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 08/18] hw/arm/virt: Implement kvm_type function for 4.0 machine Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 09/18] hw/arm/virt: Check the VCPU PA range in TCG mode Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 10/18] hw/arm/virt: Bump the 255GB initial RAM limit Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 11/18] hw/arm/virt: Add memory hotplug framework Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 12/18] hw/arm/boot: Expose the PC-DIMM nodes in the DT Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 13/18] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 14/18] nvdimm: Use configurable ACPI IO base and size Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 15/18] machine: Move acpi_nvdimm_state into struct MachineState Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 16/18] hw/arm/virt: Add nvdimm hot-plug infrastructure Eric Auger
2019-02-26 20:44 ` [Qemu-devel] [PATCH v9 17/18] hw/arm/boot: Expose the pmem nodes in the DT Eric Auger
2019-02-26 20:44 ` Eric Auger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226204439.2296-19-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shameerali.kolothum.thodi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).