From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:53038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyu0d-0006r5-5E for qemu-devel@nongnu.org; Wed, 27 Feb 2019 02:52:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyu0c-0004od-3P for qemu-devel@nongnu.org; Wed, 27 Feb 2019 02:52:07 -0500 Received: from mga09.intel.com ([134.134.136.24]:39878) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyu0b-0004jf-NF for qemu-devel@nongnu.org; Wed, 27 Feb 2019 02:52:05 -0500 From: Wei Yang Date: Wed, 27 Feb 2019 15:50:59 +0800 Message-Id: <20190227075101.6263-3-richardw.yang@linux.intel.com> In-Reply-To: <20190227075101.6263-1-richardw.yang@linux.intel.com> References: <20190227075101.6263-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 2/4] nvdimm: use *function* directly instead of allocating it again List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com, imammedo@redhat.com, xiaoguangrong.eric@gmail.com, Wei Yang At the beginning or nvdimm_build_common_dsm(), variable *function* is already allocated for Arg2. This patch reuse variable *function* instead of allocating it again. Signed-off-by: Wei Yang --- hw/acpi/nvdimm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 39af8cdba8..e63a1ef15d 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/acpi/nvdimm.c @@ -1086,7 +1086,7 @@ static void nvdimm_build_common_dsm(Aml *dev) */ aml_append(method, aml_store(handle, aml_name(NVDIMM_DSM_HANDLE))); aml_append(method, aml_store(aml_arg(1), aml_name(NVDIMM_DSM_REVISION))); - aml_append(method, aml_store(aml_arg(2), aml_name(NVDIMM_DSM_FUNCTION))); + aml_append(method, aml_store(function, aml_name(NVDIMM_DSM_FUNCTION))); /* * The fourth parameter (Arg3) of _DSM is a package which contains -- 2.19.1