From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:44213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyz8d-0006NP-9T for qemu-devel@nongnu.org; Wed, 27 Feb 2019 08:20:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyz8b-0007sH-P7 for qemu-devel@nongnu.org; Wed, 27 Feb 2019 08:20:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35198) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyz8b-0007oW-Fi for qemu-devel@nongnu.org; Wed, 27 Feb 2019 08:20:41 -0500 Date: Wed, 27 Feb 2019 13:11:32 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20190227131132.GG2602@work-vm> References: <1550847320-25110-1-git-send-email-jasowang@redhat.com> <1550847320-25110-10-git-send-email-jasowang@redhat.com> <954908bc-c5fd-9073-e137-dd4057c792ea@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <954908bc-c5fd-9073-e137-dd4057c792ea@redhat.com> Subject: Re: [Qemu-devel] [PULL 09/13] hmp: Add hmp_announce_self List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Jason Wang , qemu-devel@nongnu.org, peter.maydell@linaro.org, Vladislav Yasevich , "Michael S. Tsirkin" * Thomas Huth (thuth@redhat.com) wrote: > On 22/02/2019 15.55, Jason Wang wrote: > > From: "Dr. David Alan Gilbert" > > > > Add an HMP command to trigger self annocements. > > Unlike the QMP command (which takes a set of parameters), the HMP > > command reuses the set of parameters used for migration. > > > > Signend-off-by: Vladislav Yasevich > > Signed-off-by: Dr. David Alan Gilbert > > Reviewed-by: Michael S. Tsirkin > > Signed-off-by: Jason Wang > > --- > > hmp-commands.hx | 14 ++++++++++++++ > > hmp.c | 5 +++++ > > hmp.h | 1 + > > tests/test-hmp.c | 1 + > > 4 files changed, 21 insertions(+) > > > > diff --git a/hmp-commands.hx b/hmp-commands.hx > > index ba71558..9f812bc 100644 > > --- a/hmp-commands.hx > > +++ b/hmp-commands.hx > > @@ -931,6 +931,20 @@ stops because the size limit is reached. > > ETEXI > > > > { > > + .name = "announce_self", > > + .args_type = "", > > + .params = "", > > + .help = "Trigger GARP/RARP announcements", > > + .cmd = hmp_announce_self, > > + }, > > + > > +STEXI > > +@item announce_self > > +@findex announce_self > > +Trigger GARP/RARP announcements. > > +ETEXI > > The help text is incredibly sparse. I doubt that the average user > manages to find out the meaning of this command just by looking at this > short information. Also, shouldn't you mention here that the parameters > used for migration are re-used here, like in the patch description? > Thus, could you please send a follow-up patch to increase that > information here a little bit, please? I've updated that to: +STEXI +@item announce_self +@findex announce_self +Trigger a round of GARP/RARP broadcasts; this is useful for explicitly updating the +network infrastructure after a reconfiguration or some forms of migration. +The timings of the round are set by the migration announce parameters. ETEXI None of these pieces of help seem to be particularly deep. Dave > Thanks, > Thomas -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK