From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] iothread: replace init_done_cond with a semaphore
Date: Wed, 27 Feb 2019 13:26:21 +0000 [thread overview]
Message-ID: <20190227132621.GA22539@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190222031413.20250-2-peterx@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
On Fri, Feb 22, 2019 at 11:14:10AM +0800, Peter Xu wrote:
> Only sending an init-done message using lock+cond seems an overkill to
> me. Replacing it with a simpler semaphore.
>
> Meanwhile, init the semaphore unconditionally, then we can destroy it
> unconditionally too in finalize which seems cleaner.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> include/sysemu/iothread.h | 3 +--
> iothread.c | 17 ++++-------------
> 2 files changed, 5 insertions(+), 15 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2019-02-27 13:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 3:14 [Qemu-devel] [PATCH 0/4] iothread: create gcontext unconditionally Peter Xu
2019-02-22 3:14 ` [Qemu-devel] [PATCH 1/4] iothread: replace init_done_cond with a semaphore Peter Xu
2019-02-22 6:25 ` Marc-André Lureau
2019-02-22 6:36 ` Peter Xu
2019-02-22 9:27 ` Paolo Bonzini
2019-02-22 9:44 ` Marc-André Lureau
2019-02-27 13:26 ` Stefan Hajnoczi [this message]
2019-02-22 3:14 ` [Qemu-devel] [PATCH 2/4] iothread: create the gcontext onconditionally Peter Xu
2019-02-22 6:29 ` Marc-André Lureau
2019-02-22 6:47 ` Peter Xu
2019-02-22 3:14 ` [Qemu-devel] [PATCH 3/4] iothread: create main loop unconditionally Peter Xu
2019-02-22 6:30 ` Marc-André Lureau
2019-02-22 3:14 ` [Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_fn Peter Xu
2019-02-22 6:37 ` Marc-André Lureau
2019-02-22 6:57 ` Peter Xu
2019-02-22 9:24 ` Paolo Bonzini
2019-02-27 13:38 ` Stefan Hajnoczi
2019-02-28 5:58 ` Peter Xu
2019-03-01 16:25 ` Stefan Hajnoczi
2019-03-04 2:26 ` Peter Xu
2019-03-04 9:12 ` Marc-André Lureau
2019-03-04 9:37 ` Peter Xu
2019-02-22 9:28 ` [Qemu-devel] [PATCH 0/4] iothread: create gcontext unconditionally Paolo Bonzini
2019-02-22 9:45 ` Peter Xu
2019-03-06 10:19 ` Stefan Hajnoczi
2019-03-06 11:44 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227132621.GA22539@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).