From: David Gibson <david@gibson.dropbear.id.au>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tcg/ppc: Add vector opcodes
Date: Thu, 28 Feb 2019 15:01:57 +1100 [thread overview]
Message-ID: <20190228040157.GD27799@umbus.fritz.box> (raw)
In-Reply-To: <bf117507-a3da-9dcd-e2c1-031312b7d89e@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]
On Wed, Feb 27, 2019 at 04:47:30PM -0800, Richard Henderson wrote:
> On 2/24/19 3:31 PM, David Gibson wrote:
> > I have access to POWER8 and POWER9 machines, but I haven't worked with
> > RISU before. If you can give me a straightforward recipe I can try
> > running the tests.
>
> From
>
> https://git.linaro.org/people/peter.maydell/risu.git
And I assume build it, at which point I hit this:
$ make
gcc -Wall -D_GNU_SOURCE -DARCH=ppc64 -I /home/dwg/risu/risu -g -o risu_ppc64.o -c risu_ppc64.c
risu_ppc64.c: In function ‘advance_pc’:
risu_ppc64.c:19:25: error: dereferencing pointer to incomplete type ‘struct pt_regs’
uc->uc_mcontext.regs->nip += 4;
^~
make: *** [Makefile:44: risu_ppc64.o] Error 1
I'm running on ppc64le (as I usually do nowadays), so I'm not sure if
this is due to a difference between the ppc64 and ppc64le ABIs (and
mcontext structures) or something else.
> First you need to generate the test cases. It looks like the current
> ppc64.risu file is fairly complete, at least to some level. So:
>
> mkdir ../risu-testcases-ppc64
> ./scripts/generate_all.sh ppc64.risu ../risu-testcases-ppc64
>
> Then record traces from real hardware to compare against:
>
> RISU=`pwd`/risu ./scripts/record_traces.sh ../risu-testcases-ppc64/*.bin
>
> Now compare QEMU against hardware:
>
> QEMU=qemu-ppc64 RISU=`pwd`/risu \
> ./scripts/run_risu ../risu-testcases-ppc64/*.bin
>
> Which is all hunky dory until something fails. At which point it's a matter of
> using qemu's -d and -dfilter options judiciously, and "objdump -b binary -m
> ppc64 -D foo.bin".
>
>
> r~
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-28 4:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 5:59 [Qemu-devel] [PATCH] tcg/ppc: Add vector opcodes Richard Henderson
2019-02-22 17:13 ` Mark Cave-Ayland
2019-02-22 20:20 ` Richard Henderson
2019-02-24 23:31 ` David Gibson
2019-02-28 0:47 ` Richard Henderson
2019-02-28 4:01 ` David Gibson [this message]
2019-02-28 5:11 ` Richard Henderson
2019-02-27 15:45 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228040157.GD27799@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).