qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: f4bug@amsat.org
Subject: [Qemu-devel] [PATCH 9/8] decodetree: Produce clean output for an empty input file
Date: Wed, 27 Feb 2019 21:40:07 -0800	[thread overview]
Message-ID: <20190228054007.779-1-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190228052432.32571-1-richard.henderson@linaro.org>

This is interesting for bisection, where an output file is plumbed,
but does not yet have patterns.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---

One more small fix that should have gone with the v2 patchset.

---
 scripts/decodetree.py | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 68979b73a0..1785769eec 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -1050,15 +1050,16 @@ def main():
            '(DisasContext *ctx, ', insntype, ' insn)\n{\n')
 
     i4 = str_indent(4)
-    output(i4, 'union {\n')
-    for n in sorted(arguments.keys()):
-        f = arguments[n]
-        output(i4, i4, f.struct_name(), ' f_', f.name, ';\n')
-    output(i4, '} u;\n\n')
 
-    t.output_code(4, False, 0, 0)
+    if len(allpatterns) != 0:
+        output(i4, 'union {\n')
+        for n in sorted(arguments.keys()):
+            f = arguments[n]
+            output(i4, i4, f.struct_name(), ' f_', f.name, ';\n')
+        output(i4, '} u;\n\n')
+        t.output_code(4, False, 0, 0)
+
     output(i4, 'return false;\n')
-
     output('}\n')
 
     if output_file:
-- 
2.17.2

      parent reply	other threads:[~2019-02-28  5:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28  5:24 [Qemu-devel] [PATCH v2 0/8] decodetree enhancements Richard Henderson
2019-02-28  5:24 ` [Qemu-devel] [PATCH v2 1/8] MAINTAINERS: Add scripts/decodetree.py to the TCG section Richard Henderson
2019-02-28  5:24 ` [Qemu-devel] [PATCH v2 2/8] decodetree: Move documentation to docs/devel/decodetree.rst Richard Henderson
2019-02-28  8:01   ` Bastian Koppelmann
2019-02-28  5:24 ` [Qemu-devel] [PATCH v2 3/8] decodetree: Document the usefulness of argument sets Richard Henderson
2019-02-28  8:02   ` Bastian Koppelmann
2019-02-28  5:24 ` [Qemu-devel] [PATCH v2 4/8] decodetree: Ensure build_tree does not include values outside insnmask Richard Henderson
2019-02-28  5:24 ` [Qemu-devel] [PATCH v2 5/8] decodetree: Do not unconditionaly return from Pattern.output_code Richard Henderson
2019-02-28  5:24 ` [Qemu-devel] [PATCH v2 6/8] decodetree: Allow grouping of overlapping patterns Richard Henderson
2019-02-28  5:24 ` [Qemu-devel] [PATCH v2 7/8] test/decode: Add tests for PatternGroups Richard Henderson
2019-02-28  5:24 ` [Qemu-devel] [PATCH v2 8/8] decodetree: Add --static-decode option Richard Henderson
2019-02-28  5:40 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190228054007.779-1-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).