From: Samuel Thibault <samuel.thibault@gnu.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Greg Kurz <groug@kaod.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH] slirp: Fix build with gcc 9
Date: Thu, 28 Feb 2019 12:38:10 -0800 [thread overview]
Message-ID: <20190228203810.7l2f76by3hqf463l@function> (raw)
In-Reply-To: <CAFEAcA_p1fFQWKnDXfTw=7UY_pM3RfZ5pJbBATBzDK_6DN7HmQ@mail.gmail.com>
Hello,
Peter Maydell, le jeu. 28 févr. 2019 18:14:40 +0000, a ecrit:
> My guess is that this got a packed attribute mistakenly
> by analogy with the struct slirp_arphdr which is used in
> the ArpTable struct -- but that struct really is used to
> match on-the-wire data, and this one is not.
This looks like cargo-culted indeed. Greg, please repost with the size
constraint, we do not need it.
Samuel
prev parent reply other threads:[~2019-02-28 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 17:55 [Qemu-devel] [PATCH] slirp: Fix build with gcc 9 Greg Kurz
2019-02-28 18:14 ` Peter Maydell
2019-02-28 20:38 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228203810.7l2f76by3hqf463l@function \
--to=samuel.thibault@gnu.org \
--cc=groug@kaod.org \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).