From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gziu3-0003qo-5P for qemu-devel@nongnu.org; Fri, 01 Mar 2019 09:12:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzity-0000i7-Is for qemu-devel@nongnu.org; Fri, 01 Mar 2019 09:12:40 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:35122) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gzitx-0000eP-Hv for qemu-devel@nongnu.org; Fri, 01 Mar 2019 09:12:38 -0500 Received: by mail-qt1-f194.google.com with SMTP id p48so27861476qtk.2 for ; Fri, 01 Mar 2019 06:12:36 -0800 (PST) Date: Fri, 1 Mar 2019 09:12:33 -0500 From: "Michael S. Tsirkin" Message-ID: <20190301091214-mutt-send-email-mst@kernel.org> References: <1551407310-32413-1-git-send-email-guoheyi@huawei.com> <20190301084619-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] hw/arm/acpi: enable SHPC native hot plug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Heyi Guo Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, wanghaibin.wang@huawei.com, Shannon Zhao , Peter Maydell , Igor Mammedov , Heyi Guo On Fri, Mar 01, 2019 at 10:04:38PM +0800, Heyi Guo wrote: > > > On 2019/3/1 21:47, Michael S. Tsirkin wrote: > > On Fri, Mar 01, 2019 at 10:28:30AM +0800, Heyi Guo wrote: > > > After the introduction of generic PCIe root port and PCIe-PCI bridge, > > > we will also have SHPC controller on ARM, so just enalbe SHPC native > > > hot plug. > > > > > > Cc: Shannon Zhao > > > Cc: Peter Maydell > > > Cc: "Michael S. Tsirkin" > > > Cc: Igor Mammedov > > > Signed-off-by: Heyi Guo > > > Signed-off-by: Heyi Guo > > > > So when OS enables SHPC, should we block ACPI hotplug events? > I supposed we don't support ACPI hotplug events on ARM virt; do we have any currently? > > Thanks, > Heyi Oh I didn't realise. That explains it sorry about the noise. > > > > > --- > > > hw/arm/virt-acpi-build.c | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > > > index 04b62c7..7849ec5 100644 > > > --- a/hw/arm/virt-acpi-build.c > > > +++ b/hw/arm/virt-acpi-build.c > > > @@ -265,7 +265,12 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap, > > > aml_create_dword_field(aml_arg(3), aml_int(8), "CDW3")); > > > aml_append(ifctx, aml_store(aml_name("CDW2"), aml_name("SUPP"))); > > > aml_append(ifctx, aml_store(aml_name("CDW3"), aml_name("CTRL"))); > > > - aml_append(ifctx, aml_store(aml_and(aml_name("CTRL"), aml_int(0x1D), NULL), > > > + > > > + /* > > > + * Allow OS control for all 5 features: > > > + * PCIeHotplug SHPCHotplug PME AER PCIeCapability. > > > + */ > > > + aml_append(ifctx, aml_store(aml_and(aml_name("CTRL"), aml_int(0x1F), NULL), > > > aml_name("CTRL"))); > > > ifctx1 = aml_if(aml_lnot(aml_equal(aml_arg(1), aml_int(0x1)))); > > > -- > > > 1.8.3.1 > > . > > >