From: Palmer Dabbelt <palmer@sifive.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Peer Adelt <peer.adelt@hni.uni-paderborn.de>,
Palmer Dabbelt <palmer@sifive.com>
Subject: [Qemu-devel] [PULL 29/34] target/riscv: Remove decode_RV32_64G()
Date: Fri, 1 Mar 2019 13:49:40 -0800 [thread overview]
Message-ID: <20190301214945.4353-30-palmer@sifive.com> (raw)
In-Reply-To: <20190301214945.4353-1-palmer@sifive.com>
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
decodetree handles all instructions now so the fallback is not necessary
anymore.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
---
target/riscv/translate.c | 21 +--------------------
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index 92be090bc7bb..049fa65c6611 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/translate.c
@@ -651,24 +651,6 @@ bool decode_insn16(DisasContext *ctx, uint16_t insn);
#include "decode_insn16.inc.c"
#include "insn_trans/trans_rvc.inc.c"
-static void decode_RV32_64G(DisasContext *ctx)
-{
- uint32_t op;
-
- /* We do not do misaligned address check here: the address should never be
- * misaligned at this point. Instructions that set PC must do the check,
- * since epc must be the address of the instruction that caused us to
- * perform the misaligned instruction fetch */
-
- op = MASK_OP_MAJOR(ctx->opcode);
-
- switch (op) {
- default:
- gen_exception_illegal(ctx);
- break;
- }
-}
-
static void decode_opc(DisasContext *ctx)
{
/* check for compressed insn */
@@ -685,8 +667,7 @@ static void decode_opc(DisasContext *ctx)
} else {
ctx->pc_succ_insn = ctx->base.pc_next + 4;
if (!decode_insn32(ctx, ctx->opcode)) {
- /* fallback to old decoder */
- decode_RV32_64G(ctx);
+ gen_exception_illegal(ctx);
}
}
}
--
2.18.1
next prev parent reply other threads:[~2019-03-01 21:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 21:49 [Qemu-devel] [PULL] target/riscv: Convert to decodetree Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 01/34] target/riscv: Activate decodetree and implemnt LUI & AUIPC Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 02/34] target/riscv: Convert RVXI branch insns to decodetree Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 03/34] target/riscv: Convert RV32I load/store " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 04/34] target/riscv: Convert RV64I " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 05/34] target/riscv: Convert RVXI arithmetic " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 06/34] target/riscv: Convert RVXI fence " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 07/34] target/riscv: Convert RVXI csr " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 08/34] target/riscv: Convert RVXM " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 09/34] target/riscv: Convert RV32A " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 10/34] target/riscv: Convert RV64A " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 11/34] target/riscv: Convert RV32F " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 12/34] target/riscv: Convert RV64F " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 13/34] target/riscv: Convert RV32D " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 14/34] target/riscv: Convert RV64D " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 15/34] target/riscv: Convert RV priv " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 16/34] target/riscv: Convert quadrant 0 of RVXC " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 17/34] target/riscv: Convert quadrant 1 " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 18/34] target/riscv: Convert quadrant 2 " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 19/34] target/riscv: Remove gen_jalr() Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 20/34] target/riscv: Remove manual decoding from gen_branch() Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 21/34] target/riscv: Remove manual decoding from gen_load() Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 22/34] target/riscv: Remove manual decoding from gen_store() Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 23/34] target/riscv: Move gen_arith_imm() decoding into trans_* functions Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 24/34] target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 25/34] target/riscv: Remove shift and slt insn manual decoding Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 26/34] target/riscv: Remove manual decoding of RV32/64M insn Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 27/34] target/riscv: Rename trans_arith to gen_arith Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 28/34] target/riscv: Remove gen_system() Palmer Dabbelt
2019-03-01 21:49 ` Palmer Dabbelt [this message]
2019-03-01 21:49 ` [Qemu-devel] [PULL 30/34] target/riscv: Convert @cs_2 insns to share translation functions Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 31/34] target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 32/34] target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 33/34] target/riscv: Splice remaining compressed insn pairs " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 34/34] target/riscv: Remaining rvc insn reuse 32 bit translators Palmer Dabbelt
2019-03-04 11:02 ` [Qemu-devel] [PULL] target/riscv: Convert to decodetree Peter Maydell
2019-03-04 12:52 ` Bastian Koppelmann
2019-03-04 15:25 ` Bastian Koppelmann
2019-03-04 19:30 ` Richard Henderson
2019-03-04 21:46 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301214945.4353-30-palmer@sifive.com \
--to=palmer@sifive.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peer.adelt@hni.uni-paderborn.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).