From: Palmer Dabbelt <palmer@sifive.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Peer Adelt <peer.adelt@hni.uni-paderborn.de>,
Palmer Dabbelt <palmer@sifive.com>
Subject: [Qemu-devel] [PULL 03/34] target/riscv: Convert RV32I load/store insns to decodetree
Date: Fri, 1 Mar 2019 13:49:14 -0800 [thread overview]
Message-ID: <20190301214945.4353-4-palmer@sifive.com> (raw)
In-Reply-To: <20190301214945.4353-1-palmer@sifive.com>
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
---
target/riscv/insn32.decode | 10 ++++++
target/riscv/insn_trans/trans_rvi.inc.c | 48 +++++++++++++++++++++++++
2 files changed, 58 insertions(+)
diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode
index 81f56c16b45f..076de873c4f1 100644
--- a/target/riscv/insn32.decode
+++ b/target/riscv/insn32.decode
@@ -23,6 +23,7 @@
# immediates:
%imm_i 20:s12
+%imm_s 25:s7 7:5
%imm_b 31:s1 7:1 25:6 8:4 !function=ex_shift_1
%imm_j 31:s1 12:8 20:1 21:10 !function=ex_shift_1
%imm_u 12:s20 !function=ex_shift_12
@@ -33,6 +34,7 @@
# Formats 32:
@i ............ ..... ... ..... ....... imm=%imm_i %rs1 %rd
@b ....... ..... ..... ... ..... ....... &b imm=%imm_b %rs2 %rs1
+@s ....... ..... ..... ... ..... ....... imm=%imm_s %rs2 %rs1
@u .................... ..... ....... imm=%imm_u %rd
@j .................... ..... ....... imm=%imm_j %rd
@@ -47,3 +49,11 @@ blt ....... ..... ..... 100 ..... 1100011 @b
bge ....... ..... ..... 101 ..... 1100011 @b
bltu ....... ..... ..... 110 ..... 1100011 @b
bgeu ....... ..... ..... 111 ..... 1100011 @b
+lb ............ ..... 000 ..... 0000011 @i
+lh ............ ..... 001 ..... 0000011 @i
+lw ............ ..... 010 ..... 0000011 @i
+lbu ............ ..... 100 ..... 0000011 @i
+lhu ............ ..... 101 ..... 0000011 @i
+sb ....... ..... ..... 000 ..... 0100011 @s
+sh ....... ..... ..... 001 ..... 0100011 @s
+sw ....... ..... ..... 010 ..... 0100011 @s
diff --git a/target/riscv/insn_trans/trans_rvi.inc.c b/target/riscv/insn_trans/trans_rvi.inc.c
index bcf20def50eb..d13b7b2b6d8f 100644
--- a/target/riscv/insn_trans/trans_rvi.inc.c
+++ b/target/riscv/insn_trans/trans_rvi.inc.c
@@ -82,3 +82,51 @@ static bool trans_bgeu(DisasContext *ctx, arg_bgeu *a)
gen_branch(ctx, OPC_RISC_BGEU, a->rs1, a->rs2, a->imm);
return true;
}
+
+static bool trans_lb(DisasContext *ctx, arg_lb *a)
+{
+ gen_load(ctx, OPC_RISC_LB, a->rd, a->rs1, a->imm);
+ return true;
+}
+
+static bool trans_lh(DisasContext *ctx, arg_lh *a)
+{
+ gen_load(ctx, OPC_RISC_LH, a->rd, a->rs1, a->imm);
+ return true;
+}
+
+static bool trans_lw(DisasContext *ctx, arg_lw *a)
+{
+ gen_load(ctx, OPC_RISC_LW, a->rd, a->rs1, a->imm);
+ return true;
+}
+
+static bool trans_lbu(DisasContext *ctx, arg_lbu *a)
+{
+ gen_load(ctx, OPC_RISC_LBU, a->rd, a->rs1, a->imm);
+ return true;
+}
+
+static bool trans_lhu(DisasContext *ctx, arg_lhu *a)
+{
+ gen_load(ctx, OPC_RISC_LHU, a->rd, a->rs1, a->imm);
+ return true;
+}
+
+static bool trans_sb(DisasContext *ctx, arg_sb *a)
+{
+ gen_store(ctx, OPC_RISC_SB, a->rs1, a->rs2, a->imm);
+ return true;
+}
+
+static bool trans_sh(DisasContext *ctx, arg_sh *a)
+{
+ gen_store(ctx, OPC_RISC_SH, a->rs1, a->rs2, a->imm);
+ return true;
+}
+
+static bool trans_sw(DisasContext *ctx, arg_sw *a)
+{
+ gen_store(ctx, OPC_RISC_SW, a->rs1, a->rs2, a->imm);
+ return true;
+}
--
2.18.1
next prev parent reply other threads:[~2019-03-01 21:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 21:49 [Qemu-devel] [PULL] target/riscv: Convert to decodetree Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 01/34] target/riscv: Activate decodetree and implemnt LUI & AUIPC Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 02/34] target/riscv: Convert RVXI branch insns to decodetree Palmer Dabbelt
2019-03-01 21:49 ` Palmer Dabbelt [this message]
2019-03-01 21:49 ` [Qemu-devel] [PULL 04/34] target/riscv: Convert RV64I load/store " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 05/34] target/riscv: Convert RVXI arithmetic " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 06/34] target/riscv: Convert RVXI fence " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 07/34] target/riscv: Convert RVXI csr " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 08/34] target/riscv: Convert RVXM " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 09/34] target/riscv: Convert RV32A " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 10/34] target/riscv: Convert RV64A " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 11/34] target/riscv: Convert RV32F " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 12/34] target/riscv: Convert RV64F " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 13/34] target/riscv: Convert RV32D " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 14/34] target/riscv: Convert RV64D " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 15/34] target/riscv: Convert RV priv " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 16/34] target/riscv: Convert quadrant 0 of RVXC " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 17/34] target/riscv: Convert quadrant 1 " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 18/34] target/riscv: Convert quadrant 2 " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 19/34] target/riscv: Remove gen_jalr() Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 20/34] target/riscv: Remove manual decoding from gen_branch() Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 21/34] target/riscv: Remove manual decoding from gen_load() Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 22/34] target/riscv: Remove manual decoding from gen_store() Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 23/34] target/riscv: Move gen_arith_imm() decoding into trans_* functions Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 24/34] target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 25/34] target/riscv: Remove shift and slt insn manual decoding Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 26/34] target/riscv: Remove manual decoding of RV32/64M insn Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 27/34] target/riscv: Rename trans_arith to gen_arith Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 28/34] target/riscv: Remove gen_system() Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 29/34] target/riscv: Remove decode_RV32_64G() Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 30/34] target/riscv: Convert @cs_2 insns to share translation functions Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 31/34] target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 32/34] target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 33/34] target/riscv: Splice remaining compressed insn pairs " Palmer Dabbelt
2019-03-01 21:49 ` [Qemu-devel] [PULL 34/34] target/riscv: Remaining rvc insn reuse 32 bit translators Palmer Dabbelt
2019-03-04 11:02 ` [Qemu-devel] [PULL] target/riscv: Convert to decodetree Peter Maydell
2019-03-04 12:52 ` Bastian Koppelmann
2019-03-04 15:25 ` Bastian Koppelmann
2019-03-04 19:30 ` Richard Henderson
2019-03-04 21:46 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301214945.4353-4-palmer@sifive.com \
--to=palmer@sifive.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peer.adelt@hni.uni-paderborn.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).