qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Chen <chen.zhang@intel.com >
To: Li Zhijian <lizhijian@cn.fujitsu.com>,
	Zhang Chen <zhangckid@gmail.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	Markus Armbruster <armbru@redhat.com>,
	Eric Blake <eblake@redhat.com>, qemu-dev <qemu-devel@nongnu.org>
Cc: Zhang Chen <chen.zhang@intel.com>
Subject: [Qemu-devel] [PATCH V3 6/7] Migration/colo.c: Add the necessary checks for colo_do_failover
Date: Sun,  3 Mar 2019 22:50:20 +0800	[thread overview]
Message-ID: <20190303145021.2962-7-chen.zhang@intel.com> (raw)
In-Reply-To: <20190303145021.2962-1-chen.zhang@intel.com>

From: Zhang Chen <chen.zhang@intel.com>

Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
 migration/colo.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/migration/colo.c b/migration/colo.c
index dbe2b88807..d1ae2e6d11 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -197,10 +197,16 @@ void colo_do_failover(MigrationState *s)
         vm_stop_force_state(RUN_STATE_COLO);
     }
 
-    if (get_colo_mode() == COLO_MODE_PRIMARY) {
+    switch (get_colo_mode()) {
+    case COLO_MODE_PRIMARY:
         primary_vm_do_failover();
-    } else {
+        break;
+    case COLO_MODE_SECONDARY:
         secondary_vm_do_failover();
+        break;
+    default:
+        error_report("colo_do_failover failed because the colo mode"
+                     " could not be obtained");
     }
 }
 
-- 
2.17.GIT

  parent reply	other threads:[~2019-03-03 15:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-03 14:50 [Qemu-devel] [PATCH V3 0/7] Migration/colo: Fix upstream bugs when occur failover Zhang Chen
2019-03-03 14:50 ` [Qemu-devel] [PATCH V3 1/7] Migration/colo.c: Fix double close bug when occur COLO failover Zhang Chen
2019-03-03 14:50 ` [Qemu-devel] [PATCH V3 2/7] Migration/colo.c: Fix COLO failover status error Zhang Chen
2019-03-08 17:32   ` Dr. David Alan Gilbert
2019-03-03 14:50 ` [Qemu-devel] [PATCH V3 3/7] Migration/colo.c: Make COLO node running after failover Zhang Chen
2019-03-03 14:50 ` [Qemu-devel] [PATCH V3 4/7] Migration/colo.c: Add new COLOExitReason to handle all failover state Zhang Chen
2019-03-08 17:39   ` Dr. David Alan Gilbert
2019-03-09 17:06   ` Markus Armbruster
2019-03-11  9:08     ` Zhang, Chen
2019-03-03 14:50 ` [Qemu-devel] [PATCH V3 5/7] qapi/migration.json: Remove a variable that doesn't exist in example Zhang Chen
2019-03-03 14:50 ` Zhang Chen [this message]
2019-03-08 17:41   ` [Qemu-devel] [PATCH V3 6/7] Migration/colo.c: Add the necessary checks for colo_do_failover Dr. David Alan Gilbert
2019-03-08 18:36     ` Zhang, Chen
2019-03-08 19:02       ` Dr. David Alan Gilbert
2019-03-03 14:50 ` [Qemu-devel] [PATCH V3 7/7] Migration/colo.c: Make user obtain the COLO mode info after failover Zhang Chen
2019-03-08 17:45   ` Dr. David Alan Gilbert
2019-03-08 18:47     ` Zhang, Chen
2019-03-05 15:22 ` [Qemu-devel] [PATCH V3 0/7] Migration/colo: Fix upstream bugs when occur failover Dr. David Alan Gilbert
2019-03-05 15:33   ` Zhang, Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190303145021.2962-7-chen.zhang@intel.com \
    --to=chen.zhang@intel.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=zhang.zhanghailiang@huawei.com \
    --cc=zhangckid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).