From: Gerd Hoffmann <kraxel@redhat.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, armbru@redhat.com,
eblake@redhat.com, Eddie Kohler <ekohler@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] curses: add option to specify VGA font encoding
Date: Mon, 4 Mar 2019 09:03:38 +0100 [thread overview]
Message-ID: <20190304080338.jalgvluxwqiygqi2@sirius.home.kraxel.org> (raw)
In-Reply-To: <20190303104430.7692-3-samuel.thibault@ens-lyon.org>
On Sun, Mar 03, 2019 at 11:44:30AM +0100, Samuel Thibault wrote:
> This uses iconv to convert glyphs from the specified VGA font encoding to
> unicode, and makes use of cchar_t instead of chtype when using ncursesw,
> which allows to store all wide char as well as the WACS values.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Cc: Eddie Kohler <ekohler@gmail.com>
So the difference to the patch from Eddie is that charset
is configurable instead of being hard-coded to CP437?
> +# @charset: Font charset used by guest (default: CP437).
> @@ -1139,7 +1140,8 @@
> 'base' : { 'type' : 'DisplayType',
> '*full-screen' : 'bool',
> '*window-close' : 'bool',
> - '*gl' : 'DisplayGLMode' },
> + '*gl' : 'DisplayGLMode',
> + '*charset' : 'str' },
No. Please add a new DisplayCurses struct for the charset option. It
will only be used by the curses UI and it is highly unlikely that this
will ever change as only curses needs this (the graphical UIs will just
use whatever font the guest loaded into the vga).
cheers,
Gerd
next prev parent reply other threads:[~2019-03-04 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 10:44 [Qemu-devel] [PATCH 0/2] curses: Add support for wide output Samuel Thibault
2019-03-03 10:44 ` [Qemu-devel] [PATCH 1/2] iconv: detect and make curses depend on it Samuel Thibault
2019-03-03 10:44 ` [Qemu-devel] [PATCH 2/2] curses: add option to specify VGA font encoding Samuel Thibault
2019-03-04 6:44 ` Markus Armbruster
2019-03-04 7:08 ` Samuel Thibault
2019-03-04 8:55 ` Markus Armbruster
2019-03-04 8:03 ` Gerd Hoffmann [this message]
2019-03-04 8:06 ` Samuel Thibault
2019-03-04 16:56 ` Eddie Kohler
2019-03-04 18:32 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2016-10-30 14:01 [Qemu-devel] [PATCHv2 0/2] curses: use wide output functions Samuel Thibault
2016-10-30 14:01 ` [Qemu-devel] [PATCH 2/2] curses: add option to specify VGA font encoding Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304080338.jalgvluxwqiygqi2@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=ekohler@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).