qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	peter.maydell@linaro.org, shameerali.kolothum.thodi@huawei.com,
	imammedo@redhat.com, david@redhat.com
Cc: dgilbert@redhat.com, david@gibson.dropbear.id.au,
	drjones@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v12 06/10] vl: Set machine ram_size, maxram_size and ram_slots earlier
Date: Mon,  4 Mar 2019 11:13:35 +0100	[thread overview]
Message-ID: <20190304101339.25970-7-eric.auger@redhat.com> (raw)
In-Reply-To: <20190304101339.25970-1-eric.auger@redhat.com>

The machine RAM attributes will need to be analyzed during the
configure_accelerator() process. especially kvm_type() arm64
machine callback will use them to know how many IPA/GPA bits are
needed to model the whole RAM range. So let's assign those machine
state fields before calling configure_accelerator.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

---
v7 -> v8:
- added Igor's R-b

v6 -> v7:
- add Peter's R-b

v4: new
---
 vl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/vl.c b/vl.c
index 502857a176..fd0d51320d 100644
--- a/vl.c
+++ b/vl.c
@@ -4239,6 +4239,9 @@ int main(int argc, char **argv, char **envp)
     machine_opts = qemu_get_machine_opts();
     qemu_opt_foreach(machine_opts, machine_set_property, current_machine,
                      &error_fatal);
+    current_machine->ram_size = ram_size;
+    current_machine->maxram_size = maxram_size;
+    current_machine->ram_slots = ram_slots;
 
     configure_accelerator(current_machine, argv[0]);
 
@@ -4434,9 +4437,6 @@ int main(int argc, char **argv, char **envp)
     replay_checkpoint(CHECKPOINT_INIT);
     qdev_machine_init();
 
-    current_machine->ram_size = ram_size;
-    current_machine->maxram_size = maxram_size;
-    current_machine->ram_slots = ram_slots;
     current_machine->boot_order = boot_order;
 
     /* parse features once if machine provides default cpu_type */
-- 
2.20.1

  parent reply	other threads:[~2019-03-04 10:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 10:13 [Qemu-devel] [PATCH v12 00/10] ARM virt: Initial RAM expansion and extended memory map Eric Auger
2019-03-04 10:13 ` [Qemu-devel] [PATCH v12 01/10] hw/arm/boot: introduce fdt_add_memory_node helper Eric Auger
2019-03-04 10:13 ` [Qemu-devel] [PATCH v12 02/10] hw/arm/virt: Rename highmem IO regions Eric Auger
2019-03-04 10:13 ` [Qemu-devel] [PATCH v12 03/10] hw/arm/virt: Split the memory map description Eric Auger
2019-03-04 10:13 ` [Qemu-devel] [PATCH v12 04/10] hw/boards: Add a MachineState parameter to kvm_type callback Eric Auger
2019-03-04 10:13 ` [Qemu-devel] [PATCH v12 05/10] kvm: add kvm_arm_get_max_vm_ipa_size Eric Auger
2019-03-04 10:13 ` Eric Auger [this message]
2019-03-04 10:13 ` [Qemu-devel] [PATCH v12 07/10] hw/arm/virt: Dynamic memory map depending on RAM requirements Eric Auger
2019-03-04 10:13 ` [Qemu-devel] [PATCH v12 08/10] hw/arm/virt: Implement kvm_type function for 4.0 machine Eric Auger
2019-03-04 10:13 ` [Qemu-devel] [PATCH v12 09/10] hw/arm/virt: Check the VCPU PA range in TCG mode Eric Auger
2019-03-04 10:13 ` [Qemu-devel] [PATCH v12 10/10] hw/arm/virt: Bump the 255GB initial RAM limit Eric Auger
2019-03-04 17:11 ` [Qemu-devel] [PATCH v12 00/10] ARM virt: Initial RAM expansion and extended memory map Auger Eric
2019-03-04 18:38   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190304101339.25970-7-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shameerali.kolothum.thodi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).