From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PULL 08/27] s390x/tcg: Clarify terminology in vec_reg_offset()
Date: Mon,  4 Mar 2019 13:01:51 +0100	[thread overview]
Message-ID: <20190304120210.31500-9-cohuck@redhat.com> (raw)
In-Reply-To: <20190304120210.31500-1-cohuck@redhat.com>
From: David Hildenbrand <david@redhat.com>
We will use s390x speak "Element Size" (es) for MO_8 == 0, MO_16 == 1
... Simple rename of variables.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190225200318.16102-4-david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/translate.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index c646e50eb388..6647a67998ba 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -145,10 +145,11 @@ void s390x_translate_init(void)
     }
 }
 
-static inline int vec_reg_offset(uint8_t reg, uint8_t enr, TCGMemOp size)
+static inline int vec_reg_offset(uint8_t reg, uint8_t enr, TCGMemOp es)
 {
-    const uint8_t es = 1 << size;
-    int offs = enr * es;
+    /* Convert element size (es) - e.g. MO_8 - to bytes */
+    const uint8_t bytes = 1 << es;
+    int offs = enr * bytes;
 
     g_assert(reg < 32);
     /*
@@ -173,9 +174,9 @@ static inline int vec_reg_offset(uint8_t reg, uint8_t enr, TCGMemOp size)
      * the two 8 byte elements have to be loaded separately. Let's force all
      * 16 byte operations to handle it in a special way.
      */
-    g_assert(size <= MO_64);
+    g_assert(es <= MO_64);
 #ifndef HOST_WORDS_BIGENDIAN
-    offs ^= (8 - es);
+    offs ^= (8 - bytes);
 #endif
     return offs + offsetof(CPUS390XState, vregs[reg][0].d);
 }
-- 
2.17.2
next prev parent reply	other threads:[~2019-03-04 12:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 12:01 [Qemu-devel] [PULL 00/27] s390x updates Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 01/27] s390x: Use cpu_to_be64 in SIGP STORE ADDITIONAL STATUS Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 02/27] s390x: use a QEMU-style typedef + name for SIGP save area struct Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 03/27] s390x/tcg: Save vregs to extended mchk save area Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 04/27] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 05/27] s390x/vfio-ap: document " Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 06/27] s390x/tcg: RXE has an optional M3 field Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 07/27] s390x/tcg: Simplify disassembler operands initialization Cornelia Huck
2019-03-04 12:01 ` Cornelia Huck [this message]
2019-03-04 12:01 ` [Qemu-devel] [PULL 09/27] s390x/tcg: Factor out vec_full_reg_offset() Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 10/27] s390x/tcg: Factor out gen_addi_and_wrap_i64() from get_address() Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 11/27] s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 12/27] s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 13/27] s390x/tcg: Fix TEST DATA CLASS instructions Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 14/27] s390x/tcg: Fix rounding from float128 to uint64_t/uint32_t Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 15/27] s390x/tcg: Factor out conversion of softfloat exceptions Cornelia Huck
2019-03-04 12:01 ` [Qemu-devel] [PULL 16/27] s390x/tcg: Fix parts of IEEE exception handling Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 17/27] s390x/tcg: Hide IEEE underflows in some scenarios Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 18/27] s390x/tcg: Refactor SET FPC AND SIGNAL handling Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 19/27] s390x/tcg: Fix simulated-IEEE exceptions Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 20/27] s390x/tcg: Handle SET FPC AND LOAD FPC 3-bit BFP rounding modes Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 21/27] s390x/tcg: Check for exceptions in SET BFP ROUNDING MODE Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 22/27] s390x/tcg: Refactor saving/restoring the bfp rounding mode Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 23/27] s390x/tcg: Prepare for IEEE-inexact-exception control (XxC) Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 24/27] s390x/tcg: Implement XxC and checks for most FP instructions Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 25/27] s390x/tcg: Implement rounding mode and XxC for LOAD ROUNDED Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 26/27] s390x/tcg: Handle all rounding modes overwritten by BFP instructions Cornelia Huck
2019-03-04 12:02 ` [Qemu-devel] [PULL 27/27] s390x: Add floating-point extension facility to "qemu" cpu model Cornelia Huck
2019-03-04 14:29 ` [Qemu-devel] [PULL 00/27] s390x updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20190304120210.31500-9-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).