qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	peter.maydell@linaro.org, ehabkost@redhat.com,
	libvir-list@redhat.com, qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com,
	david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [Qemu-ppc] [libvirt] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option
Date: Mon, 4 Mar 2019 14:55:10 +0100	[thread overview]
Message-ID: <20190304145510.57c73177@redhat.com> (raw)
In-Reply-To: <15464582-e8a6-6654-7679-15d87c10af38@redhat.com>

On Mon, 4 Mar 2019 09:11:19 +0100
Thomas Huth <thuth@redhat.com> wrote:

> On 01/03/2019 18.48, Daniel P. Berrangé wrote:
> [...]
> > So I think this patch has to be dropped & replaced with one that
> > simply documents that memdev syntax is preferred.  
> 
> That's definitely not enough. I've had a couple of cases already where
> we documented that certain options should not be used anymore, and
> people simply ignored it (aka. if it ain't broken, don't do any change).
> Then they just started to complain when I really tried to remove the
> option after the deprecation period.

> So Igor, if you can not officially deprecate these things here yet, you
> should at least make sure that they can not be used with new machine
> types anymore. Then, after a couple of years, when we feel sure that
> there are only some few or no people left who still use it with the old
> machine types, we can start to discuss the deprecation process again, I
> think.
Is it acceptable to silently disable CLI options (even if they are broken
like in this case) for new machine types?
I was under impression that it should go through deprecation first.

> 
>  Thomas
> 

  reply	other threads:[~2019-03-04 13:55 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01 15:42 [Qemu-devel] [PATCH 0/2] numa: deprecate -numa node, mem and default memory distribution Igor Mammedov
2019-03-01 15:42 ` [Qemu-devel] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option Igor Mammedov
2019-03-01 15:49   ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
2019-03-01 17:33     ` Igor Mammedov
2019-03-01 17:48       ` Daniel P. Berrangé
2019-03-04  7:13         ` Markus Armbruster
2019-03-04 10:19           ` Daniel P. Berrangé
2019-03-04 11:45             ` Markus Armbruster
2019-03-04 15:28               ` Daniel P. Berrangé
2019-03-04 15:46                 ` Igor Mammedov
2019-03-10 10:14                 ` Markus Armbruster
2019-03-04 14:24             ` Michal Privoznik
2019-03-04 15:03               ` Igor Mammedov
2019-03-04 12:25           ` Igor Mammedov
2019-03-04 12:39             ` Daniel P. Berrangé
2019-03-04 14:16               ` Igor Mammedov
2019-03-04 14:24                 ` Daniel P. Berrangé
2019-03-04 15:19                   ` Igor Mammedov
2019-03-04 16:12                     ` Michal Privoznik
2019-03-04 16:27                       ` Daniel P. Berrangé
2019-03-04 16:20                   ` Michal Privoznik
2019-03-04 16:31                     ` Dr. David Alan Gilbert
2019-03-04 16:35                     ` Daniel P. Berrangé
2019-03-06 19:03                       ` Igor Mammedov
2019-03-07  9:59                         ` Daniel P. Berrangé
2019-03-10 10:16                           ` Markus Armbruster
2019-03-06 19:56                     ` Igor Mammedov
2019-03-04 14:34                 ` Michal Privoznik
2019-03-04  8:11         ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2019-03-04 13:55           ` Igor Mammedov [this message]
2019-03-04 13:59             ` Daniel P. Berrangé
2019-03-04 14:54               ` Igor Mammedov
2019-03-04 15:02                 ` Daniel P. Berrangé
2019-03-04 16:45                   ` Igor Mammedov
2019-03-01 18:01       ` [Qemu-devel] " Dr. David Alan Gilbert
2019-03-04 13:52         ` Igor Mammedov
2019-03-01 15:42 ` [Qemu-devel] [PATCH 2/2] numa: deprecate implict memory distribution between nodes Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190304145510.57c73177@redhat.com \
    --to=imammedo@redhat.com \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).