From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 00/12] vhost-user-backend & vhost-user-input
Date: Tue, 5 Mar 2019 15:56:45 -0500 [thread overview]
Message-ID: <20190305155635-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190227103017.29515-1-marcandre.lureau@redhat.com>
On Wed, Feb 27, 2019 at 11:30:05AM +0100, Marc-André Lureau wrote:
> Hi,
>
> This series is based on previously discussed "[PATCH v4 00/29]
> vhost-user for input & GPU" and "vhost-user: define conventions for
> vhost-user backends" work. The GPU part is left off for now.
>
> This series introduces a "vhost-user-backend": an helper object to be
> used by vhost-user devices to ease with backend initialization and
> handling. As a simple showcase, a "vhost-user-input-pci" device is
> introduced, which can be used with the "contrib: add vhost-user-input"
> example. vhost-user-input isn't meant to be installed, discovered or
> used by libvirt: no installation is done (no vhost-user JSON file is
> provided either).
>
> thanks
can you rebase on top of master pls?
> v4:
> - drop "RFC: add explicit can_migrate to vhost_user_backend_dev_init()"
> - remove useless "cmd" struct field leftover
>
> v3:
> - add previously sent patch "libvhost-user: fix clang enum-conversion
> warning" to fix clang build
> - "define conventions for vhost-user backends" updates after Eric review
> - Drop user-creatable from vhost-user-backend
> - Make vhost-user-input-pci take a chardev= (instead of vhost-user=)
>
> v2:
> - rebased (VhostUserInputPCI got most of the changes, due to split)
> - added "RFC: add explicit can_migrate to
> vhost_user_backend_dev_init()" to attempt to address Michael
> concerns about migration.
>
> Marc-André Lureau (12):
> libvhost-user: fix clang enum-conversion warning
> vhost-user: define conventions for vhost-user backends
> vhost-user: simplify vhost_user_init/vhost_user_cleanup
> libvhost-user: exit by default on VHOST_USER_NONE
> vhost-user: wrap some read/write with retry handling
> Add vhost-user-backend
> vhost-user: split vhost_user_read()
> vhost-user: add vhost_user_input_get_config()
> libvhost-user-glib: export vug_source_new()
> libvhost-user: add vu_queue_unpop()
> Add vhost-user-input-pci
> contrib: add vhost-user-input
>
> contrib/libvhost-user/libvhost-user-glib.h | 3 +
> contrib/libvhost-user/libvhost-user.h | 17 +-
> include/hw/virtio/vhost-backend.h | 4 +
> include/hw/virtio/vhost-user-blk.h | 2 +-
> include/hw/virtio/vhost-user-scsi.h | 2 +-
> include/hw/virtio/vhost-user.h | 2 +-
> include/hw/virtio/virtio-input.h | 14 +
> include/sysemu/vhost-user-backend.h | 58 +++
> backends/cryptodev-vhost-user.c | 18 +-
> backends/vhost-user.c | 213 +++++++++++
> contrib/libvhost-user/libvhost-user-glib.c | 11 +-
> contrib/libvhost-user/libvhost-user.c | 19 +-
> contrib/vhost-user-input/main.c | 398 +++++++++++++++++++++
> hw/block/vhost-user-blk.c | 22 +-
> hw/input/vhost-user-input.c | 99 +++++
> hw/scsi/vhost-user-scsi.c | 20 +-
> hw/virtio/vhost-stub.c | 4 +-
> hw/virtio/vhost-user-input-pci.c | 53 +++
> hw/virtio/vhost-user.c | 118 +++++-
> net/vhost-user.c | 13 +-
> MAINTAINERS | 5 +
> Makefile | 3 +
> Makefile.objs | 1 +
> backends/Makefile.objs | 3 +-
> configure | 3 +
> contrib/vhost-user-input/Makefile.objs | 1 +
> default-configs/virtio.mak | 1 +
> docs/interop/vhost-user.json | 232 ++++++++++++
> docs/interop/vhost-user.txt | 109 +++++-
> hw/input/Makefile.objs | 1 +
> hw/virtio/Makefile.objs | 1 +
> 31 files changed, 1363 insertions(+), 87 deletions(-)
> create mode 100644 include/sysemu/vhost-user-backend.h
> create mode 100644 backends/vhost-user.c
> create mode 100644 contrib/vhost-user-input/main.c
> create mode 100644 hw/input/vhost-user-input.c
> create mode 100644 hw/virtio/vhost-user-input-pci.c
> create mode 100644 contrib/vhost-user-input/Makefile.objs
> create mode 100644 docs/interop/vhost-user.json
>
> --
> 2.21.0
prev parent reply other threads:[~2019-03-05 20:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 10:30 [Qemu-devel] [PATCH v4 00/12] vhost-user-backend & vhost-user-input Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 01/12] libvhost-user: fix clang enum-conversion warning Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 02/12] vhost-user: define conventions for vhost-user backends Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 03/12] vhost-user: simplify vhost_user_init/vhost_user_cleanup Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 04/12] libvhost-user: exit by default on VHOST_USER_NONE Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 05/12] vhost-user: wrap some read/write with retry handling Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 06/12] Add vhost-user-backend Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 07/12] vhost-user: split vhost_user_read() Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 08/12] vhost-user: add vhost_user_input_get_config() Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 09/12] libvhost-user-glib: export vug_source_new() Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 10/12] libvhost-user: add vu_queue_unpop() Marc-André Lureau
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 11/12] Add vhost-user-input-pci Marc-André Lureau
2019-02-27 13:13 ` Gerd Hoffmann
2019-02-27 10:30 ` [Qemu-devel] [PATCH v4 12/12] contrib: add vhost-user-input Marc-André Lureau
2019-02-27 13:14 ` Gerd Hoffmann
2019-02-27 10:46 ` [Qemu-devel] [PATCH v4 00/12] vhost-user-backend & vhost-user-input Marc-André Lureau
2019-03-05 20:56 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305155635-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).