Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] Re-applying Freescale PPC E500 i2c/RTC patch

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 4881 bytes --]

On Mon, Mar 04, 2019 at 01:26:27PM +0300, Andrew Randrianasulu wrote:
> В сообщении от Monday 04 March 2019 05:51:27 BALATON Zoltan написал(а):
> > On Mon, 4 Mar 2019, Andrew Randrianasulu wrote:
> > > From: Amit Singh Tomar <amit.tomar@freescale.com>
> > >
> > > Original commit message:
> > > This patch adds an emulation model for i2c controller found on most of the FSL SoCs.
> > > It also integrates the RTC (ds1338) that sits on the i2c Bus with e500 machine model.
> > >
> > > Patch was originally written by Amit Singh Tomar <amit.tomar@freescale.com>
> > > see http://patchwork.ozlabs.org/patch/431475/
> > > I only fixed it enough for application on top of current qemu master
> > > 20b084c4b1401b7f8fbc385649d48c67b6f43d44, and hopefully fixed checkpatch errors
> > >
> > > Tested by booting Linux kernel 4.20.12. Now e500 machine doesn't need
> > > network time protocol daemon because it will have working RTC
> > > (before all timestamps on files were from 2016)
> > >
> > > ---
> > >
> > > v1->v2: Expanded and fixed commit message
> > >
> > >
> > > Signed-off-by: Andrew Randrianasulu <randrianasulu@gmail.com>
> > > ---
> > 
> > Almost... Patch now applies but subject and commit message are not yet 
> > right. Look at existing commit messages for examples how it should look 
> > (e.g. git log hw/ppc/e500.c). The email subject will become commit title, 
> > this should start with something showing which part you change like e500:. 
> > Then one line summary of what the patch is doing. You can probably keep 
> > original title, no need to say re-applying or things like that there. You 
> > can explain this in patch body. The text up to the first --- will be the 
> > body of the commit message so you should describe in more detail what the 
> > patch does here. Also this should include all Signed-off-by and other 
> > tags at the end before the ---.
> > 
> > Everything after --- are additional comments that won't be included in the 
> > commit message so you can put version history or any other remarks there 
> > that should not be kept after applying the patch.
> > 
> > This patch is missing Signed-off-by of the original author and has yours 
> > below --- that's why checkpatch complains. You should keep the the 
> > original Signed-off-by even if you add From: of the original author. I 
> > think you may not include From: since you're not forwarding a patch 
> > unchanged but this is now your patch based on the original since you've 
> > changed it so it can have your From: address from email header and 
> > Signed-off-by of both original author and yours to show where it came from 
> > originally. You can also mention this in commit message to make it clear.
> > 
> > Or you can keep From of original author and explain in commit message what 
> > you've changed but it still needs both Signed-off-by lines even then.
> > 
> > Hopefully this makes sense. This should already be explained in the 
> > SubmitAPatch wiki page but that can be complicated at first.
> 
> Thanks for explaining all this.
> Right now top of my patch looks like this:
> 
> From ad2b4baf8b369c8ef354e56f75ae780413acd989 Mon Sep 17 00:00:00 2001
> From: Andrew Randrianasulu <randrianasulu@gmail.com>
> Date: Sun, 3 Mar 2019 00:05:04 +0300
> Subject: [PATCH v3] PPC: E500: Add FSL I2C controller and integrate RTC with it
> 
> Original commit message:
> This patch adds an emulation model for i2c controller found on most of the FSL SoCs.
> It also integrates the RTC (ds1338) that sits on the i2c Bus with e500 machine model.
> 
> Patch was originally written by Amit Singh Tomar <amit.tomar@freescale.com>
> see http://patchwork.ozlabs.org/patch/431475/
> I only fixed it enough for application on top of current qemu master
> 20b084c4b1401b7f8fbc385649d48c67b6f43d44, and hopefully fixed checkpatch errors
> 
> Tested by booting Linux kernel 4.20.12. Now e500 machine doesn't need.
> network time protocol daemon because it will have working RTC.
> (before all timestamps on files were from 2016)
> 
> 
> Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
> Signed-off-by: Andrew Randrianasulu <randrianasulu@gmail.com>
> ---
> 
> v1->v2: Expanded and fixed commit message
> 
> v2->v3: Changed Subject line back to original and From: field to.
> my email address, moved my SoB line above first '---' and
> added Tomar's Signed-off line back.
> 
> ---
> 
> is it OK ok to send? (assuming it applies, compiles and boots, I test this now
> with git am, make and launching qemu with -kernel option.)

That looks good, please go ahead and send.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]