* [Qemu-devel] [PATCH] vhost-user-test: fix leaks
@ 2019-03-05 22:51 Marc-André Lureau
2019-03-06 6:35 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Marc-André Lureau @ 2019-03-05 22:51 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, Marc-André Lureau, Thomas Huth, Laurent Vivier
Spotted by ASAN.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/vhost-user-test.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index 4cd0a97f13..9364227ba4 100644
--- a/tests/vhost-user-test.c
+++ b/tests/vhost-user-test.c
@@ -588,6 +588,7 @@ static void test_server_free(TestServer *server)
g_test_message("unable to rmdir: path (%s): %s",
server->tmpfs, strerror(errno));
}
+ g_free(server->tmpfs);
qemu_chr_fe_deinit(&server->chr, true);
@@ -605,6 +606,8 @@ static void test_server_free(TestServer *server)
g_main_loop_unref(server->loop);
g_main_context_unref(server->context);
+ g_cond_clear(&server->data_cond);
+ g_mutex_clear(&server->data_mutex);
g_free(server);
}
--
2.21.0.4.g36eb1cb9cf
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] vhost-user-test: fix leaks
2019-03-05 22:51 [Qemu-devel] [PATCH] vhost-user-test: fix leaks Marc-André Lureau
@ 2019-03-06 6:35 ` Thomas Huth
2019-03-06 14:17 ` Michael S. Tsirkin
2019-03-06 9:08 ` Stefano Garzarella
2019-03-06 9:28 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2019-03-06 6:35 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel
Cc: pbonzini, Laurent Vivier, Michael S . Tsirkin
On 05/03/2019 23.51, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/vhost-user-test.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 4cd0a97f13..9364227ba4 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -588,6 +588,7 @@ static void test_server_free(TestServer *server)
> g_test_message("unable to rmdir: path (%s): %s",
> server->tmpfs, strerror(errno));
> }
> + g_free(server->tmpfs);
>
> qemu_chr_fe_deinit(&server->chr, true);
>
> @@ -605,6 +606,8 @@ static void test_server_free(TestServer *server)
>
> g_main_loop_unref(server->loop);
> g_main_context_unref(server->context);
> + g_cond_clear(&server->data_cond);
> + g_mutex_clear(&server->data_mutex);
> g_free(server);
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
... and queued to my qtest-next branch (unless Michael wants to take it
through hist vhost tree instead).
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] vhost-user-test: fix leaks
2019-03-06 6:35 ` Thomas Huth
@ 2019-03-06 14:17 ` Michael S. Tsirkin
0 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2019-03-06 14:17 UTC (permalink / raw)
To: Thomas Huth; +Cc: Marc-André Lureau, qemu-devel, pbonzini, Laurent Vivier
On Wed, Mar 06, 2019 at 07:35:28AM +0100, Thomas Huth wrote:
> On 05/03/2019 23.51, Marc-André Lureau wrote:
> > Spotted by ASAN.
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > tests/vhost-user-test.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> > index 4cd0a97f13..9364227ba4 100644
> > --- a/tests/vhost-user-test.c
> > +++ b/tests/vhost-user-test.c
> > @@ -588,6 +588,7 @@ static void test_server_free(TestServer *server)
> > g_test_message("unable to rmdir: path (%s): %s",
> > server->tmpfs, strerror(errno));
> > }
> > + g_free(server->tmpfs);
> >
> > qemu_chr_fe_deinit(&server->chr, true);
> >
> > @@ -605,6 +606,8 @@ static void test_server_free(TestServer *server)
> >
> > g_main_loop_unref(server->loop);
> > g_main_context_unref(server->context);
> > + g_cond_clear(&server->data_cond);
> > + g_mutex_clear(&server->data_mutex);
> > g_free(server);
> > }
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> ... and queued to my qtest-next branch (unless Michael wants to take it
> through hist vhost tree instead).
No it's fine.
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vhost-user-test: fix leaks
2019-03-05 22:51 [Qemu-devel] [PATCH] vhost-user-test: fix leaks Marc-André Lureau
2019-03-06 6:35 ` Thomas Huth
@ 2019-03-06 9:08 ` Stefano Garzarella
2019-03-06 9:28 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 5+ messages in thread
From: Stefano Garzarella @ 2019-03-06 9:08 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, Laurent Vivier, pbonzini, Thomas Huth
On Tue, Mar 05, 2019 at 11:51:35PM +0100, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/vhost-user-test.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vhost-user-test: fix leaks
2019-03-05 22:51 [Qemu-devel] [PATCH] vhost-user-test: fix leaks Marc-André Lureau
2019-03-06 6:35 ` Thomas Huth
2019-03-06 9:08 ` Stefano Garzarella
@ 2019-03-06 9:28 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-03-06 9:28 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel; +Cc: Laurent Vivier, pbonzini, Thomas Huth
On 3/5/19 11:51 PM, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/vhost-user-test.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 4cd0a97f13..9364227ba4 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -588,6 +588,7 @@ static void test_server_free(TestServer *server)
> g_test_message("unable to rmdir: path (%s): %s",
> server->tmpfs, strerror(errno));
> }
> + g_free(server->tmpfs);
Fixes: ae31fb54914 and 4d3f50eb489
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> qemu_chr_fe_deinit(&server->chr, true);
>
> @@ -605,6 +606,8 @@ static void test_server_free(TestServer *server)
>
> g_main_loop_unref(server->loop);
> g_main_context_unref(server->context);
> + g_cond_clear(&server->data_cond);
> + g_mutex_clear(&server->data_mutex);
> g_free(server);
> }
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-06 14:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-05 22:51 [Qemu-devel] [PATCH] vhost-user-test: fix leaks Marc-André Lureau
2019-03-06 6:35 ` Thomas Huth
2019-03-06 14:17 ` Michael S. Tsirkin
2019-03-06 9:08 ` Stefano Garzarella
2019-03-06 9:28 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).