From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1UPf-0005KT-HZ for qemu-devel@nongnu.org; Wed, 06 Mar 2019 06:08:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1UPZ-0002Qq-KN for qemu-devel@nongnu.org; Wed, 06 Mar 2019 06:08:35 -0500 From: Laurent Vivier Date: Wed, 6 Mar 2019 12:07:05 +0100 Message-Id: <20190306110711.309-5-laurent@vivier.eu> In-Reply-To: <20190306110711.309-1-laurent@vivier.eu> References: <20190306110711.309-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 04/10] hw/acpi: remove unnecessary variable acpi_table_builtin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Riku Voipio , Zhang Chen , zhanghailiang , Christian Borntraeger , Cornelia Huck , Kevin Wolf , Richard Henderson , Thomas Huth , Igor Mammedov , Li Zhijian , John Snow , Halil Pasic , Pavel Dovgalyuk , Laurent Vivier , Eduardo Habkost , qemu-block@nongnu.org, Marcel Apfelbaum , Tony Krowiak , Max Reitz , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Laurent Vivier , Michael Tokarev , qemu-s390x@nongnu.org, Corey Minyard , Pierre Morel , Wei Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= From: Wei Yang acpi_table_builtin is now always false, it is not necessary to check it again. This patch just removes it. Signed-off-by: Wei Yang Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Message-Id: <20190214084939.20640-4-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier --- hw/acpi/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index 9f22b86fa9b1..9ed1629f3671 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -307,8 +307,6 @@ out: error_propagate(errp, err); } -static bool acpi_table_builtin = false; - unsigned acpi_table_len(void *current) { struct acpi_table_header *hdr = current - sizeof(hdr->_length); @@ -324,7 +322,7 @@ void *acpi_table_hdr(void *h) uint8_t *acpi_table_first(void) { - if (acpi_table_builtin || !acpi_tables) { + if (!acpi_tables) { return NULL; } return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE); -- 2.20.1