From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:46405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1V9k-0000Gy-Cb for qemu-devel@nongnu.org; Wed, 06 Mar 2019 06:56:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1V9i-00066D-Rl for qemu-devel@nongnu.org; Wed, 06 Mar 2019 06:56:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54160) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1V9i-00065U-Cy for qemu-devel@nongnu.org; Wed, 06 Mar 2019 06:56:14 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7681E30718D4 for ; Wed, 6 Mar 2019 11:56:13 +0000 (UTC) From: Peter Xu Date: Wed, 6 Mar 2019 19:55:31 +0800 Message-Id: <20190306115532.23025-5-peterx@redhat.com> In-Reply-To: <20190306115532.23025-1-peterx@redhat.com> References: <20190306115532.23025-1-peterx@redhat.com> Subject: [Qemu-devel] [PATCH v2 4/5] iothread: push gcontext earlier in the thread_fn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Eric Blake , Stefan Hajnoczi , peterx@redhat.com, Paolo Bonzini We were pushing the context until right before running the gmainloop. Now since we have everything unconditionally, we can move this earlier. One benefit is that now it's done even before init_done_sem, so as long as the iothread user calls iothread_create() and completes, we know that the thread stack is ready. Signed-off-by: Peter Xu --- iothread.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/iothread.c b/iothread.c index 9abdbace66..045825a348 100644 --- a/iothread.c +++ b/iothread.c @@ -53,7 +53,12 @@ static void *iothread_run(void *opaque) IOThread *iothread = opaque; rcu_register_thread(); - + /* + * We should do this as soon as we enter the thread, because the + * function will silently fail if it fails to acquire the + * gcontext. + */ + g_main_context_push_thread_default(iothread->worker_context); my_iothread = iothread; iothread->thread_id = qemu_get_thread_id(); qemu_sem_post(&iothread->init_done_sem); @@ -66,12 +71,11 @@ static void *iothread_run(void *opaque) * changed in previous aio_poll() */ if (iothread->running && atomic_read(&iothread->run_gcontext)) { - g_main_context_push_thread_default(iothread->worker_context); g_main_loop_run(iothread->main_loop); - g_main_context_pop_thread_default(iothread->worker_context); } } + g_main_context_pop_thread_default(iothread->worker_context); rcu_unregister_thread(); return NULL; } -- 2.17.1