From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, lersek@redhat.com, philmd@redhat.com,
kwolf@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org
Subject: [Qemu-devel] [RFC PATCH v6 0/4] hw/block: better reporting on pflash backing file mismatch
Date: Thu, 7 Mar 2019 10:37:19 +0100 [thread overview]
Message-ID: <20190307093723.655-1-armbru@redhat.com> (raw)
This is Alex's "[PATCH v5] hw/block: better reporting on pflash
backing file mismatch" with the padding split off into its own patch,
and both resulting patches applied to pflash_cfi02.c. I downgraded it
to RFC for two reasons:
1. I think the padding patches should not be applied. I'll reply to
PATCH 2 to explain why.
2. I left the update of pflash_cfi02.c as separate fixup patches, so
we can easily ignore them while we discuss 1.
v6:
* Split padding into its own patch.
* Delete "It should be padded to a multiple of the flash block size."
comment. Happy to put it back if you can enlighten me about its
purpose.
* Improve both commit messages.
* New fixup patches to pflash_cfi02.c.
Alex Bennée (2):
hw/block: better reporting on pflash backing file mismatch
hw/block: Pad undersized read-only images with 0xFF
Markus Armbruster (2):
fixup! hw/block: better reporting on pflash backing file mismatch
fixup! hw/block: Pad undersized read-only images with 0xFF
hw/block/pflash_cfi01.c | 41 ++++++++++++++++++++++++++++++++++-------
hw/block/pflash_cfi02.c | 40 ++++++++++++++++++++++++++++++++++------
2 files changed, 68 insertions(+), 13 deletions(-)
--
2.17.2
next reply other threads:[~2019-03-07 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 9:37 Markus Armbruster [this message]
2019-03-07 9:37 ` [Qemu-devel] [RFC PATCH v6 1/4] hw/block: better reporting on pflash backing file mismatch Markus Armbruster
2019-03-07 15:05 ` Alex Bennée
2019-03-07 17:14 ` Markus Armbruster
2019-03-07 9:37 ` [Qemu-devel] [RFC PATCH v6 2/4] hw/block: Pad undersized read-only images with 0xFF Markus Armbruster
2019-03-07 10:05 ` Markus Armbruster
2019-03-07 14:55 ` Kevin Wolf
2019-03-07 17:55 ` Eric Blake
2019-03-07 17:57 ` Markus Armbruster
2019-03-07 18:01 ` Laszlo Ersek
2019-03-07 9:37 ` [Qemu-devel] [RFC PATCH v6 3/4] fixup! hw/block: better reporting on pflash backing file mismatch Markus Armbruster
2019-03-07 9:37 ` [Qemu-devel] [RFC PATCH v6 4/4] fixup! hw/block: Pad undersized read-only images with 0xFF Markus Armbruster
2019-03-07 9:44 ` [Qemu-devel] [RFC PATCH v6 0/4] hw/block: better reporting on pflash backing file mismatch no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307093723.655-1-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).