qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] converting build system to Meson?
Date: Thu, 7 Mar 2019 10:49:38 +0000	[thread overview]
Message-ID: <20190307104938.GM32268@redhat.com> (raw)
In-Reply-To: <13c59d63-1761-b61e-9cb9-039a3ef1be08@redhat.com>

On Thu, Mar 07, 2019 at 11:40:05AM +0100, Paolo Bonzini wrote:
> On 07/03/19 07:39, Thomas Huth wrote:
> > On 06/03/2019 19.12, Paolo Bonzini wrote:
> >> Hi all,
> >>
> >> lately I have been thinking of converting the QEMU build system to
> >> Meson.  Meson is a relatively new build system that can replace
> >> Autotools or hand-written Makefiles such as QEMU; as a die-hard
> >> Autotools fan, I must say that Meson is by far better than anything else
> >> that has ever tried to replace Autotools, and actually has the potential
> >> to do so.
> >>
> >> Advantages of Meson that directly matter for QEMU include:[...]
> > 
> > I'm not objecting a new build system per se, but could you elaborate on
> >  problems of the current QEMU build system that will be fixed by this
> > change?
> 
> In order of importance:
> 
> - Make lacks introspection abilities; people want to be able to quickly
> say "I don't have this security issue because I didn't compile this
> file".  Make only gives you the build logs, which may not be easily
> accessible to the end user.
> 
> - Makefile.objs unnesting does not apply throughout the tree, for
> example it does not apply to tests.  We don't apply it there because it
> it is hard to extend Makefile.objs to dozens of targets and it would
> also be very very slow.  The result is lack of homogeneity between
> places that use Makefile.objs and places that use Makefile.include.
> 
> - Makefile.objs unnesting is hard to understand---granted, you rarely
> have to understand it because it mostly works, but we should consider
> whether it is a local optimum.  For example, how many people know how to
> add a dynamically-loadd module to Makefile.objs?

We have a long standing bug in unnesting which breaks if two dirs
have a .c file with the same name and a per-o file library link:

  https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg02654.html

The nesting stuff is insanely clever, but it is also fragile and full
of dragons like this one.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  parent reply	other threads:[~2019-03-07 10:49 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 18:12 [Qemu-devel] converting build system to Meson? Paolo Bonzini
2019-03-06 18:50 ` Marc-André Lureau
2019-03-06 21:08   ` Paolo Bonzini
2019-03-07 10:29   ` Daniel P. Berrangé
2019-03-07  6:39 ` Thomas Huth
2019-03-07 10:13   ` Peter Maydell
2019-03-07 11:11     ` Paolo Bonzini
2019-03-07 11:29     ` Dr. David Alan Gilbert
2019-03-07 11:32       ` Peter Maydell
2019-03-07 11:49       ` Marc-André Lureau
2019-03-07 11:33     ` Daniel P. Berrangé
2019-03-10 14:21       ` Markus Armbruster
2019-03-10 14:33     ` Markus Armbruster
2019-03-11 16:30       ` Paolo Bonzini
2019-03-07 10:18   ` Daniel P. Berrangé
2019-03-07 10:40   ` Paolo Bonzini
2019-03-07 10:48     ` Peter Maydell
2019-03-07 11:06       ` Paolo Bonzini
2019-03-07 10:49     ` Daniel P. Berrangé [this message]
2019-03-07 10:33 ` Stefan Hajnoczi
2019-03-07 11:54 ` Alex Bennée
2019-03-07 12:56   ` Paolo Bonzini
2019-03-07 13:09     ` Peter Maydell
2019-03-07 13:22       ` Daniel P. Berrangé
2019-03-07 18:13       ` Paolo Bonzini
2019-03-07 18:17         ` Marc-André Lureau
2019-03-07 18:18           ` Peter Maydell
2019-03-07 18:19             ` Peter Maydell
2019-03-07 19:23             ` BALATON Zoltan
2019-03-07 19:50               ` Eric Blake
2019-03-07 20:28             ` Liviu Ionescu
2019-03-08 12:19             ` Daniel P. Berrangé
2019-03-07 19:04           ` Eric Blake
2019-03-07 19:24             ` Eric Blake
2019-03-08 12:21               ` Daniel P. Berrangé
2019-03-07 18:20         ` Alex Bennée
2019-03-08  6:47         ` Gerd Hoffmann
2019-03-08  6:58           ` Thomas Huth
2019-03-08 10:31           ` Peter Maydell
2019-03-08 11:58             ` Gerd Hoffmann
2019-03-08 12:03               ` Peter Maydell
2019-03-08 16:17                 ` Eric Blake
2019-03-08 16:26                   ` Peter Maydell
2019-03-08 16:32                   ` Paolo Bonzini
2019-03-08 16:36                     ` Peter Maydell
2019-03-11  1:09         ` Neal Gompa
2019-03-07 19:05       ` Cleber Rosa
2019-03-10 16:33         ` Markus Armbruster
2019-03-10 16:28 ` Markus Armbruster
2019-03-11  6:42   ` Thomas Huth
2019-03-11 10:14   ` Daniel P. Berrangé
2019-04-18  8:21 ` Markus Armbruster
2019-04-18  8:21   ` Markus Armbruster
2019-04-18  8:35   ` Paolo Bonzini
2019-04-18  8:35     ` Paolo Bonzini
2019-05-27 16:16 ` [Qemu-devel] Status update on Meson features needed by QEMU Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190307104938.GM32268@redhat.com \
    --to=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).